2018-08-04 14:39:49

by zhong jiang

Subject: [PATCH] powpc:feature: of_node_put is not needed after iterator.

for_each_node_by_name iterators only exit normally when the loop
cursor is NULL, So there is no point to call of_node_put.

Signed-off-by: zhong jiang <[email protected]>
---
arch/powerpc/platforms/powermac/feature.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index 3f82cb2..4eb8cb3 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c
@@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
/* On all machines, switch modem & serial ports off */
for_each_node_by_name(np, "ch-a")
initial_serial_shutdown(np);
- of_node_put(np);
for_each_node_by_name(np, "ch-b")
initial_serial_shutdown(np);
- of_node_put(np);
}

void __init
--
1.7.12.4

2018-08-04 20:38:50

by Tyrel Datwyler

Subject: Re: [PATCH] powpc:feature: of_node_put is not needed after iterator.

On 08/04/2018 07:25 AM, zhong jiang wrote:
> for_each_node_by_name iterators only exit normally when the loop
> cursor is NULL, So there is no point to call of_node_put.
>
> Signed-off-by: zhong jiang <[email protected]>

Reviewed-by: Tyrel Datwyler <[email protected]>

> ---
> arch/powerpc/platforms/powermac/feature.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 3f82cb2..4eb8cb3 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
> /* On all machines, switch modem & serial ports off */
> for_each_node_by_name(np, "ch-a")
> initial_serial_shutdown(np);
> - of_node_put(np);
> for_each_node_by_name(np, "ch-b")
> initial_serial_shutdown(np);
> - of_node_put(np);
> }
>
> void __init
>

2018-08-08 14:28:20

by Michael Ellerman

Subject: Re: powpc:feature: of_node_put is not needed after iterator.

On Sat, 2018-08-04 at 14:25:00 UTC, zhong jiang wrote:
> for_each_node_by_name iterators only exit normally when the loop
> cursor is NULL, So there is no point to call of_node_put.
>
> Signed-off-by: zhong jiang <[email protected]>
> Reviewed-by: Tyrel Datwyler <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/81d7b08b3cec79a43411e7175401b3

cheers