2023-03-24 06:13:50

by Mingxuan Xiang

Subject: [PATCH v3] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

According to the description of platform_get_irq()
* Return: non-zero IRQ number on success,
negative error number on failure.
and the code, platform_get_irq() will return -EINVAL
instead of IRQ0.

So platform_get_irq() no longer returns 0, there is no
need to check whether the return value is 0.

Found by Smatch:
drivers/usb/dwc3/host.c:60 dwc3_host_get_irq()
warn: platform_get_irq() does not return zero

Signed-off-by: Mingxuan Xiang <[email protected]>
---
v2->v3: remove curly braces
v1->v2: remove redundant goto
Only compile tested.
---
drivers/usb/dwc3/host.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f6f13e7f1ba1..61f57fe5bb78 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -52,13 +52,8 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
goto out;

irq = platform_get_irq(dwc3_pdev, 0);
- if (irq > 0) {
+ if (irq > 0)
dwc3_host_fill_xhci_irq_res(dwc, irq, NULL);
- goto out;
- }
-
- if (!irq)
- irq = -EINVAL;

out:
return irq;
--
2.39.2

2023-03-24 06:36:47

by Dan Carpenter

Subject: Re: [PATCH v3] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

On Fri, Mar 24, 2023 at 02:09:34PM +0800, Mingxuan Xiang wrote:
> According to the description of platform_get_irq()
> * Return: non-zero IRQ number on success,
> negative error number on failure.
> and the code, platform_get_irq() will return -EINVAL
> instead of IRQ0.
>
> So platform_get_irq() no longer returns 0, there is no
> need to check whether the return value is 0.
>
> Found by Smatch:
> drivers/usb/dwc3/host.c:60 dwc3_host_get_irq()
> warn: platform_get_irq() does not return zero
>
> Signed-off-by: Mingxuan Xiang <[email protected]>
> ---
> v2->v3: remove curly braces
> v1->v2: remove redundant goto
> Only compile tested.

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter

2023-03-24 18:32:24

by Thinh Nguyen

Subject: Re: [PATCH v3] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

On Fri, Mar 24, 2023, Mingxuan Xiang wrote:
> According to the description of platform_get_irq()
> * Return: non-zero IRQ number on success,
> negative error number on failure.
> and the code, platform_get_irq() will return -EINVAL
> instead of IRQ0.
>
> So platform_get_irq() no longer returns 0, there is no
> need to check whether the return value is 0.
>
> Found by Smatch:
> drivers/usb/dwc3/host.c:60 dwc3_host_get_irq()
> warn: platform_get_irq() does not return zero
>
> Signed-off-by: Mingxuan Xiang <[email protected]>
> ---
> v2->v3: remove curly braces
> v1->v2: remove redundant goto
> Only compile tested.
> ---
> drivers/usb/dwc3/host.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f6f13e7f1ba1..61f57fe5bb78 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -52,13 +52,8 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
> goto out;
>
> irq = platform_get_irq(dwc3_pdev, 0);
> - if (irq > 0) {
> + if (irq > 0)
> dwc3_host_fill_xhci_irq_res(dwc, irq, NULL);
> - goto out;
> - }
> -
> - if (!irq)
> - irq = -EINVAL;
>
> out:
> return irq;
> --
> 2.39.2
>

Acked-by: Thinh Nguyen <[email protected]>

Thanks,
Thinh