2020-04-17 07:18:06

by Jason Yan

Subject: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

Fix the following sparse warning:

drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
'bcm7038_l1_of_init' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/irqchip/irq-bcm7038-l1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
index eb9bce93cd05..fd7c537fb42a 100644
--- a/drivers/irqchip/irq-bcm7038-l1.c
+++ b/drivers/irqchip/irq-bcm7038-l1.c
@@ -416,7 +416,7 @@ static const struct irq_domain_ops bcm7038_l1_domain_ops = {
.map = bcm7038_l1_map,
};

-int __init bcm7038_l1_of_init(struct device_node *dn,
+static int __init bcm7038_l1_of_init(struct device_node *dn,
struct device_node *parent)
{
struct bcm7038_l1_chip *intc;
--
2.21.1

2020-04-17 09:58:10

by tip-bot2 for Jacob Pan

Subject: [tip: irq/urgent] irqchip/irq-bcm7038-l1: Make bcm7038_l1_of_init() static

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID: 8f374923de1ced05db3c98b9e4e1ce21c5aede2c
Gitweb: https://git.kernel.org/tip/8f374923de1ced05db3c98b9e4e1ce21c5aede2c
Author: Jason Yan <[email protected]>
AuthorDate: Fri, 17 Apr 2020 15:40:36 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Fri, 17 Apr 2020 08:59:30 +01:00

irqchip/irq-bcm7038-l1: Make bcm7038_l1_of_init() static

Fix the following sparse warning:

drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
'bcm7038_l1_of_init' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-bcm7038-l1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
index eb9bce9..fd7c537 100644
--- a/drivers/irqchip/irq-bcm7038-l1.c
+++ b/drivers/irqchip/irq-bcm7038-l1.c
@@ -416,7 +416,7 @@ static const struct irq_domain_ops bcm7038_l1_domain_ops = {
.map = bcm7038_l1_map,
};

-int __init bcm7038_l1_of_init(struct device_node *dn,
+static int __init bcm7038_l1_of_init(struct device_node *dn,
struct device_node *parent)
{
struct bcm7038_l1_chip *intc;

2020-04-17 10:28:43

by Sergei Shtylyov

Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

Hello!

On 17.04.2020 10:40, Jason Yan wrote:

> Fix the following sparse warning:
>
> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
> 'bcm7038_l1_of_init' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/irqchip/irq-bcm7038-l1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
> index eb9bce93cd05..fd7c537fb42a 100644
> --- a/drivers/irqchip/irq-bcm7038-l1.c
> +++ b/drivers/irqchip/irq-bcm7038-l1.c
> @@ -416,7 +416,7 @@ static const struct irq_domain_ops bcm7038_l1_domain_ops = {
> .map = bcm7038_l1_map,
> };
>
> -int __init bcm7038_l1_of_init(struct device_node *dn,
> +static int __init bcm7038_l1_of_init(struct device_node *dn,
> struct device_node *parent)

Reindent the above line please, it should start under *struct* on the 1st
line.

[...]

MBR, Sergei

2020-04-17 10:59:00

by Jason Yan

Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

在 2020/4/17 18:26, Sergei Shtylyov 写道:
> Hello!
>
> On 17.04.2020 10:40, Jason Yan wrote:
>
>> Fix the following sparse warning:
>>
>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Jason Yan <[email protected]>
>> ---
>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>> b/drivers/irqchip/irq-bcm7038-l1.c
>> index eb9bce93cd05..fd7c537fb42a 100644
>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>> bcm7038_l1_domain_ops = {
>>       .map            = bcm7038_l1_map,
>>   };
>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>                     struct device_node *parent)
>
>    Reindent the above line please, it should start under *struct* on
> the 1st line.

OK, will cook a new one.

>
> [...]
>
> MBR, Sergei
>
> .

2020-04-17 11:08:53

by Marc Zyngier

Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

On 2020-04-17 11:56, Jason Yan wrote:
> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>> Hello!
>>
>> On 17.04.2020 10:40, Jason Yan wrote:
>>
>>> Fix the following sparse warning:
>>>
>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>>
>>> Reported-by: Hulk Robot <[email protected]>
>>> Signed-off-by: Jason Yan <[email protected]>
>>> ---
>>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>> index eb9bce93cd05..fd7c537fb42a 100644
>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>>> bcm7038_l1_domain_ops = {
>>>       .map            = bcm7038_l1_map,
>>>   };
>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>>                     struct device_node *parent)
>>
>>    Reindent the above line please, it should start under *struct* on
>> the 1st line.
>
> OK, will cook a new one.

Please don't bother. I've picked the patch already, and it is on its way
to Linus.

Thanks,

M.
--
Jazz is not dead. It just smells funny...

2020-04-17 11:12:02

by Jason Yan

Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static

在 2020/4/17 19:07, Marc Zyngier 写道:
> On 2020-04-17 11:56, Jason Yan wrote:
>> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>>> Hello!
>>>
>>> On 17.04.2020 10:40, Jason Yan wrote:
>>>
>>>> Fix the following sparse warning:
>>>>
>>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>>>
>>>> Reported-by: Hulk Robot <[email protected]>
>>>> Signed-off-by: Jason Yan <[email protected]>
>>>> ---
>>>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c
>>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>>> index eb9bce93cd05..fd7c537fb42a 100644
>>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops
>>>> bcm7038_l1_domain_ops = {
>>>>       .map            = bcm7038_l1_map,
>>>>   };
>>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>>>                     struct device_node *parent)
>>>
>>>     Reindent the above line please, it should start under *struct* on
>>> the 1st line.
>>
>> OK, will cook a new one.
>
> Please don't bother. I've picked the patch already, and it is on its way
> to Linus.
>

I have send v2 before I saw this. You can just ignore it.

Thanks,

Jason

> Thanks,
>
>         M.