This is the start of the stable review cycle for the 4.9.226 release.
There are 59 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.226-rc2.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.9.226-rc2
Benjamin Block <[email protected]>
scsi: zfcp: fix request object use-after-free in send path causing wrong traces
Salil Mehta <[email protected]>
net: hns: Fixes the missing put_device in positive leg for roce reset
Guoqing Jiang <[email protected]>
sc16is7xx: move label 'err_spi' to correct section
Liviu Dudau <[email protected]>
mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap()
Roopa Prabhu <[email protected]>
net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags
Thomas Gleixner <[email protected]>
genirq/generic_pending: Do not lose pending affinity update
Pablo Neira Ayuso <[email protected]>
netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build
Qiushi Wu <[email protected]>
bonding: Fix reference count leak in bond_sysfs_slave_add.
Qiushi Wu <[email protected]>
qlcnic: fix missing release in qlcnic_83xx_interrupt_test.
Pablo Neira Ayuso <[email protected]>
netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code
Phil Sutter <[email protected]>
netfilter: ipset: Fix subcounter update skip
Michael Braun <[email protected]>
netfilter: nft_reject_bridge: enable reject with bridge vlan
Xin Long <[email protected]>
ip_vti: receive ipip packet by calling ip_tunnel_rcv
Jeremy Sowden <[email protected]>
vti4: eliminated some duplicate code.
Xin Long <[email protected]>
xfrm: fix a NULL-ptr deref in xfrm_local_error
Xin Long <[email protected]>
xfrm: fix a warning in xfrm_policy_insert_list
Xin Long <[email protected]>
xfrm: allow to accept packets with ipv6 NEXTHDR_HOP in xfrm_input
Alexander Dahl <[email protected]>
x86/dma: Fix max PFN arithmetic overflow on 32 bit systems
Linus Lüssing <[email protected]>
mac80211: mesh: fix discovery timer re-arming issue / crash
Helge Deller <[email protected]>
parisc: Fix kernel panic in mem_init()
Qiushi Wu <[email protected]>
iommu: Fix reference count leak in iommu_group_alloc.
Arnd Bergmann <[email protected]>
include/asm-generic/topology.h: guard cpumask_of_node() macro argument
Alexander Potapenko <[email protected]>
fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
Konstantin Khlebnikov <[email protected]>
mm: remove VM_BUG_ON(PageSlab()) from page_mapcount()
Jerry Lee <[email protected]>
libceph: ignore pool overlay and cache logic on redirects
Eric W. Biederman <[email protected]>
exec: Always set cap_ambient in cap_bprm_set_creds
Chris Chiu <[email protected]>
ALSA: usb-audio: mixer: volume quirk for ESS Technology Asus USB DAC
Changming Liu <[email protected]>
ALSA: hwdep: fix a left shifting 1 by 31 UB bug
Robert Beckett <[email protected]>
ARM: dts/imx6q-bx50v3: Set display interface clock parents
Sebastian Reichel <[email protected]>
ARM: dts: imx6q-bx50v3: Add internal switch
Martyn Welch <[email protected]>
ARM: dts: imx: Correct B850v3 clock assignment
Kaike Wan <[email protected]>
IB/qib: Call kobject_put() when kobject_init_and_add() fails
Russell King <[email protected]>
ARM: uaccess: fix DACR mismatch with nested exceptions
Russell King <[email protected]>
ARM: uaccess: integrate uaccess_save and uaccess_restore
Russell King <[email protected]>
ARM: uaccess: consolidate uaccess asm to asm/uaccess-asm.h
Stefan Agner <[email protected]>
ARM: 8843/1: use unified assembler in headers
Wei Yongjun <[email protected]>
Input: synaptics-rmi4 - fix error return code in rmi_driver_probe()
Kevin Locke <[email protected]>
Input: i8042 - add ThinkPad S230u to i8042 reset list
Łukasz Patron <[email protected]>
Input: xpad - add custom init packet for Xbox One S controllers
Brendan Shanks <[email protected]>
Input: evdev - call input_flush_device() on release(), not flush()
James Hilliard <[email protected]>
Input: usbtouchscreen - add support for BonXeon TP
Steve French <[email protected]>
cifs: Fix null pointer check in cifs_read
Masahiro Yamada <[email protected]>
usb: gadget: legacy: fix redundant initialization warnings
Lei Xue <[email protected]>
cachefiles: Fix race between read_waiter and read_copier involving op->to_do
Bob Peterson <[email protected]>
gfs2: move privileged user check to gfs2_quota_lock_check
Chuhong Yuan <[email protected]>
net: microchip: encx24j600: add missed kthread_stop
Stephen Warren <[email protected]>
gpio: tegra: mask GPIO IRQs during IRQ shutdown
Kalderon, Michal <[email protected]>
IB/cma: Fix reference count leak when no ipv4 addresses are set
Dmitry V. Levin <[email protected]>
uapi: fix linux/if_pppol2tp.h userspace compilation errors
Qiushi Wu <[email protected]>
net/mlx4_core: fix a memory leak bug.
Qiushi Wu <[email protected]>
net: sun: fix missing release regions in cas_init_one().
Moshe Shemesh <[email protected]>
net/mlx5: Add command entry handling completion
Manivannan Sadhasivam <[email protected]>
net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()
Moshe Shemesh <[email protected]>
net/mlx5e: Update netdev txq on completions during closure
Jere Leppänen <[email protected]>
sctp: Start shutdown on association restart if in SHUTDOWN-SENT state and socket is closed
Roman Mashak <[email protected]>
net sched: fix reporting the first-time use timestamp
Yuqi Jin <[email protected]>
net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()"
Vadim Fedorenko <[email protected]>
net: ipip: fix wrong address family in init error path
Eric Dumazet <[email protected]>
ax25: fix setsockopt(SO_BINDTODEVICE)
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/imx6q-b450v3.dts | 7 --
arch/arm/boot/dts/imx6q-b650v3.dts | 7 --
arch/arm/boot/dts/imx6q-b850v3.dts | 11 --
arch/arm/boot/dts/imx6q-bx50v3.dtsi | 77 ++++++++++++++
arch/arm/include/asm/assembler.h | 83 +--------------
arch/arm/include/asm/uaccess-asm.h | 117 +++++++++++++++++++++
arch/arm/include/asm/vfpmacros.h | 8 +-
arch/arm/kernel/entry-armv.S | 11 +-
arch/arm/kernel/entry-header.S | 9 +-
arch/arm/lib/bitops.h | 8 +-
arch/parisc/mm/init.c | 2 +-
arch/x86/include/asm/dma.h | 2 +-
drivers/gpio/gpio-tegra.c | 1 +
drivers/infiniband/hw/qib/qib_sysfs.c | 9 +-
drivers/input/evdev.c | 19 +---
drivers/input/joystick/xpad.c | 12 +++
drivers/input/rmi4/rmi_driver.c | 3 +-
drivers/input/serio/i8042-x86ia64io.h | 7 ++
drivers/input/touchscreen/usbtouchscreen.c | 1 +
drivers/iommu/iommu.c | 2 +-
drivers/net/bonding/bond_sysfs_slave.c | 4 +-
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 3 +
drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 15 +++
drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 6 +-
drivers/net/ethernet/microchip/encx24j600.c | 5 +-
.../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 4 +-
drivers/net/ethernet/sun/cassini.c | 3 +-
drivers/s390/scsi/zfcp_fsf.c | 10 +-
drivers/tty/serial/sc16is7xx.c | 2 +
drivers/usb/gadget/legacy/inode.c | 3 +-
fs/binfmt_elf.c | 2 +-
fs/cachefiles/rdwr.c | 2 +-
fs/cifs/file.c | 2 +-
fs/gfs2/quota.c | 3 +-
fs/gfs2/quota.h | 3 +-
include/asm-generic/topology.h | 2 +-
include/linux/mlx5/driver.h | 1 +
include/linux/mm.h | 15 ++-
include/linux/netfilter/nf_conntrack_pptp.h | 2 +-
include/net/act_api.h | 3 +-
include/rdma/ib_addr.h | 6 +-
include/uapi/linux/l2tp.h | 7 +-
kernel/irq/migration.c | 26 +++--
mm/vmalloc.c | 2 +-
net/ax25/af_ax25.c | 6 +-
net/bridge/netfilter/nft_reject_bridge.c | 6 ++
net/ceph/osd_client.c | 4 +-
net/core/rtnetlink.c | 2 +-
net/ipv4/ip_vti.c | 75 +++++++------
net/ipv4/ipip.c | 2 +-
net/ipv4/netfilter/nf_nat_pptp.c | 7 +-
net/ipv4/route.c | 14 ++-
net/mac80211/mesh_hwmp.c | 7 ++
net/netfilter/ipset/ip_set_list_set.c | 2 +-
net/netfilter/nf_conntrack_pptp.c | 62 ++++++-----
net/qrtr/qrtr.c | 2 +-
net/sctp/sm_statefuns.c | 9 +-
net/xfrm/xfrm_input.c | 2 +-
net/xfrm/xfrm_output.c | 3 +-
net/xfrm/xfrm_policy.c | 7 +-
security/commoncap.c | 1 +
sound/core/hwdep.c | 4 +-
sound/usb/mixer.c | 8 ++
65 files changed, 473 insertions(+), 283 deletions(-)
On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.9.226 release.
> There are 59 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000.
> Anything received after that time might be too late.
>
Many arm builds still fail as attached. Is it really only me seeing this problem ?
FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified
assembler patches be applied ?
$ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified
c001899a5d6c ARM: 8843/1: use unified assembler in headers
a216376add73 ARM: 8841/1: use unified assembler in macros
eb7ff9023e4f ARM: 8829/1: spinlock: use unified assembler language syntax
32fdb046ac43 ARM: 8828/1: uaccess: use unified assembler language syntax
1293c2b5d790 ARM: dts: berlin2q: add "cache-unified" to l2 node
75fea300d73a ARM: 8723/2: always assume the "unified" syntax for assembly code
I am quite concerned especially about missing commit 75fea300d73a,
which removes the ARM_ASM_UNIFIED configuration option. That means it is
still present in v4.9.y, but the failing builds don't enable it. Given that,
the build failures don't seem to be surprising.
Guenter
---
Build reference: v4.9.225-60-g6915714f12d0
gcc version: arm-linux-gnueabi-gcc (GCC) 9.3.0
Building arm:allmodconfig ... failed
--------------
Error log:
arch/arm/vfp/vfphw.S: Assembler messages:
arch/arm/vfp/vfphw.S:158: Error: bad instruction `ldclne p11,cr0,[r10],#32*4'
arch/arm/vfp/vfphw.S:233: Error: bad instruction `stclne p11,cr0,[r0],#32*4'
make[2]: *** [arch/arm/vfp/vfphw.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [arch/arm/vfp] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2
--------------
Building arm:s3c2410_defconfig ... failed
--------------
Error log:
arch/arm/lib/changebit.S: Assembler messages:
arch/arm/lib/changebit.S:15: Error: bad instruction `strbne r1,[ip]'
make[2]: *** [arch/arm/lib/changebit.o] Error 1
make[2]: *** Waiting for unfinished jobs....
arch/arm/lib/clear_user.S: Assembler messages:
arch/arm/lib/clear_user.S:33: Error: bad instruction `strbtal r2,[r0],#1'
arch/arm/lib/clear_user.S:34: Error: bad instruction `strbtle r2,[r0],#1'
arch/arm/lib/clear_user.S:35: Error: bad instruction `strbtlt r2,[r0],#1'
arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4'
arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4'
arch/arm/lib/clear_user.S:42: Error: bad instruction `strtpl r2,[r0],#4'
arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1'
arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1'
make[2]: *** [arch/arm/lib/clear_user.o] Error 1
make[1]: *** [arch/arm/lib] Error 2
make[1]: *** Waiting for unfinished jobs....
Failed builds:
arm:allmodconfig
arm:s3c2410_defconfig
arm:omap2plus_defconfig
arm:imx_v6_v7_defconfig
arm:ixp4xx_defconfig
arm:u8500_defconfig
arm:multi_v5_defconfig
arm:omap1_defconfig
arm:footbridge_defconfig
arm:davinci_all_defconfig
arm:mini2440_defconfig
arm:axm55xx_defconfig
arm:mxs_defconfig
arm:keystone_defconfig
arm:vexpress_defconfig
arm:imx_v4_v5_defconfig
arm:at91_dt_defconfig
arm:s3c6400_defconfig
arm:lpc32xx_defconfig
arm:shmobile_defconfig
arm:nhk8815_defconfig
arm:bcm2835_defconfig
arm:sama5_defconfig
arm:orion5x_defconfig
arm:exynos_defconfig
arm:cm_x2xx_defconfig
arm:s5pv210_defconfig
arm:integrator_defconfig
arm:pxa910_defconfig
arm:clps711x_defconfig
On 02/06/2020 16:37, Guenter Roeck wrote:
> On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 4.9.226 release.
>> There are 59 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000.
>> Anything received after that time might be too late.
>>
>
> Many arm builds still fail as attached. Is it really only me seeing this problem ?
No I am seeing this as well. Been having some email problems today ...
> FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified
> assembler patches be applied ?
>
> $ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified
> c001899a5d6c ARM: 8843/1: use unified assembler in headers
Bisect points to this one for me.
Cheers
Jon
--
nvpublic
+ Russell King
On Tue, 2 Jun 2020 at 21:07, Guenter Roeck <[email protected]> wrote:
>
> On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.9.226 release.
> > There are 59 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000.
> > Anything received after that time might be too late.
> >
>
> Many arm builds still fail as attached. Is it really only me seeing this problem ?
>
We have noticed this problem.
> FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified
> assembler patches be applied ?
This is reported on stable mailing list
https://lore.kernel.org/stable/[email protected]/T/#t
>
> $ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified
> c001899a5d6c ARM: 8843/1: use unified assembler in headers
> a216376add73 ARM: 8841/1: use unified assembler in macros
> eb7ff9023e4f ARM: 8829/1: spinlock: use unified assembler language syntax
> 32fdb046ac43 ARM: 8828/1: uaccess: use unified assembler language syntax
> 1293c2b5d790 ARM: dts: berlin2q: add "cache-unified" to l2 node
> 75fea300d73a ARM: 8723/2: always assume the "unified" syntax for assembly code
>
> I am quite concerned especially about missing commit 75fea300d73a,
> which removes the ARM_ASM_UNIFIED configuration option. That means it is
> still present in v4.9.y, but the failing builds don't enable it. Given that,
> the build failures don't seem to be surprising.
>
> Guenter
>
> ---
> Build reference: v4.9.225-60-g6915714f12d0
> gcc version: arm-linux-gnueabi-gcc (GCC) 9.3.0
>
> Building arm:allmodconfig ... failed
> --------------
> Error log:
> arch/arm/vfp/vfphw.S: Assembler messages:
> arch/arm/vfp/vfphw.S:158: Error: bad instruction `ldclne p11,cr0,[r10],#32*4'
> arch/arm/vfp/vfphw.S:233: Error: bad instruction `stclne p11,cr0,[r0],#32*4'
> make[2]: *** [arch/arm/vfp/vfphw.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [arch/arm/vfp] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> --------------
>
> Building arm:s3c2410_defconfig ... failed
> --------------
> Error log:
> arch/arm/lib/changebit.S: Assembler messages:
> arch/arm/lib/changebit.S:15: Error: bad instruction `strbne r1,[ip]'
> make[2]: *** [arch/arm/lib/changebit.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> arch/arm/lib/clear_user.S: Assembler messages:
> arch/arm/lib/clear_user.S:33: Error: bad instruction `strbtal r2,[r0],#1'
> arch/arm/lib/clear_user.S:34: Error: bad instruction `strbtle r2,[r0],#1'
> arch/arm/lib/clear_user.S:35: Error: bad instruction `strbtlt r2,[r0],#1'
> arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4'
> arch/arm/lib/clear_user.S:39: Error: bad instruction `strtpl r2,[r0],#4'
> arch/arm/lib/clear_user.S:42: Error: bad instruction `strtpl r2,[r0],#4'
> arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1'
> arch/arm/lib/clear_user.S:44: Error: bad instruction `strbtne r2,[r0],#1'
> make[2]: *** [arch/arm/lib/clear_user.o] Error 1
> make[1]: *** [arch/arm/lib] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> Failed builds:
> arm:allmodconfig
> arm:s3c2410_defconfig
> arm:omap2plus_defconfig
> arm:imx_v6_v7_defconfig
> arm:ixp4xx_defconfig
> arm:u8500_defconfig
> arm:multi_v5_defconfig
> arm:omap1_defconfig
> arm:footbridge_defconfig
> arm:davinci_all_defconfig
> arm:mini2440_defconfig
> arm:axm55xx_defconfig
> arm:mxs_defconfig
> arm:keystone_defconfig
> arm:vexpress_defconfig
> arm:imx_v4_v5_defconfig
> arm:at91_dt_defconfig
> arm:s3c6400_defconfig
> arm:lpc32xx_defconfig
> arm:shmobile_defconfig
> arm:nhk8815_defconfig
> arm:bcm2835_defconfig
> arm:sama5_defconfig
> arm:orion5x_defconfig
> arm:exynos_defconfig
> arm:cm_x2xx_defconfig
> arm:s5pv210_defconfig
> arm:integrator_defconfig
> arm:pxa910_defconfig
> arm:clps711x_defconfig
On Tue, Jun 02, 2020 at 08:37:26AM -0700, Guenter Roeck wrote:
>On 6/2/20 3:23 AM, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 4.9.226 release.
>> There are 59 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 04 Jun 2020 10:16:52 +0000.
>> Anything received after that time might be too late.
>>
>
>Many arm builds still fail as attached. Is it really only me seeing this problem ?
>
>FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified
>assembler patches be applied ?
We don't - I took 71f8af111010 as a dependency rather than on its own
merit.
>$ git log --oneline v4.9..c001899a5d6 arch/arm | grep unified
>c001899a5d6c ARM: 8843/1: use unified assembler in headers
>a216376add73 ARM: 8841/1: use unified assembler in macros
>eb7ff9023e4f ARM: 8829/1: spinlock: use unified assembler language syntax
>32fdb046ac43 ARM: 8828/1: uaccess: use unified assembler language syntax
>1293c2b5d790 ARM: dts: berlin2q: add "cache-unified" to l2 node
>75fea300d73a ARM: 8723/2: always assume the "unified" syntax for assembly code
>
>I am quite concerned especially about missing commit 75fea300d73a,
>which removes the ARM_ASM_UNIFIED configuration option. That means it is
>still present in v4.9.y, but the failing builds don't enable it. Given that,
>the build failures don't seem to be surprising.
I'm just going to drop this series from 4.9 for now, until we can figure
out how to do it right.
--
Thanks,
Sasha
Hi!
> >FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified
> >assembler patches be applied ?
>
> We don't - I took 71f8af111010 as a dependency rather than on its own
> merit.
Would it be possible to somehow mark patches that are "dependency"
rather than "on their own"? It would make review easier...
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Tue, Jun 30, 2020 at 11:46:34PM +0200, Pavel Machek wrote:
> Hi!
>
> > >FWIW, if we need/want to use unified assembler in v4.9.y, shouldn't all unified
> > >assembler patches be applied ?
> >
> > We don't - I took 71f8af111010 as a dependency rather than on its own
> > merit.
>
> Would it be possible to somehow mark patches that are "dependency"
> rather than "on their own"? It would make review easier...
That's a lot of extra work on our part, and would make the changelog
text change, which isn't always liked, sorry.
greg k-h