2022-02-17 10:46:32

by Miaohe Lin

Subject: [PATCH] mm/slob: make kmem_cache_boot static

kmem_cache_boot is never accessed outside slob.c. Make it static.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/slob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slob.c b/mm/slob.c
index 60c5842215f1..1179bcad2df8 100644
--- a/mm/slob.c
+++ b/mm/slob.c
@@ -708,7 +708,7 @@ int __kmem_cache_shrink(struct kmem_cache *d)
return 0;
}

-struct kmem_cache kmem_cache_boot = {
+static struct kmem_cache kmem_cache_boot = {
.name = "kmem_cache",
.size = sizeof(struct kmem_cache),
.flags = SLAB_PANIC,
--
2.23.0

2022-02-17 19:22:15

by David Rientjes

Subject: Re: [PATCH] mm/slob: make kmem_cache_boot static

On Thu, 17 Feb 2022, Miaohe Lin wrote:

> kmem_cache_boot is never accessed outside slob.c. Make it static.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Acked-by: David Rientjes <[email protected]>

2022-02-17 23:53:37

by Vlastimil Babka

Subject: Re: [PATCH] mm/slob: make kmem_cache_boot static

On 2/17/22 09:58, Miaohe Lin wrote:
> kmem_cache_boot is never accessed outside slob.c. Make it static.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Thanks, adding to slab tree.

> ---
> mm/slob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slob.c b/mm/slob.c
> index 60c5842215f1..1179bcad2df8 100644
> --- a/mm/slob.c
> +++ b/mm/slob.c
> @@ -708,7 +708,7 @@ int __kmem_cache_shrink(struct kmem_cache *d)
> return 0;
> }
>
> -struct kmem_cache kmem_cache_boot = {
> +static struct kmem_cache kmem_cache_boot = {
> .name = "kmem_cache",
> .size = sizeof(struct kmem_cache),
> .flags = SLAB_PANIC,