2023-07-07 10:13:21

by 李扬韬

Subject: [PATCH v2 05/11] ata: sata_rcar: drop useless initializer

There is no need to initialize the variable ret, let's drop it.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/ata/sata_rcar.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 34790f15c1b8..f299b41ab3e6 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -862,8 +862,7 @@ static int sata_rcar_probe(struct platform_device *pdev)
struct ata_host *host;
struct sata_rcar_priv *priv;
struct resource *mem;
- int irq;
- int ret = 0;
+ int irq, ret;

irq = platform_get_irq(pdev, 0);
if (irq < 0)
--
2.39.0

2023-07-07 19:11:13

by Sergey Shtylyov

Subject: Re: [PATCH v2 05/11] ata: sata_rcar: drop useless initializer

On 7/7/23 12:55 PM, Yangtao Li wrote:

> There is no need to initialize the variable ret, let's drop it.

Drop what, the variable? :-)

> Signed-off-by: Yangtao Li <[email protected]>

Aside from that:

Reviewed-by: Sergey Shtylyov <[email protected]>

[...]

MBR, Sergey