2023-05-26 12:03:18

by Dan Carpenter

Subject: [PATCH] smb: delete an unnecessary statement

We don't need to set the list iterators to NULL before a
list_for_each_entry() loop because they are assigned inside the
macro.

Signed-off-by: Dan Carpenter <[email protected]>
---
fs/smb/client/smb2ops.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 5065398665f1..6e3be58cfe49 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
* Add a new one instead
*/
spin_lock(&ses->iface_lock);
- iface = niface = NULL;
list_for_each_entry_safe(iface, niface, &ses->iface_list,
iface_head) {
ret = iface_cmp(iface, &tmp_iface);
--
2.39.2

2023-05-26 16:10:22

by Mukesh Ojha

Subject: Re: [PATCH] smb: delete an unnecessary statement

On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
>
> Signed-off-by: Dan Carpenter <[email protected]>


Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh

> ---
> fs/smb/client/smb2ops.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
> * Add a new one instead
> */
> spin_lock(&ses->iface_lock);
> - iface = niface = NULL;
> list_for_each_entry_safe(iface, niface, &ses->iface_list,
> iface_head) {
> ret = iface_cmp(iface, &tmp_iface);