2017-06-30 09:33:39

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] eCryptfs: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
6122 636 24 6782 1a7e fs/ecryptfs/main.o

File size After adding 'const':
text data bss dec hex filename
6186 604 24 6814 1a9e fs/ecryptfs/main.o

Signed-off-by: Arvind Yadav <[email protected]>
---
fs/ecryptfs/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index 9014479..eea4c0f 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj,
NULL,
};

-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
.attrs = attributes,
};

--
1.9.1