2019-01-03 09:17:40

by liujian (CE)

Subject: [PATCH v3] driver: uio: fix possible memory leak in uio_open

Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
Signed-off-by: liujian <[email protected]>
---
v1->v2:
rename the "err_infoopen" to "err_idev_info"
v2->3:
put the extra info after the "--"

drivers/uio/uio.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 5c10fc7..aab3520 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -496,18 +496,19 @@ static int uio_open(struct inode *inode, struct file *filep)
if (!idev->info) {
mutex_unlock(&idev->info_lock);
ret = -EINVAL;
- goto err_alloc_listener;
+ goto err_idev_info;
}

if (idev->info && idev->info->open)
ret = idev->info->open(idev->info, inode);
mutex_unlock(&idev->info_lock);
if (ret)
- goto err_infoopen;
+ goto err_idev_info;

return 0;

-err_infoopen:
+err_idev_info:
+ filep->private_data = NULL;
kfree(listener);

err_alloc_listener:
--
2.7.4

2019-01-03 09:20:44

by Xiubo Li

Subject: Re: [PATCH v3] driver: uio: fix possible memory leak in uio_open

On 2019/1/3 22:28, liujian wrote:
> Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
> Signed-off-by: liujian <[email protected]>
> ---
> v1->v2:
> rename the "err_infoopen" to "err_idev_info"
> v2->3:
> put the extra info after the "--"

Looks good to me.

Thanks.
BRs


> drivers/uio/uio.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index 5c10fc7..aab3520 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -496,18 +496,19 @@ static int uio_open(struct inode *inode, struct file *filep)
> if (!idev->info) {
> mutex_unlock(&idev->info_lock);
> ret = -EINVAL;
> - goto err_alloc_listener;
> + goto err_idev_info;
> }
>
> if (idev->info && idev->info->open)
> ret = idev->info->open(idev->info, inode);
> mutex_unlock(&idev->info_lock);
> if (ret)
> - goto err_infoopen;
> + goto err_idev_info;
>
> return 0;
>
> -err_infoopen:
> +err_idev_info:
> + filep->private_data = NULL;
> kfree(listener);
>
> err_alloc_listener:

2019-01-07 17:40:33

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] driver: uio: fix possible memory leak in uio_open

On Thu, Jan 03, 2019 at 10:28:22PM +0800, liujian wrote:
> Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
> Signed-off-by: liujian <[email protected]>


I can not take patches without any changelog text at all :(

Also, is "liujian" your full name? We need a real and full name for a
signed-off-by line.

thanks,

greg k-h

2019-01-08 03:32:24

by liujian (CE)

Subject: RE: [PATCH v3] driver: uio: fix possible memory leak in uio_open

> -----Original Message-----
> From: Greg KH [mailto:[email protected]]
> Sent: Tuesday, January 08, 2019 12:14 AM
> To: liujian (CE) <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [PATCH v3] driver: uio: fix possible memory leak in uio_open
>
> On Thu, Jan 03, 2019 at 10:28:22PM +0800, liujian wrote:
> > Fixes: 57c5f4df0a5a ("uio: fix crash after the device is
> > unregistered")
> > Signed-off-by: liujian <[email protected]>
>
>
> I can not take patches without any changelog text at all :(
I am sorry, I will resend the patch~
>
> Also, is "liujian" your full name? We need a real and full name for a
> signed-off-by line.

Yes, but as someone do, I may need change 'liujian' to 'Liu Jian'
Thanks

> thanks,
>
> greg k-h