2022-08-02 01:44:22

by Li zeming

Subject: [PATCH] staging/rtl8723bs/core: remove inactive initialization

The allocation address of the psta pointer variable is first performed
in the function, no initialization assignment is required, and no
invalid pointer will appear.

Signed-off-by: Li zeming <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index f2242cf2dfb4..6498fd17e1d3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2521,7 +2521,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr
{
u8 issued;
int priority;
- struct sta_info *psta = NULL;
+ struct sta_info *psta;
struct ht_priv *phtpriv;
struct pkt_attrib *pattrib = &pxmitframe->attrib;
s32 bmcst = IS_MCAST(pattrib->ra);
--
2.18.2

2022-08-02 09:12:45

by Hans de Goede

Subject: Re: [PATCH] staging/rtl8723bs/core: remove inactive initialization

Hi,

On 8/2/22 03:25, Li zeming wrote:
> The allocation address of the psta pointer variable is first performed
> in the function, no initialization assignment is required, and no
> invalid pointer will appear.
>
> Signed-off-by: Li zeming <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans

> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index f2242cf2dfb4..6498fd17e1d3 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2521,7 +2521,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr
> {
> u8 issued;
> int priority;
> - struct sta_info *psta = NULL;
> + struct sta_info *psta;
> struct ht_priv *phtpriv;
> struct pkt_attrib *pattrib = &pxmitframe->attrib;
> s32 bmcst = IS_MCAST(pattrib->ra);