2016-12-03 01:13:14

by Shaohua Li

Subject: [PATCH] blk-stat: fix a typo

Signed-off-by: Shaohua Li <[email protected]>
---
block/blk-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-stat.c b/block/blk-stat.c
index 688c958..4d01185 100644
--- a/block/blk-stat.c
+++ b/block/blk-stat.c
@@ -12,7 +12,7 @@
static void blk_stat_flush_batch(struct blk_rq_stat *stat)
{
const s32 nr_batch = READ_ONCE(stat->nr_batch);
- const s32 nr_samples = READ_ONCE(stat->nr_batch);
+ const s32 nr_samples = READ_ONCE(stat->nr_samples);

if (!nr_batch)
return;
--
2.9.3

2016-12-03 03:17:56

by Jens Axboe

Subject: Re: [PATCH] blk-stat: fix a typo

On 12/02/2016 06:13 PM, Shaohua Li wrote:
> Signed-off-by: Shaohua Li <[email protected]>
> ---
> block/blk-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-stat.c b/block/blk-stat.c
> index 688c958..4d01185 100644
> --- a/block/blk-stat.c
> +++ b/block/blk-stat.c
> @@ -12,7 +12,7 @@
> static void blk_stat_flush_batch(struct blk_rq_stat *stat)
> {
> const s32 nr_batch = READ_ONCE(stat->nr_batch);
> - const s32 nr_samples = READ_ONCE(stat->nr_batch);
> + const s32 nr_samples = READ_ONCE(stat->nr_samples);
>
> if (!nr_batch)
> return;
>

Gah, that sucks. Thanks, added for 4.10.

--
Jens Axboe

2016-12-03 04:36:08

by Jens Axboe

Subject: Re: [PATCH] blk-stat: fix a typo

On 12/02/2016 08:16 PM, Jens Axboe wrote:
> On 12/02/2016 06:13 PM, Shaohua Li wrote:
>> Signed-off-by: Shaohua Li <[email protected]>
>> ---
>> block/blk-stat.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-stat.c b/block/blk-stat.c
>> index 688c958..4d01185 100644
>> --- a/block/blk-stat.c
>> +++ b/block/blk-stat.c
>> @@ -12,7 +12,7 @@
>> static void blk_stat_flush_batch(struct blk_rq_stat *stat)
>> {
>> const s32 nr_batch = READ_ONCE(stat->nr_batch);
>> - const s32 nr_samples = READ_ONCE(stat->nr_batch);
>> + const s32 nr_samples = READ_ONCE(stat->nr_samples);
>>
>> if (!nr_batch)
>> return;
>>
>
> Gah, that sucks. Thanks, added for 4.10.

BTW, this was added right before inclusion, all the previously posted
versions were not broken in this way. So thanks for spotting this!

--
Jens Axboe