Remove the duplicate include of linux/io.h in barco-p50-gpio.c
file.
Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/platform/x86/barco-p50-gpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
index f5c72e33f9ae..bb8ed8e95225 100644
--- a/drivers/platform/x86/barco-p50-gpio.c
+++ b/drivers/platform/x86/barco-p50-gpio.c
@@ -14,7 +14,6 @@
#include <linux/delay.h>
#include <linux/dmi.h>
#include <linux/err.h>
-#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/module.h>
--
2.33.0
>>>>> "Saurav" == Saurav Girepunje <[email protected]> writes:
> Remove the duplicate include of linux/io.h in barco-p50-gpio.c
> file.
> Signed-off-by: Saurav Girepunje <[email protected]>
What tree is this against? The io.h include in the line just above
delay.h was already removed by:
commit 011881b80ebe773914b59905bce0f5e0ef93e7ba
Author: Jiasheng Jiang <[email protected]>
Date: Thu May 26 17:03:45 2022 +0800
platform/x86: barco-p50-gpio: Add check for platform_driver_register
As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.
Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
Signed-off-by: Jiasheng Jiang <[email protected]>
Acked-by: Peter Korsgaard <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Hans de Goede <[email protected]>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/leds.h>
> #include <linux/module.h>
> --
> 2.33.0
--
Bye, Peter Korsgaard
On 27/06/22 12:41 am, Peter Korsgaard wrote:
>>>>>> "Saurav" == Saurav Girepunje <[email protected]> writes:
>
> > Remove the duplicate include of linux/io.h in barco-p50-gpio.c
> > file.
>
> > Signed-off-by: Saurav Girepunje <[email protected]>
>
> What tree is this against? The io.h include in the line just above
> delay.h was already removed by:
>
I am using git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git .
if it fix on another tree . Please ignore this patch.
> commit 011881b80ebe773914b59905bce0f5e0ef93e7ba
> Author: Jiasheng Jiang <[email protected]>
> Date: Thu May 26 17:03:45 2022 +0800
>
> platform/x86: barco-p50-gpio: Add check for platform_driver_register
>
> As platform_driver_register() could fail, it should be better
> to deal with the return value in order to maintain the code
> consisitency.
>
> Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
> Signed-off-by: Jiasheng Jiang <[email protected]>
> Acked-by: Peter Korsgaard <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]
> Signed-off-by: Hans de Goede <[email protected]>
>
>> ---
> > drivers/platform/x86/barco-p50-gpio.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> > index f5c72e33f9ae..bb8ed8e95225 100644
> > --- a/drivers/platform/x86/barco-p50-gpio.c
> > +++ b/drivers/platform/x86/barco-p50-gpio.c
> > @@ -14,7 +14,6 @@
> > #include <linux/delay.h>
> > #include <linux/dmi.h>
> > #include <linux/err.h>
> > -#include <linux/io.h>
> > #include <linux/kernel.h>
> > #include <linux/leds.h>
> > #include <linux/module.h>
> > --
> > 2.33.0
>
>
>>>>> "Saurav" == Saurav Girepunje <[email protected]> writes:
> On 27/06/22 12:41 am, Peter Korsgaard wrote:
>>>>>>> "Saurav" == Saurav Girepunje <[email protected]> writes:
>>
>> > Remove the duplicate include of linux/io.h in barco-p50-gpio.c
>> > file.
>>
>> > Signed-off-by: Saurav Girepunje <[email protected]>
>>
>> What tree is this against? The io.h include in the line just above
>> delay.h was already removed by:
>>
> I am using git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git .
staging? That seems an odd tree to make platform/x86 changes
from. Just using the mainline tree would be a better choice.
> if it fix on another tree . Please ignore this patch.
git describe --contains 011881b80ebe773914b59905bce0f5e0ef93e7ba
v5.19-rc2~1^2~5
So it is in 5.19-rc2, released 2 weeks ago.
--
Bye, Peter Korsgaard
On 27/06/22 12:32 pm, Peter Korsgaard wrote:
>>>>>> "Saurav" == Saurav Girepunje <[email protected]> writes:
>
> > On 27/06/22 12:41 am, Peter Korsgaard wrote:
> >>>>>>> "Saurav" == Saurav Girepunje <[email protected]> writes:
> >>
> >> > Remove the duplicate include of linux/io.h in barco-p50-gpio.c
> >> > file.
> >>
> >> > Signed-off-by: Saurav Girepunje <[email protected]>
> >>
> >> What tree is this against? The io.h include in the line just above
> >> delay.h was already removed by:
> >>
>
> > I am using git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git .
>
> staging? That seems an odd tree to make platform/x86 changes
> from. Just using the mainline tree would be a better choice.
Ok, Sure
>
> > if it fix on another tree . Please ignore this patch.
>
> git describe --contains 011881b80ebe773914b59905bce0f5e0ef93e7ba
> v5.19-rc2~1^2~5
>
> So it is in 5.19-rc2, released 2 weeks ago.
>
Yes