2017-08-19 19:26:44

by Arvind Yadav

Subject: [PATCH] hwmon: ftsteutates: constify i2c_device_id

i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/hwmon/ftsteutates.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/ftsteutates.c b/drivers/hwmon/ftsteutates.c
index 0f0277e..317e45f 100644
--- a/drivers/hwmon/ftsteutates.c
+++ b/drivers/hwmon/ftsteutates.c
@@ -60,7 +60,7 @@

static const unsigned short normal_i2c[] = { 0x73, I2C_CLIENT_END };

-static struct i2c_device_id fts_id[] = {
+static const struct i2c_device_id fts_id[] = {
{ "ftsteutates", 0 },
{ }
};
--
2.7.4

2017-08-30 00:46:04

by Guenter Roeck

Subject: Re: hwmon: ftsteutates: constify i2c_device_id

On Sun, Aug 20, 2017 at 12:56:34AM +0530, Arvind Yadav wrote:
> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by <linux/i2c.h> work with
> const i2c_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Appled to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/ftsteutates.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ftsteutates.c b/drivers/hwmon/ftsteutates.c
> index 0f0277e..317e45f 100644
> --- a/drivers/hwmon/ftsteutates.c
> +++ b/drivers/hwmon/ftsteutates.c
> @@ -60,7 +60,7 @@
>
> static const unsigned short normal_i2c[] = { 0x73, I2C_CLIENT_END };
>
> -static struct i2c_device_id fts_id[] = {
> +static const struct i2c_device_id fts_id[] = {
> { "ftsteutates", 0 },
> { }
> };