2023-07-19 22:31:06

by Min-Hua Chen

Subject: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static

This patch fixes the following sprse warning:

drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 'apple_dart_pm_ops' was not declared. Should it be static?

No functional change intended.

Signed-off-by: Min-Hua Chen <[email protected]>
---
drivers/iommu/apple-dart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 8af64b57f048..2082081402d3 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -1276,7 +1276,7 @@ static __maybe_unused int apple_dart_resume(struct device *dev)
return 0;
}

-DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);

static const struct of_device_id apple_dart_of_match[] = {
{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
--
2.34.1

2023-07-20 19:48:53

by Sven Peter

Subject: Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static

On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
> This patch fixes the following sprse warning:

typo: sparse

>
> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol
> 'apple_dart_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <[email protected]>
> ---

Acked-by: Sven Peter <[email protected]>

Thanks,


Sven

> drivers/iommu/apple-dart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 8af64b57f048..2082081402d3 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -1276,7 +1276,7 @@ static __maybe_unused int
> apple_dart_resume(struct device *dev)
> return 0;
> }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend,
> apple_dart_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend,
> apple_dart_resume);
>
> static const struct of_device_id apple_dart_of_match[] = {
> { .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
> --
> 2.34.1

2023-07-20 23:44:39

by Min-Hua Chen

Subject: Re: [PATCH] iommu/apple-dart: mark apple_dart_pm_ops static

Hi Sven,

>On Thu, Jul 20, 2023, at 00:20, Min-Hua Chen wrote:
>> This patch fixes the following sprse warning:
>
>typo: sparse

thanks for catching this.

>>
>> drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol
>> 'apple_dart_pm_ops' was not declared. Should it be static?
>>
>> No functional change intended.
>>
>> Signed-off-by: Min-Hua Chen <[email protected]>
>> ---
>
>Acked-by: Sven Peter <[email protected]>

I'll submit v2 with your Acked-by tag.

thanks,
Min-Hua

>Thanks,
>
>
>Sven