2022-09-15 06:45:17

by Horatiu Vultur

Subject: [PATCH] ARM: dts: lan966x: Add interrupt support for PHYs on pcb8290

Add interrupt support for the PHYs found on pcb8290. They are all
sharing the same interrupt line towards lan966x.

Signed-off-by: Horatiu Vultur <[email protected]>
---
arch/arm/boot/dts/lan966x-pcb8290.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
index af92bb12bc6cd..2ed53da914acb 100644
--- a/arch/arm/boot/dts/lan966x-pcb8290.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
@@ -68,41 +68,57 @@ &mdio0 {

ext_phy0: ethernet-phy@7 {
reg = <7>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy1: ethernet-phy@8 {
reg = <8>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy2: ethernet-phy@9 {
reg = <9>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy3: ethernet-phy@10 {
reg = <10>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy4: ethernet-phy@15 {
reg = <15>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy5: ethernet-phy@16 {
reg = <16>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy6: ethernet-phy@17 {
reg = <17>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};

ext_phy7: ethernet-phy@18 {
reg = <18>;
+ interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&gpio>;
coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
};
};
--
2.33.0

2022-09-30 12:06:31

by Nicolas Ferre

Subject: Re: [PATCH] ARM: dts: lan966x: Add interrupt support for PHYs on pcb8290

On 15/09/2022 at 08:41, Horatiu Vultur wrote:
> Add interrupt support for the PHYs found on pcb8290. They are all
> sharing the same interrupt line towards lan966x.
>
> Signed-off-by: Horatiu Vultur <[email protected]>

Looks good to me:
Acked-by: Nicolas Ferre <[email protected]>

> ---
> arch/arm/boot/dts/lan966x-pcb8290.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8290.dts b/arch/arm/boot/dts/lan966x-pcb8290.dts
> index af92bb12bc6cd..2ed53da914acb 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8290.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8290.dts
> @@ -68,41 +68,57 @@ &mdio0 {
>
> ext_phy0: ethernet-phy@7 {
> reg = <7>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy1: ethernet-phy@8 {
> reg = <8>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy2: ethernet-phy@9 {
> reg = <9>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy3: ethernet-phy@10 {
> reg = <10>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy4: ethernet-phy@15 {
> reg = <15>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy5: ethernet-phy@16 {
> reg = <16>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy6: ethernet-phy@17 {
> reg = <17>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
>
> ext_phy7: ethernet-phy@18 {
> reg = <18>;
> + interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&gpio>;
> coma-mode-gpios = <&gpio 60 GPIO_OPEN_DRAIN>;
> };
> };


--
Nicolas Ferre

2022-10-26 07:45:16

by Claudiu Beznea

Subject: Re: [PATCH] ARM: dts: lan966x: Add interrupt support for PHYs on pcb8290

On 15.09.2022 09:41, Horatiu Vultur wrote:
> Add interrupt support for the PHYs found on pcb8290. They are all
> sharing the same interrupt line towards lan966x.
>
> Signed-off-by: Horatiu Vultur <[email protected]>

Applied to at91-dt, thanks!