2023-02-16 00:54:12

by Jesper Juhl

Subject: [Patch] [tegra] Remove unneeded version.h includes pointed out by 'make versioncheck'

From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
From: Jesper Juhl <[email protected]>
Date: Mon, 13 Feb 2023 02:49:50 +0100
Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes pointed out
by 'make versioncheck'

Signed-off-by: Jesper Juhl <[email protected]>
---
drivers/soc/tegra/cbb/tegra-cbb.c | 1 -
drivers/soc/tegra/cbb/tegra194-cbb.c | 1 -
drivers/soc/tegra/cbb/tegra234-cbb.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/drivers/soc/tegra/cbb/tegra-cbb.c b/drivers/soc/tegra/cbb/tegra-cbb.c
index a8566b9dd8de..bd96204a68ee 100644
--- a/drivers/soc/tegra/cbb/tegra-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra-cbb.c
@@ -16,7 +16,6 @@
#include <linux/of_address.h>
#include <linux/interrupt.h>
#include <linux/ioport.h>
-#include <linux/version.h>
#include <soc/tegra/fuse.h>
#include <soc/tegra/tegra-cbb.h>

diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c
index d4112b683f00..a05fc2caff3b 100644
--- a/drivers/soc/tegra/cbb/tegra194-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra194-cbb.c
@@ -23,7 +23,6 @@
#include <linux/of_address.h>
#include <linux/interrupt.h>
#include <linux/ioport.h>
-#include <linux/version.h>
#include <soc/tegra/fuse.h>
#include <soc/tegra/tegra-cbb.h>

diff --git a/drivers/soc/tegra/cbb/tegra234-cbb.c b/drivers/soc/tegra/cbb/tegra234-cbb.c
index f33d094e5ea6..e23e8acfd7c7 100644
--- a/drivers/soc/tegra/cbb/tegra234-cbb.c
+++ b/drivers/soc/tegra/cbb/tegra234-cbb.c
@@ -24,7 +24,6 @@
#include <linux/of_address.h>
#include <linux/interrupt.h>
#include <linux/ioport.h>
-#include <linux/version.h>
#include <soc/tegra/fuse.h>
#include <soc/tegra/tegra-cbb.h>

--
2.39.2

2023-02-17 09:30:57

by Jon Hunter

Subject: Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by 'make versioncheck'

On 16/02/2023 00:53, Jesper Juhl wrote:
> From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <[email protected]>
> Date: Mon, 13 Feb 2023 02:49:50 +0100
> Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes
> pointed out
>  by 'make versioncheck'
>
> Signed-off-by: Jesper Juhl <[email protected]>


The patch looks correct, but there is no commit message and I am not
sure why the header is in the body of the message. Make sure you use git
send-email to send patches.

Jon

--
nvpublic

2023-02-17 09:39:43

by Jon Hunter

Subject: Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by 'make versioncheck'

On 17/02/2023 09:30, Jon Hunter wrote:
>
> On 16/02/2023 00:53, Jesper Juhl wrote:
>>  From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
>> From: Jesper Juhl <[email protected]>
>> Date: Mon, 13 Feb 2023 02:49:50 +0100
>> Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes
>> pointed out
>>   by 'make versioncheck'
>>
>> Signed-off-by: Jesper Juhl <[email protected]>
>
>
> The patch looks correct, but there is no commit message and I am not
> sure why the header is in the body of the message. Make sure you use git
> send-email to send patches.

Also the patch $subject prefix should match subsystem you are patching.
You can check this by looking at the git history ...

$ git log --oneline drivers/soc/tegra/cbb/
b6c6bbfc65f5 soc/tegra: cbb: Remove redundant dev_err call
fa9b5246e260 soc/tegra: cbb: Use DEFINE_SHOW_ATTRIBUTE to simplify tegra_cbb_err
2927cf85f487 soc/tegra: cbb: Check firewall before enabling error reporting
55084947d6b4 soc/tegra: cbb: Add checks for potential out of bound errors

So you want some like "soc/tegra: cbb: Remove unneeded version.h header"

Jon

--
nvpublic