2023-02-10 14:15:43

by Yongqin Liu

Subject: [PATCH 1/1] thermal/drivers/hisi: Drop second sensor hi3660

The commit 74c8e6bffbe1 ("driver core: Add __alloc_size hint to devm
allocators") exposes a panic "BRK handler: Fatal exception" on the
hi3660_thermal_probe funciton.
This is because the function allocates memory for only one
sensors array entry, but tries to fill up a second one.

Fix this by removing the unneeded second access.

Fixes: 7d3a2a2bbadb ("thermal/drivers/hisi: Fix number of sensors on hi3660")
Signed-off-by: Yongqin Liu <[email protected]>
Link: https://lore.kernel.org/linux-mm/[email protected]/
---
drivers/thermal/hisi_thermal.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index d6974db7aaf7..15af90f5c7d9 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -427,10 +427,6 @@ static int hi3660_thermal_probe(struct hisi_thermal_data *data)
data->sensor[0].irq_name = "tsensor_a73";
data->sensor[0].data = data;

- data->sensor[1].id = HI3660_LITTLE_SENSOR;
- data->sensor[1].irq_name = "tsensor_a53";
- data->sensor[1].data = data;
-
return 0;
}

--
2.25.1

2023-02-10 14:28:57

by Daniel Lezcano

Subject: Re: [PATCH 1/1] thermal/drivers/hisi: Drop second sensor hi3660

On 10/02/2023 15:15, Yongqin Liu wrote:
> The commit 74c8e6bffbe1 ("driver core: Add __alloc_size hint to devm
> allocators") exposes a panic "BRK handler: Fatal exception" on the
> hi3660_thermal_probe funciton.
> This is because the function allocates memory for only one
> sensors array entry, but tries to fill up a second one.
>
> Fix this by removing the unneeded second access.
>
> Fixes: 7d3a2a2bbadb ("thermal/drivers/hisi: Fix number of sensors on hi3660")
> Signed-off-by: Yongqin Liu <[email protected]>
> Link: https://lore.kernel.org/linux-mm/[email protected]/
> ---

Applied, thanks


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog