LinuxLists.cc - [PATCH v6 00/57] Add error message to platform_get

2019-07-30 18:23:57

Subject: [PATCH v6 00/57] Add error message to platform_get_irq*()

This is a resend of patch 2/3 from the v5[1] series, but split
up to be per-subsystem. Please apply patches directly to
subsystem trees if possible.

[1] https://lkml.kernel.org/r/[email protected]

Cc: Greg Kroah-Hartman <[email protected]>

Stephen Boyd (57):
ata: Remove dev_err() usage after platform_get_irq()
bus: sunxi-rsb: Remove dev_err() usage after platform_get_irq()
hwrng: Remove dev_err() usage after platform_get_irq()
clocksource: Remove dev_err() usage after platform_get_irq()
crypto: Remove dev_err() usage after platform_get_irq()
cpufreq: Remove dev_err() usage after platform_get_irq()
ARM: Remove dev_err() usage after platform_get_irq()
MIPS: Remove dev_err() usage after platform_get_irq()
devfreq: Remove dev_err() usage after platform_get_irq()
dmaengine: Remove dev_err() usage after platform_get_irq()
edac: Remove dev_err() usage after platform_get_irq()
extcon: Remove dev_err() usage after platform_get_irq()
firmware: Remove dev_err() usage after platform_get_irq()
fpga: Remove dev_err() usage after platform_get_irq()
gpio: Remove dev_err() usage after platform_get_irq()
HSI: Remove dev_err() usage after platform_get_irq()
hwmon: Remove dev_err() usage after platform_get_irq()
i2c: Remove dev_err() usage after platform_get_irq()
iio: Remove dev_err() usage after platform_get_irq()
infiniband: Remove dev_err() usage after platform_get_irq()
Input: Remove dev_err() usage after platform_get_irq()
iommu: Remove dev_err() usage after platform_get_irq()
irqchip: Remove dev_err() usage after platform_get_irq()
mailbox: Remove dev_err() usage after platform_get_irq()
media: Remove dev_err() usage after platform_get_irq()
memory: Remove dev_err() usage after platform_get_irq()
mfd: Remove dev_err() usage after platform_get_irq()
pcie-gadget-spear: Remove dev_err() usage after platform_get_irq()
mmc: Remove dev_err() usage after platform_get_irq()
mtd: Remove dev_err() usage after platform_get_irq()
pci: Remove dev_err() usage after platform_get_irq()
perf: Remove dev_err() usage after platform_get_irq()
pinctrl: Remove dev_err() usage after platform_get_irq()
pinctrl: intel: Remove dev_err() usage after platform_get_irq()
power: supply: Remove dev_err() usage after platform_get_irq()
pwm: Remove dev_err() usage after platform_get_irq()
regulator: Remove dev_err() usage after platform_get_irq()
remoteproc: Remove dev_err() usage after platform_get_irq()
rtc: Remove dev_err() usage after platform_get_irq()
soc: Remove dev_err() usage after platform_get_irq()
spi: Remove dev_err() usage after platform_get_irq()
staging: Remove dev_err() usage after platform_get_irq()
thermal: Remove dev_err() usage after platform_get_irq()
tty: Remove dev_err() usage after platform_get_irq()
uio: Remove dev_err() usage after platform_get_irq()
usb: Remove dev_err() usage after platform_get_irq()
video: Remove dev_err() usage after platform_get_irq()
watchdog: Remove dev_err() usage after platform_get_irq()
ASoC: Remove dev_err() usage after platform_get_irq()
gpu: Remove dev_err() usage after platform_get_irq()
net: Remove dev_err() usage after platform_get_irq()
platform/x86: intel_pmc_ipc: Remove dev_err() usage after
platform_get_irq()
platform/mellanox: mlxreg-hotplug: Remove dev_err() usage after
platform_get_irq()
platform/x86: intel_bxtwc_tmu: Remove dev_err() usage after
platform_get_irq()
platform/x86: intel_int0002_vgpio: Remove dev_err() usage after
platform_get_irq()
scsi: Remove dev_err() usage after platform_get_irq()
ALSA: x86: Remove dev_err() usage after platform_get_irq()

arch/arm/plat-omap/dma.c | 1 -
arch/arm/plat-pxa/ssp.c | 5 ++-
arch/arm/plat-samsung/adc.c | 4 +--
arch/mips/ralink/timer.c | 4 +--
drivers/ata/libahci_platform.c | 7 ++--
drivers/ata/pata_rb532_cf.c | 4 +--
drivers/ata/sata_highbank.c | 4 +--
drivers/bus/sunxi-rsb.c | 4 +--
drivers/char/hw_random/imx-rngc.c | 4 +--
drivers/char/hw_random/omap-rng.c | 5 +--
drivers/char/hw_random/xgene-rng.c | 4 +--
drivers/clocksource/em_sti.c | 4 +--
drivers/clocksource/sh_cmt.c | 5 +--
drivers/clocksource/sh_tmu.c | 5 +--
drivers/cpufreq/brcmstb-avs-cpufreq.c | 2 --
drivers/crypto/atmel-aes.c | 1 -
drivers/crypto/atmel-sha.c | 1 -
drivers/crypto/atmel-tdes.c | 1 -
drivers/crypto/ccree/cc_driver.c | 4 +--
drivers/crypto/img-hash.c | 1 -
drivers/crypto/mediatek/mtk-platform.c | 4 +--
drivers/crypto/mxs-dcp.c | 8 ++---
drivers/crypto/omap-aes.c | 1 -
drivers/crypto/omap-des.c | 1 -
drivers/crypto/omap-sham.c | 1 -
drivers/crypto/sahara.c | 4 +--
drivers/crypto/stm32/stm32-cryp.c | 4 +--
drivers/crypto/stm32/stm32-hash.c | 4 +--
drivers/devfreq/tegra-devfreq.c | 4 +--
drivers/dma/dma-jz4780.c | 4 +--
drivers/dma/fsl-edma.c | 8 ++---
drivers/dma/fsl-qdma.c | 9 ++---
drivers/dma/mediatek/mtk-uart-apdma.c | 4 +--
drivers/dma/qcom/hidma_mgmt.c | 1 -
drivers/dma/s3c24xx-dma.c | 5 +--
drivers/dma/sh/rcar-dmac.c | 4 +--
drivers/dma/sh/usb-dmac.c | 4 +--
drivers/dma/st_fdma.c | 4 +--
drivers/dma/stm32-dma.c | 6 +---
drivers/dma/stm32-mdma.c | 4 +--
drivers/dma/sun4i-dma.c | 4 +--
drivers/dma/sun6i-dma.c | 4 +--
drivers/dma/uniphier-mdmac.c | 5 +--
drivers/dma/xgene-dma.c | 8 ++---
drivers/edac/altera_edac.c | 13 ++-----
drivers/edac/xgene_edac.c | 1 -
drivers/extcon/extcon-adc-jack.c | 4 +--
drivers/firmware/tegra/bpmp-tegra210.c | 8 ++---
drivers/fpga/zynq-fpga.c | 4 +--
drivers/gpio/gpio-brcmstb.c | 4 +--
drivers/gpio/gpio-eic-sprd.c | 4 +--
drivers/gpio/gpio-grgpio.c | 2 --
drivers/gpio/gpio-max77620.c | 4 +--
drivers/gpio/gpio-pmic-eic-sprd.c | 4 +--
drivers/gpio/gpio-sprd.c | 4 +--
drivers/gpio/gpio-tb10x.c | 4 +--
drivers/gpio/gpio-tegra.c | 4 +--
drivers/gpio/gpio-zx.c | 1 -
drivers/gpio/gpio-zynq.c | 4 +--
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +--
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 -
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 +--
drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 +--
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--
drivers/gpu/drm/imx/imx-tve.c | 4 +--
drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--
drivers/gpu/drm/mediatek/mtk_cec.c | 4 +--
drivers/gpu/drm/mediatek/mtk_dpi.c | 4 +--
drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +--
drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +--
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 4 +--
drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--
drivers/gpu/drm/tegra/dc.c | 4 +--
drivers/gpu/drm/tegra/dpaux.c | 4 +--
drivers/gpu/drm/tegra/sor.c | 4 +--
drivers/gpu/host1x/dev.c | 4 +--
drivers/hsi/controllers/omap_ssi_core.c | 4 +--
drivers/hsi/controllers/omap_ssi_port.c | 4 +--
drivers/hwmon/jz4740-hwmon.c | 5 +--
drivers/hwmon/npcm750-pwm-fan.c | 4 +--
drivers/i2c/busses/i2c-altera.c | 4 +--
drivers/i2c/busses/i2c-axxia.c | 4 +--
drivers/i2c/busses/i2c-bcm-kona.c | 1 -
drivers/i2c/busses/i2c-cht-wc.c | 4 +--
drivers/i2c/busses/i2c-efm32.c | 1 -
drivers/i2c/busses/i2c-hix5hd2.c | 4 +--
drivers/i2c/busses/i2c-img-scb.c | 4 +--
drivers/i2c/busses/i2c-imx-lpi2c.c | 4 +--
drivers/i2c/busses/i2c-imx.c | 4 +--
drivers/i2c/busses/i2c-lpc2k.c | 4 +--
drivers/i2c/busses/i2c-meson.c | 4 +--
drivers/i2c/busses/i2c-omap.c | 4 +--
drivers/i2c/busses/i2c-owl.c | 4 +--
drivers/i2c/busses/i2c-pnx.c | 1 -
drivers/i2c/busses/i2c-pxa.c | 4 +--
drivers/i2c/busses/i2c-qcom-geni.c | 4 +--
drivers/i2c/busses/i2c-qup.c | 4 +--
drivers/i2c/busses/i2c-rk3x.c | 4 +--
drivers/i2c/busses/i2c-sprd.c | 4 +--
drivers/i2c/busses/i2c-stm32f7.c | 12 ++-----
drivers/i2c/busses/i2c-sun6i-p2wi.c | 4 +--
drivers/i2c/busses/i2c-synquacer.c | 4 +--
drivers/i2c/busses/i2c-uniphier-f.c | 4 +--
drivers/i2c/busses/i2c-uniphier.c | 4 +--
drivers/i2c/busses/i2c-xlp9xx.c | 6 ++--
drivers/iio/adc/ad7606_par.c | 4 +--
drivers/iio/adc/at91_adc.c | 4 +--
drivers/iio/adc/axp288_adc.c | 4 +--
drivers/iio/adc/bcm_iproc_adc.c | 7 ++--
drivers/iio/adc/da9150-gpadc.c | 4 +--
drivers/iio/adc/envelope-detector.c | 5 +--
drivers/iio/adc/exynos_adc.c | 4 +--
drivers/iio/adc/fsl-imx25-gcq.c | 1 -
drivers/iio/adc/imx7d_adc.c | 4 +--
drivers/iio/adc/lpc32xx_adc.c | 4 +--
drivers/iio/adc/npcm_adc.c | 1 -
drivers/iio/adc/rockchip_saradc.c | 4 +--
drivers/iio/adc/sc27xx_adc.c | 4 +--
drivers/iio/adc/spear_adc.c | 1 -
drivers/iio/adc/stm32-adc-core.c | 1 -
drivers/iio/adc/stm32-adc.c | 4 +--
drivers/iio/adc/stm32-dfsdm-adc.c | 5 +--
drivers/iio/adc/sun4i-gpadc-iio.c | 4 +--
drivers/iio/adc/twl6030-gpadc.c | 4 +--
drivers/iio/adc/vf610_adc.c | 4 +--
drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 4 +--
drivers/input/keyboard/bcm-keypad.c | 4 +--
drivers/input/keyboard/davinci_keyscan.c | 1 -
drivers/input/keyboard/imx_keypad.c | 4 +--
drivers/input/keyboard/lpc32xx-keys.c | 4 +--
drivers/input/keyboard/nomadik-ske-keypad.c | 4 +--
drivers/input/keyboard/nspire-keypad.c | 4 +--
drivers/input/keyboard/opencores-kbd.c | 4 +--
drivers/input/keyboard/pmic8xxx-keypad.c | 8 ++---
drivers/input/keyboard/pxa27x_keypad.c | 4 +--
drivers/input/keyboard/pxa930_rotary.c | 4 +--
drivers/input/keyboard/sh_keysc.c | 4 +--
drivers/input/keyboard/snvs_pwrkey.c | 4 +--
drivers/input/keyboard/spear-keyboard.c | 4 +--
drivers/input/keyboard/st-keyscan.c | 4 +--
drivers/input/keyboard/tegra-kbc.c | 4 +--
drivers/input/keyboard/w90p910_keypad.c | 4 +--
drivers/input/misc/88pm80x_onkey.c | 1 -
drivers/input/misc/88pm860x_onkey.c | 4 +--
drivers/input/misc/ab8500-ponkey.c | 8 ++---
drivers/input/misc/axp20x-pek.c | 10 ++----
drivers/input/misc/da9055_onkey.c | 5 +--
drivers/input/misc/da9063_onkey.c | 7 ++--
drivers/input/misc/e3x0-button.c | 10 ++----
drivers/input/misc/hisi_powerkey.c | 8 ++---
drivers/input/misc/max8925_onkey.c | 8 ++---
drivers/input/misc/pm8941-pwrkey.c | 4 +--
drivers/input/misc/rk805-pwrkey.c | 8 ++---
drivers/input/misc/stpmic1_onkey.c | 10 ++----
drivers/input/misc/tps65218-pwrbutton.c | 4 +--
drivers/input/misc/twl6040-vibra.c | 4 +--
drivers/input/mouse/pxa930_trkball.c | 4 +--
drivers/input/serio/arc_ps2.c | 4 +--
drivers/input/serio/ps2-gpio.c | 2 --
drivers/input/touchscreen/88pm860x-ts.c | 4 +--
drivers/input/touchscreen/bcm_iproc_tsc.c | 4 +--
drivers/input/touchscreen/fsl-imx25-tcq.c | 4 +--
drivers/input/touchscreen/imx6ul_tsc.c | 8 ++---
drivers/input/touchscreen/lpc32xx_ts.c | 4 +--
drivers/iommu/exynos-iommu.c | 4 +--
drivers/iommu/msm_iommu.c | 1 -
drivers/iommu/qcom_iommu.c | 4 +--
drivers/irqchip/irq-imgpdc.c | 8 ++---
drivers/irqchip/irq-keystone.c | 4 +--
drivers/irqchip/qcom-irq-combiner.c | 4 +--
drivers/mailbox/armada-37xx-rwtm-mailbox.c | 4 +--
drivers/mailbox/platform_mhu.c | 4 +--
drivers/mailbox/stm32-ipcc.c | 5 ---
drivers/mailbox/zynqmp-ipi-mailbox.c | 4 +--
drivers/media/platform/am437x/am437x-vpfe.c | 1 -
.../media/platform/atmel/atmel-sama5d2-isc.c | 7 ++--
drivers/media/platform/exynos4-is/mipi-csis.c | 4 +--
drivers/media/platform/imx-pxp.c | 4 +--
drivers/media/platform/omap3isp/isp.c | 1 -
drivers/media/platform/renesas-ceu.c | 4 +--
drivers/media/platform/rockchip/rga/rga.c | 1 -
drivers/media/platform/s3c-camif/camif-core.c | 4 +--
.../platform/sti/c8sectpfe/c8sectpfe-core.c | 8 ++---
drivers/media/platform/sti/hva/hva-hw.c | 8 ++---
drivers/media/platform/stm32/stm32-dcmi.c | 5 +--
.../platform/sunxi/sun6i-csi/sun6i_csi.c | 7 ++--
drivers/media/rc/img-ir/img-ir-core.c | 4 +--
drivers/media/rc/ir-hix5hd2.c | 4 +--
drivers/media/rc/meson-ir.c | 4 +--
drivers/media/rc/mtk-cir.c | 4 +--
drivers/media/rc/sunxi-cir.c | 1 -
drivers/memory/emif.c | 5 +--
drivers/memory/tegra/mc.c | 4 +--
drivers/mfd/ab8500-debugfs.c | 8 ++---
drivers/mfd/db8500-prcmu.c | 4 +--
drivers/mfd/fsl-imx25-tsadc.c | 4 +--
drivers/mfd/intel_soc_pmic_bxtwc.c | 4 +--
drivers/mfd/jz4740-adc.c | 11 ++----
drivers/mfd/qcom_rpm.c | 12 ++-----
drivers/mfd/sm501.c | 4 +--
drivers/misc/spear13xx_pcie_gadget.c | 4 +--
drivers/mmc/host/bcm2835.c | 1 -
drivers/mmc/host/jz4740_mmc.c | 1 -
drivers/mmc/host/meson-gx-mmc.c | 1 -
drivers/mmc/host/mxcmmc.c | 4 +--
drivers/mmc/host/s3cmci.c | 1 -
drivers/mmc/host/sdhci-msm.c | 2 --
drivers/mmc/host/sdhci-pltfm.c | 1 -
drivers/mmc/host/sdhci-s3c.c | 4 +--
drivers/mmc/host/sdhci_f_sdh30.c | 4 +--
drivers/mmc/host/uniphier-sd.c | 4 +--
drivers/mtd/devices/spear_smi.c | 1 -
drivers/mtd/nand/raw/denali_dt.c | 4 +--
drivers/mtd/nand/raw/hisi504_nand.c | 4 +--
drivers/mtd/nand/raw/lpc32xx_mlc.c | 1 -
drivers/mtd/nand/raw/marvell_nand.c | 4 +--
drivers/mtd/nand/raw/meson_nand.c | 4 +--
drivers/mtd/nand/raw/mtk_ecc.c | 4 +--
drivers/mtd/nand/raw/mtk_nand.c | 1 -
drivers/mtd/nand/raw/omap2.c | 8 ++---
drivers/mtd/nand/raw/sh_flctl.c | 4 +--
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 5 +--
drivers/mtd/nand/raw/sunxi_nand.c | 4 +--
drivers/mtd/spi-nor/cadence-quadspi.c | 4 +--
drivers/net/can/janz-ican3.c | 1 -
drivers/net/can/rcar/rcar_can.c | 1 -
drivers/net/can/rcar/rcar_canfd.c | 2 --
drivers/net/can/sun4i_can.c | 1 -
drivers/net/ethernet/amd/au1000_eth.c | 1 -
drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 14 ++------
drivers/net/ethernet/apm/xgene-v2/main.c | 4 +--
.../net/ethernet/apm/xgene/xgene_enet_main.c | 4 +--
drivers/net/ethernet/aurora/nb8800.c | 4 +--
.../net/ethernet/broadcom/bgmac-platform.c | 4 +--
drivers/net/ethernet/cortina/gemini.c | 4 +--
drivers/net/ethernet/davicom/dm9000.c | 2 --
drivers/net/ethernet/hisilicon/hisi_femac.c | 1 -
drivers/net/ethernet/lantiq_xrx200.c | 10 ++----
drivers/net/ethernet/nuvoton/w90p910_ether.c | 2 --
drivers/net/ethernet/qualcomm/emac/emac.c | 5 +--
drivers/net/ethernet/socionext/sni_ave.c | 4 +--
.../stmicro/stmmac/dwmac-dwc-qos-eth.c | 7 +---
.../ethernet/stmicro/stmmac/stmmac_platform.c | 7 +---
.../net/wireless/mediatek/mt76/mt7603/soc.c | 4 +--
drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++---
drivers/pci/controller/dwc/pci-exynos.c | 8 ++---
drivers/pci/controller/dwc/pci-imx6.c | 4 +--
drivers/pci/controller/dwc/pci-keystone.c | 4 +--
drivers/pci/controller/dwc/pci-meson.c | 4 +--
drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--
drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--
drivers/pci/controller/dwc/pcie-histb.c | 4 +--
drivers/pci/controller/dwc/pcie-kirin.c | 5 +--
drivers/pci/controller/dwc/pcie-spear13xx.c | 4 +--
drivers/pci/controller/pci-tegra.c | 8 ++---
drivers/pci/controller/pci-v3-semi.c | 4 +--
drivers/pci/controller/pci-xgene-msi.c | 2 --
drivers/pci/controller/pcie-altera-msi.c | 1 -
drivers/pci/controller/pcie-altera.c | 4 +--
drivers/pci/controller/pcie-mobiveil.c | 4 +--
drivers/pci/controller/pcie-rockchip-host.c | 12 ++-----
drivers/pci/controller/pcie-tango.c | 4 +--
drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++----
drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 4 +--
drivers/perf/hisilicon/hisi_uncore_hha_pmu.c | 4 +--
drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 4 +--
drivers/perf/qcom_l2_pmu.c | 6 +---
drivers/perf/xgene_pmu.c | 4 +--
drivers/pinctrl/intel/pinctrl-cherryview.c | 4 +--
drivers/pinctrl/intel/pinctrl-intel.c | 4 +--
drivers/pinctrl/pinctrl-amd.c | 4 +--
drivers/pinctrl/pinctrl-oxnas.c | 4 +--
drivers/pinctrl/pinctrl-pic32.c | 4 +--
drivers/pinctrl/pinctrl-stmfx.c | 4 +--
drivers/pinctrl/qcom/pinctrl-msm.c | 4 +--
drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 5 +--
drivers/platform/mellanox/mlxreg-hotplug.c | 5 +--
drivers/platform/x86/intel_bxtwc_tmu.c | 5 +--
drivers/platform/x86/intel_int0002_vgpio.c | 4 +--
drivers/platform/x86/intel_pmc_ipc.c | 4 +--
drivers/power/supply/88pm860x_battery.c | 8 ++---
drivers/power/supply/axp288_charger.c | 4 +--
drivers/power/supply/bd70528-charger.c | 5 +--
drivers/power/supply/da9150-charger.c | 8 ++---
drivers/power/supply/da9150-fg.c | 1 -
drivers/power/supply/goldfish_battery.c | 4 +--
drivers/power/supply/jz4740-battery.c | 4 +--
drivers/power/supply/qcom_smbb.c | 5 +--
drivers/power/supply/sc27xx_fuel_gauge.c | 4 +--
drivers/pwm/pwm-sti.c | 4 +--
drivers/regulator/da9062-regulator.c | 4 +--
drivers/regulator/da9063-regulator.c | 4 +--
drivers/remoteproc/da8xx_remoteproc.c | 4 +--
drivers/remoteproc/keystone_remoteproc.c | 4 ---
drivers/remoteproc/qcom_q6v5.c | 35 +++----------------
drivers/rtc/rtc-88pm80x.c | 1 -
drivers/rtc/rtc-88pm860x.c | 4 +--
drivers/rtc/rtc-ac100.c | 4 +--
drivers/rtc/rtc-armada38x.c | 5 +--
drivers/rtc/rtc-asm9260.c | 4 +--
drivers/rtc/rtc-at91rm9200.c | 4 +--
drivers/rtc/rtc-at91sam9.c | 4 +--
drivers/rtc/rtc-bd70528.c | 5 +--
drivers/rtc/rtc-davinci.c | 4 +--
drivers/rtc/rtc-jz4740.c | 4 +--
drivers/rtc/rtc-max77686.c | 5 +--
drivers/rtc/rtc-mt7622.c | 1 -
drivers/rtc/rtc-pic32.c | 4 +--
drivers/rtc/rtc-pm8xxx.c | 4 +--
drivers/rtc/rtc-puv3.c | 8 ++---
drivers/rtc/rtc-pxa.c | 8 ++---
drivers/rtc/rtc-rk808.c | 6 +---
drivers/rtc/rtc-s3c.c | 8 ++---
drivers/rtc/rtc-sc27xx.c | 4 +--
drivers/rtc/rtc-spear.c | 4 +--
drivers/rtc/rtc-stm32.c | 1 -
drivers/rtc/rtc-sun6i.c | 4 +--
drivers/rtc/rtc-sunxi.c | 4 +--
drivers/rtc/rtc-tegra.c | 4 +--
drivers/rtc/rtc-vt8500.c | 4 +--
drivers/rtc/rtc-xgene.c | 4 +--
drivers/rtc/rtc-zynqmp.c | 8 ++---
drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
drivers/soc/fsl/qbman/bman_portal.c | 4 +--
drivers/soc/fsl/qbman/qman_portal.c | 4 +--
drivers/soc/qcom/smp2p.c | 4 +--
drivers/spi/atmel-quadspi.c | 1 -
drivers/spi/spi-armada-3700.c | 1 -
drivers/spi/spi-bcm2835.c | 1 -
drivers/spi/spi-bcm2835aux.c | 1 -
drivers/spi/spi-bcm63xx-hsspi.c | 4 +--
drivers/spi/spi-bcm63xx.c | 4 +--
drivers/spi/spi-cadence.c | 1 -
drivers/spi/spi-dw-mmio.c | 4 +--
drivers/spi/spi-efm32.c | 4 +--
drivers/spi/spi-ep93xx.c | 4 +--
drivers/spi/spi-fsl-dspi.c | 1 -
drivers/spi/spi-fsl-qspi.c | 4 +--
drivers/spi/spi-geni-qcom.c | 4 +--
drivers/spi/spi-lantiq-ssc.c | 12 ++-----
drivers/spi/spi-mt65xx.c | 1 -
drivers/spi/spi-npcm-pspi.c | 1 -
drivers/spi/spi-nuc900.c | 1 -
drivers/spi/spi-nxp-fspi.c | 4 +--
drivers/spi/spi-pic32-sqi.c | 1 -
drivers/spi/spi-pic32.c | 12 ++-----
drivers/spi/spi-qcom-qspi.c | 4 +--
drivers/spi/spi-s3c24xx.c | 1 -
drivers/spi/spi-sh-msiof.c | 1 -
drivers/spi/spi-sh.c | 4 +--
drivers/spi/spi-sifive.c | 1 -
drivers/spi/spi-slave-mt27xx.c | 1 -
drivers/spi/spi-sprd.c | 4 +--
drivers/spi/spi-stm32-qspi.c | 5 +--
drivers/spi/spi-sun4i.c | 1 -
drivers/spi/spi-sun6i.c | 1 -
drivers/spi/spi-synquacer.c | 2 --
drivers/spi/spi-ti-qspi.c | 1 -
drivers/spi/spi-uniphier.c | 1 -
drivers/spi/spi-xlp.c | 4 +--
drivers/spi/spi-zynq-qspi.c | 1 -
drivers/spi/spi-zynqmp-gqspi.c | 1 -
drivers/staging/emxx_udc/emxx_udc.c | 4 +--
drivers/staging/goldfish/goldfish_audio.c | 4 +--
.../staging/media/allegro-dvt/allegro-core.c | 4 +--
drivers/staging/media/hantro/hantro_drv.c | 4 +--
drivers/staging/media/imx/imx7-media-csi.c | 4 +--
drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--
drivers/staging/media/meson/vdec/esparser.c | 4 +--
drivers/staging/media/omap4iss/iss.c | 1 -
.../staging/media/sunxi/cedrus/cedrus_hw.c | 5 +--
drivers/staging/most/dim2/dim2.c | 2 --
drivers/staging/mt7621-dma/mtk-hsdma.c | 4 +--
drivers/staging/nvec/nvec.c | 4 +--
drivers/staging/ralink-gdma/ralink-gdma.c | 4 +--
.../interface/vchiq_arm/vchiq_2835_arm.c | 4 +--
drivers/thermal/broadcom/brcmstb_thermal.c | 4 +--
drivers/thermal/da9062-thermal.c | 4 +--
drivers/thermal/db8500_thermal.c | 2 --
drivers/thermal/rockchip_thermal.c | 4 +--
drivers/thermal/st/st_thermal_memmap.c | 4 +--
drivers/thermal/st/stm_thermal.c | 4 +--
drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 +--
drivers/tty/serial/8250/8250_bcm2835aux.c | 4 +--
drivers/tty/serial/8250/8250_lpc18xx.c | 4 +--
drivers/tty/serial/8250/8250_uniphier.c | 4 +--
drivers/tty/serial/amba-pl011.c | 5 +--
drivers/tty/serial/fsl_lpuart.c | 4 +--
drivers/tty/serial/lpc32xx_hs.c | 5 +--
drivers/tty/serial/mvebu-uart.c | 12 ++-----
drivers/tty/serial/owl-uart.c | 4 +--
drivers/tty/serial/qcom_geni_serial.c | 4 +--
drivers/tty/serial/rda-uart.c | 4 +--
drivers/tty/serial/sccnxp.c | 1 -
drivers/tty/serial/serial-tegra.c | 4 +--
drivers/tty/serial/sifive.c | 4 +--
drivers/tty/serial/sprd_serial.c | 4 +--
drivers/tty/serial/stm32-usart.c | 17 +++------
drivers/uio/uio_dmem_genirq.c | 4 +--
drivers/usb/chipidea/core.c | 1 -
drivers/usb/dwc2/platform.c | 4 +--
drivers/usb/dwc3/dwc3-keystone.c | 1 -
drivers/usb/dwc3/dwc3-omap.c | 4 +--
drivers/usb/gadget/udc/aspeed-vhub/core.c | 1 -
drivers/usb/gadget/udc/bcm63xx_udc.c | 8 ++---
drivers/usb/gadget/udc/bdc/bdc_core.c | 4 +--
drivers/usb/gadget/udc/gr_udc.c | 8 ++---
drivers/usb/gadget/udc/lpc32xx_udc.c | 5 +--
drivers/usb/gadget/udc/renesas_usb3.c | 4 +--
drivers/usb/gadget/udc/s3c-hsudc.c | 4 +--
drivers/usb/gadget/udc/udc-xilinx.c | 4 +--
drivers/usb/host/ehci-atmel.c | 3 --
drivers/usb/host/ehci-omap.c | 4 +--
drivers/usb/host/ehci-orion.c | 3 --
drivers/usb/host/ehci-platform.c | 4 +--
drivers/usb/host/ehci-sh.c | 3 --
drivers/usb/host/ehci-st.c | 4 +--
drivers/usb/host/imx21-hcd.c | 4 +--
drivers/usb/host/ohci-platform.c | 4 +--
drivers/usb/host/ohci-st.c | 4 +--
drivers/usb/mtu3/mtu3_core.c | 4 +--
drivers/usb/phy/phy-ab8500-usb.c | 12 ++-----
drivers/usb/typec/tcpm/wcove.c | 4 +--
drivers/video/fbdev/atmel_lcdfb.c | 1 -
drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 1 -
drivers/video/fbdev/nuc900fb.c | 4 +--
drivers/video/fbdev/pxa168fb.c | 4 +--
drivers/video/fbdev/pxa3xx-gcu.c | 4 +--
drivers/video/fbdev/pxafb.c | 1 -
drivers/video/fbdev/s3c2410fb.c | 4 +--
drivers/video/fbdev/vt8500lcdfb.c | 1 -
drivers/watchdog/sprd_wdt.c | 4 +--
sound/soc/atmel/atmel-classd.c | 7 ++--
sound/soc/atmel/atmel-pdmic.c | 7 ++--
sound/soc/bcm/cygnus-ssp.c | 7 ++--
sound/soc/codecs/msm8916-wcd-analog.c | 12 ++-----
sound/soc/codecs/twl6040.c | 4 +--
sound/soc/fsl/fsl_asrc.c | 4 +--
sound/soc/fsl/fsl_esai.c | 4 +--
sound/soc/fsl/fsl_sai.c | 4 +--
sound/soc/fsl/fsl_spdif.c | 4 +--
sound/soc/fsl/fsl_ssi.c | 4 +--
sound/soc/fsl/imx-ssi.c | 4 +--
sound/soc/kirkwood/kirkwood-i2s.c | 4 +--
sound/soc/mediatek/common/mtk-btcvsd.c | 4 +--
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 4 +--
sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 4 +--
sound/soc/mxs/mxs-saif.c | 8 ++---
sound/soc/qcom/lpass-platform.c | 5 +--
sound/soc/sof/intel/bdw.c | 5 +--
sound/soc/sof/intel/byt.c | 5 +--
sound/soc/sprd/sprd-mcdt.c | 4 +--
sound/soc/sti/sti_uniperif.c | 4 +--
sound/soc/stm/stm32_i2s.c | 5 +--
sound/soc/stm/stm32_sai.c | 4 +--
sound/soc/stm/stm32_spdifrx.c | 4 +--
sound/soc/sunxi/sun4i-i2s.c | 4 +--
sound/soc/uniphier/aio-dma.c | 4 +--
sound/soc/xilinx/xlnx_formatter_pcm.c | 2 --
sound/soc/xtensa/xtfpga-i2s.c | 1 -
sound/x86/intel_hdmi_audio.c | 4 +--
462 files changed, 441 insertions(+), 1504 deletions(-)

base-commit: 7b5cf701ea9c395c792e2a7e3b7caf4c68b87721
prerequisite-patch-id: 3886b1af0c4ad13235927e24e92fd468caa724af
--
Sent by a computer through tubes

2019-07-30 20:05:22

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 10/57] dmaengine: Remove dev_err() usage after platform_get_irq()

2019-07-30 20:05:48

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 12/57] extcon: Remove dev_err() usage after platform_get_irq()

2019-07-30 20:08:14

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 14/57] fpga: Remove dev_err() usage after platform_get_irq()

2019-07-30 20:08:27

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 21/57] Input: Remove dev_err() usage after platform_get_irq()

[permalink] [raw]

Subject: [PATCH v6 45/57] uio: Remove dev_err() usage after platform_get_irq()

2019-07-30 21:47:00

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 47/57] video: Remove dev_err() usage after platform_get_irq()

2019-07-30 21:48:39

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 49/57] ASoC: Remove dev_err() usage after platform_get_irq()

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Liam Girdwood <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Jaroslav Kysela <[email protected]>
Cc: Takashi Iwai <[email protected]>
Cc: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---

Please apply directly to subsystem trees

sound/soc/atmel/atmel-classd.c | 7 ++-----
sound/soc/atmel/atmel-pdmic.c | 7 ++-----
sound/soc/bcm/cygnus-ssp.c | 7 ++-----
sound/soc/codecs/msm8916-wcd-analog.c | 12 +++---------
sound/soc/codecs/twl6040.c | 4 +---
sound/soc/fsl/fsl_asrc.c | 4 +---
sound/soc/fsl/fsl_esai.c | 4 +---
sound/soc/fsl/fsl_sai.c | 4 +---
sound/soc/fsl/fsl_spdif.c | 4 +---
sound/soc/fsl/fsl_ssi.c | 4 +---
sound/soc/fsl/imx-ssi.c | 4 +---
sound/soc/kirkwood/kirkwood-i2s.c | 4 +---
sound/soc/mediatek/common/mtk-btcvsd.c | 4 +---
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c | 4 +---
sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 4 +---
sound/soc/mxs/mxs-saif.c | 8 ++------
sound/soc/qcom/lpass-platform.c | 5 +----
sound/soc/sof/intel/bdw.c | 5 +----
sound/soc/sof/intel/byt.c | 5 +----
sound/soc/sprd/sprd-mcdt.c | 4 +---
sound/soc/sti/sti_uniperif.c | 4 +---
sound/soc/stm/stm32_i2s.c | 5 +----
sound/soc/stm/stm32_sai.c | 4 +---
sound/soc/stm/stm32_spdifrx.c | 4 +---
sound/soc/sunxi/sun4i-i2s.c | 4 +---
sound/soc/uniphier/aio-dma.c | 4 +---
sound/soc/xilinx/xlnx_formatter_pcm.c | 2 --
sound/soc/xtensa/xtfpga-i2s.c | 1 -
28 files changed, 32 insertions(+), 100 deletions(-)

diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
index 0f2c574f27f1..e98601eccfa3 100644
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -571,11 +571,8 @@ static int atmel_classd_probe(struct platform_device *pdev)
dd->pdata = pdata;

dd->irq = platform_get_irq(pdev, 0);
- if (dd->irq < 0) {
- ret = dd->irq;
- dev_err(dev, "failed to could not get irq: %d\n", ret);
- return ret;
- }
+ if (dd->irq < 0)
+ return dd->irq;

dd->pclk = devm_clk_get(dev, "pclk");
if (IS_ERR(dd->pclk)) {
diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c
index e09c28349e0d..04ec6f0af179 100644
--- a/sound/soc/atmel/atmel-pdmic.c
+++ b/sound/soc/atmel/atmel-pdmic.c
@@ -612,11 +612,8 @@ static int atmel_pdmic_probe(struct platform_device *pdev)
dd->dev = dev;

dd->irq = platform_get_irq(pdev, 0);
- if (dd->irq < 0) {
- ret = dd->irq;
- dev_err(dev, "failed to get irq: %d\n", ret);
- return ret;
- }
+ if (dd->irq < 0)
+ return dd->irq;

dd->pclk = devm_clk_get(dev, "pclk");
if (IS_ERR(dd->pclk)) {
diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c
index b7c358b48d8d..2f9357d7da96 100644
--- a/sound/soc/bcm/cygnus-ssp.c
+++ b/sound/soc/bcm/cygnus-ssp.c
@@ -1342,11 +1342,8 @@ static int cygnus_ssp_probe(struct platform_device *pdev)
}

cygaud->irq_num = platform_get_irq(pdev, 0);
- if (cygaud->irq_num <= 0) {
- dev_err(dev, "platform_get_irq failed\n");
- err = cygaud->irq_num;
- return err;
- }
+ if (cygaud->irq_num <= 0)
+ return cygaud->irq_num;

err = audio_clk_init(pdev, cygaud);
if (err) {
diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
index 368b6c09474b..667e9f73aba3 100644
--- a/sound/soc/codecs/msm8916-wcd-analog.c
+++ b/sound/soc/codecs/msm8916-wcd-analog.c
@@ -1185,10 +1185,8 @@ static int pm8916_wcd_analog_spmi_probe(struct platform_device *pdev)
}

irq = platform_get_irq_byname(pdev, "mbhc_switch_int");
- if (irq < 0) {
- dev_err(dev, "failed to get mbhc switch irq\n");
+ if (irq < 0)
return irq;
- }

ret = devm_request_threaded_irq(dev, irq, NULL,
pm8916_mbhc_switch_irq_handler,
@@ -1200,10 +1198,8 @@ static int pm8916_wcd_analog_spmi_probe(struct platform_device *pdev)

if (priv->mbhc_btn_enabled) {
irq = platform_get_irq_byname(pdev, "mbhc_but_press_det");
- if (irq < 0) {
- dev_err(dev, "failed to get button press irq\n");
+ if (irq < 0)
return irq;
- }

ret = devm_request_threaded_irq(dev, irq, NULL,
mbhc_btn_press_irq_handler,
@@ -1214,10 +1210,8 @@ static int pm8916_wcd_analog_spmi_probe(struct platform_device *pdev)
dev_err(dev, "cannot request mbhc button press irq\n");

irq = platform_get_irq_byname(pdev, "mbhc_but_rel_det");
- if (irq < 0) {
- dev_err(dev, "failed to get button release irq\n");
+ if (irq < 0)
return irq;
- }

ret = devm_request_threaded_irq(dev, irq, NULL,
mbhc_btn_release_irq_handler,
diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index 472c2fff34a8..f34637afee51 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -1108,10 +1108,8 @@ static int twl6040_probe(struct snd_soc_component *component)
priv->component = component;

priv->plug_irq = platform_get_irq(pdev, 0);
- if (priv->plug_irq < 0) {
- dev_err(component->dev, "invalid irq: %d\n", priv->plug_irq);
+ if (priv->plug_irq < 0)
return priv->plug_irq;
- }

INIT_DELAYED_WORK(&priv->hs_jack.work, twl6040_accessory_work);

diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index cbbf6257f08a..cfa40ef6b1ca 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c
@@ -885,10 +885,8 @@ static int fsl_asrc_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
dev_name(&pdev->dev), asrc_priv);
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index 10d2210c91ef..19524ca9b4f1 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -824,10 +824,8 @@ static int fsl_esai_probe(struct platform_device *pdev)
PTR_ERR(esai_priv->spbaclk));

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(&pdev->dev, irq, esai_isr, 0,
esai_priv->name, esai_priv);
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index d58cc3ae90d8..6faf222add2b 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -832,10 +832,8 @@ static int fsl_sai_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(&pdev->dev, irq, fsl_sai_isr, 0, np->name, sai);
if (ret) {
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 4842e6df9a2d..7858a5499ac5 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1248,10 +1248,8 @@ static int fsl_spdif_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(&pdev->dev, irq, spdif_isr, 0,
dev_name(&pdev->dev), spdif_priv);
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index fa862af25c1a..b0a6fead1a6a 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1510,10 +1510,8 @@ static int fsl_ssi_probe(struct platform_device *pdev)
}

ssi->irq = platform_get_irq(pdev, 0);
- if (ssi->irq < 0) {
- dev_err(dev, "no irq for node %s\n", pdev->name);
+ if (ssi->irq < 0)
return ssi->irq;
- }

/* Set software limitations for synchronous mode except AC97 */
if (ssi->synchronous && !fsl_ssi_is_ac97(ssi)) {
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
index 9038b61317be..42031ba7da31 100644
--- a/sound/soc/fsl/imx-ssi.c
+++ b/sound/soc/fsl/imx-ssi.c
@@ -520,10 +520,8 @@ static int imx_ssi_probe(struct platform_device *pdev)
}

ssi->irq = platform_get_irq(pdev, 0);
- if (ssi->irq < 0) {
- dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
+ if (ssi->irq < 0)
return ssi->irq;
- }

ssi->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(ssi->clk)) {
diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c
index 3446a113f482..bf9aa58b31c6 100644
--- a/sound/soc/kirkwood/kirkwood-i2s.c
+++ b/sound/soc/kirkwood/kirkwood-i2s.c
@@ -539,10 +539,8 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev)
return PTR_ERR(priv->io);

priv->irq = platform_get_irq(pdev, 0);
- if (priv->irq < 0) {
- dev_err(&pdev->dev, "platform_get_irq failed: %d\n", priv->irq);
+ if (priv->irq < 0)
return priv->irq;
- }

if (np) {
priv->burst = 128; /* might be 32 or 128 */
diff --git a/sound/soc/mediatek/common/mtk-btcvsd.c b/sound/soc/mediatek/common/mtk-btcvsd.c
index c7a81c4be068..d00608c73c6e 100644
--- a/sound/soc/mediatek/common/mtk-btcvsd.c
+++ b/sound/soc/mediatek/common/mtk-btcvsd.c
@@ -1335,10 +1335,8 @@ static int mtk_btcvsd_snd_probe(struct platform_device *pdev)

/* irq */
irq_id = platform_get_irq(pdev, 0);
- if (irq_id <= 0) {
- dev_err(dev, "%pOFn no irq found\n", dev->of_node);
+ if (irq_id <= 0)
return irq_id < 0 ? irq_id : -ENXIO;
- }

ret = devm_request_irq(dev, irq_id, mtk_btcvsd_snd_irq_handler,
IRQF_TRIGGER_LOW, "BTCVSD_ISR_Handle",
diff --git a/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c b/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
index 7064a9fd6f74..9af76ae315a5 100644
--- a/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
+++ b/sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
@@ -1342,10 +1342,8 @@ static int mt2701_afe_pcm_dev_probe(struct platform_device *pdev)
return -ENOMEM;

irq_id = platform_get_irq_byname(pdev, "asys");
- if (irq_id < 0) {
- dev_err(dev, "unable to get ASYS IRQ\n");
+ if (irq_id < 0)
return irq_id;
- }

ret = devm_request_irq(dev, irq_id, mt2701_asys_isr,
IRQF_TRIGGER_NONE, "asys-isr", (void *)afe);
diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
index 0382896c162e..2d45d44ee97b 100644
--- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
+++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
@@ -1075,10 +1075,8 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev)
afe->dev = &pdev->dev;

irq_id = platform_get_irq(pdev, 0);
- if (irq_id <= 0) {
- dev_err(afe->dev, "np %pOFn no irq\n", afe->dev->of_node);
+ if (irq_id <= 0)
return irq_id < 0 ? irq_id : -ENXIO;
- }
ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler,
0, "Afe_ISR_Handle", (void *)afe);
if (ret) {
diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index 269b6d6df250..ccfec47f63e8 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -793,12 +793,8 @@ static int mxs_saif_probe(struct platform_device *pdev)
return PTR_ERR(saif->base);

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- ret = irq;
- dev_err(&pdev->dev, "failed to get irq resource: %d\n",
- ret);
- return ret;
- }
+ if (irq < 0)
+ return irq;

saif->dev = &pdev->dev;
ret = devm_request_irq(&pdev->dev, irq, mxs_saif_irq, 0,
diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
index cf7a299f4547..4c745baa39f7 100644
--- a/sound/soc/qcom/lpass-platform.c
+++ b/sound/soc/qcom/lpass-platform.c
@@ -564,11 +564,8 @@ int asoc_qcom_lpass_platform_register(struct platform_device *pdev)
int ret;

drvdata->lpaif_irq = platform_get_irq_byname(pdev, "lpass-irq-lpaif");
- if (drvdata->lpaif_irq < 0) {
- dev_err(&pdev->dev, "error getting irq handle: %d\n",
- drvdata->lpaif_irq);
+ if (drvdata->lpaif_irq < 0)
return -ENODEV;
- }

/* ensure audio hardware is disabled */
ret = regmap_write(drvdata->lpaif_map,
diff --git a/sound/soc/sof/intel/bdw.c b/sound/soc/sof/intel/bdw.c
index 70d524ef9bc0..4bb9636da990 100644
--- a/sound/soc/sof/intel/bdw.c
+++ b/sound/soc/sof/intel/bdw.c
@@ -613,11 +613,8 @@ static int bdw_probe(struct snd_sof_dev *sdev)

/* register our IRQ */
sdev->ipc_irq = platform_get_irq(pdev, desc->irqindex_host_ipc);
- if (sdev->ipc_irq < 0) {
- dev_err(sdev->dev, "error: failed to get IRQ at index %d\n",
- desc->irqindex_host_ipc);
+ if (sdev->ipc_irq < 0)
return sdev->ipc_irq;
- }

dev_dbg(sdev->dev, "using IRQ %d\n", sdev->ipc_irq);
ret = devm_request_threaded_irq(sdev->dev, sdev->ipc_irq,
diff --git a/sound/soc/sof/intel/byt.c b/sound/soc/sof/intel/byt.c
index 107d711efc3f..000d576f6a8d 100644
--- a/sound/soc/sof/intel/byt.c
+++ b/sound/soc/sof/intel/byt.c
@@ -728,11 +728,8 @@ static int byt_acpi_probe(struct snd_sof_dev *sdev)
irq:
/* register our IRQ */
sdev->ipc_irq = platform_get_irq(pdev, desc->irqindex_host_ipc);
- if (sdev->ipc_irq < 0) {
- dev_err(sdev->dev, "error: failed to get IRQ at index %d\n",
- desc->irqindex_host_ipc);
+ if (sdev->ipc_irq < 0)
return sdev->ipc_irq;
- }

dev_dbg(sdev->dev, "using IRQ %d\n", sdev->ipc_irq);
ret = devm_request_threaded_irq(sdev->dev, sdev->ipc_irq,
diff --git a/sound/soc/sprd/sprd-mcdt.c b/sound/soc/sprd/sprd-mcdt.c
index 7448015a4935..f439e5503a3c 100644
--- a/sound/soc/sprd/sprd-mcdt.c
+++ b/sound/soc/sprd/sprd-mcdt.c
@@ -959,10 +959,8 @@ static int sprd_mcdt_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mcdt);

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "Failed to get MCDT interrupt\n");
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(&pdev->dev, irq, sprd_mcdt_irq_handler,
0, "sprd-mcdt", mcdt);
diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
index 645bcbe91601..ee4a0151e63e 100644
--- a/sound/soc/sti/sti_uniperif.c
+++ b/sound/soc/sti/sti_uniperif.c
@@ -426,10 +426,8 @@ static int sti_uniperiph_cpu_dai_of(struct device_node *node,
UNIPERIF_FIFO_DATA_OFFSET(uni);

uni->irq = platform_get_irq(priv->pdev, 0);
- if (uni->irq < 0) {
- dev_err(dev, "Failed to get IRQ resource\n");
+ if (uni->irq < 0)
return -ENXIO;
- }

uni->type = dev_data->type;

diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c
index ba6452dab69b..3e7226a53e53 100644
--- a/sound/soc/stm/stm32_i2s.c
+++ b/sound/soc/stm/stm32_i2s.c
@@ -855,11 +855,8 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev,

/* Get irqs */
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- if (irq != -EPROBE_DEFER)
- dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, IRQF_ONESHOT,
dev_name(&pdev->dev), i2s);
diff --git a/sound/soc/stm/stm32_sai.c b/sound/soc/stm/stm32_sai.c
index 63f68e663676..1c4cc1ca1eaa 100644
--- a/sound/soc/stm/stm32_sai.c
+++ b/sound/soc/stm/stm32_sai.c
@@ -195,10 +195,8 @@ static int stm32_sai_probe(struct platform_device *pdev)

/* init irqs */
sai->irq = platform_get_irq(pdev, 0);
- if (sai->irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
+ if (sai->irq < 0)
return sai->irq;
- }

/* reset */
rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c
index ee71b898897b..cd4b235fce57 100644
--- a/sound/soc/stm/stm32_spdifrx.c
+++ b/sound/soc/stm/stm32_spdifrx.c
@@ -909,10 +909,8 @@ static int stm32_spdifrx_parse_of(struct platform_device *pdev,
}

spdifrx->irq = platform_get_irq(pdev, 0);
- if (spdifrx->irq < 0) {
- dev_err(&pdev->dev, "No irq for node %s\n", pdev->name);
+ if (spdifrx->irq < 0)
return spdifrx->irq;
- }

return 0;
}
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 9b2232908b65..d97d694c48df 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -1087,10 +1087,8 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
return PTR_ERR(regs);

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "Can't retrieve our interrupt\n");
+ if (irq < 0)
return irq;
- }

i2s->variant = of_device_get_match_data(&pdev->dev);
if (!i2s->variant) {
diff --git a/sound/soc/uniphier/aio-dma.c b/sound/soc/uniphier/aio-dma.c
index fa001d3c1a88..2261655be10d 100644
--- a/sound/soc/uniphier/aio-dma.c
+++ b/sound/soc/uniphier/aio-dma.c
@@ -291,10 +291,8 @@ int uniphier_aiodma_soc_register_platform(struct platform_device *pdev)
return PTR_ERR(chip->regmap);

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "Could not get irq.\n");
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(dev, irq, aiodma_irq,
IRQF_SHARED, dev_name(dev), pdev);
diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c b/sound/soc/xilinx/xlnx_formatter_pcm.c
index dc8721f4f56b..48970efe7838 100644
--- a/sound/soc/xilinx/xlnx_formatter_pcm.c
+++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
@@ -613,7 +613,6 @@ static int xlnx_formatter_pcm_probe(struct platform_device *pdev)
aud_drv_data->mm2s_irq = platform_get_irq_byname(pdev,
"irq_mm2s");
if (aud_drv_data->mm2s_irq < 0) {
- dev_err(dev, "xlnx audio mm2s irq resource failed\n");
ret = aud_drv_data->mm2s_irq;
goto clk_err;
}
@@ -640,7 +639,6 @@ static int xlnx_formatter_pcm_probe(struct platform_device *pdev)
aud_drv_data->s2mm_irq = platform_get_irq_byname(pdev,
"irq_s2mm");
if (aud_drv_data->s2mm_irq < 0) {
- dev_err(dev, "xlnx audio s2mm irq resource failed\n");
ret = aud_drv_data->s2mm_irq;
goto clk_err;
}
diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c
index 9ce2c75186b9..e635bf08d935 100644
--- a/sound/soc/xtensa/xtfpga-i2s.c
+++ b/sound/soc/xtensa/xtfpga-i2s.c
@@ -572,7 +572,6 @@ static int xtfpga_i2s_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
err = irq;
goto err;
}
--
Sent by a computer through tubes

2019-07-30 21:51:38

by Stephen Boyd

[permalink] [raw]

Subject: [PATCH v6 43/57] thermal: Remove dev_err() usage after platform_get_irq()

2019-07-30 22:17:45

by Guenter Roeck

[permalink] [raw]

Subject: Re: [PATCH v6 48/57] watchdog: Remove dev_err() usage after platform_get_irq()

On Tue, Jul 30, 2019 at 11:15:48AM -0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
> While we're here, remove braces on if statements that only have one
> statement (manually).
>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
>
> Please apply directly to subsystem trees
>
> drivers/watchdog/sprd_wdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c
> index edba4e278685..0bb17b046140 100644
> --- a/drivers/watchdog/sprd_wdt.c
> +++ b/drivers/watchdog/sprd_wdt.c
> @@ -284,10 +284,8 @@ static int sprd_wdt_probe(struct platform_device *pdev)
> }
>
> wdt->irq = platform_get_irq(pdev, 0);
> - if (wdt->irq < 0) {
> - dev_err(dev, "failed to get IRQ resource\n");
> + if (wdt->irq < 0)
> return wdt->irq;
> - }
>
> ret = devm_request_irq(dev, wdt->irq, sprd_wdt_isr, IRQF_NO_SUSPEND,
> "sprd-wdt", (void *)wdt);
> --
> Sent by a computer through tubes
>

2019-07-30 23:24:01

[permalink] [raw]

Subject: Re: [PATCH v6 47/57] video: Remove dev_err() usage after platform_get_irq()

Hi,

Sorry for the late reply.

On 7/30/19 8:15 PM, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.

This patch changes handling of -EPROBE_DEFER in the modified drivers
(most don't support it and error message will no longer be printed).

I cannot apply it as it is (seems that -EPROBE_DEFER handling should
be audited/fixed in the affected drivers first).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
> While we're here, remove braces on if statements that only have one
> statement (manually).
>
> Cc: Bartlomiej Zolnierkiewicz <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
>
> Please apply directly to subsystem trees
>
> drivers/video/fbdev/atmel_lcdfb.c | 1 -
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 1 -
> drivers/video/fbdev/nuc900fb.c | 4 +---
> drivers/video/fbdev/pxa168fb.c | 4 +---
> drivers/video/fbdev/pxa3xx-gcu.c | 4 +---
> drivers/video/fbdev/pxafb.c | 1 -
> drivers/video/fbdev/s3c2410fb.c | 4 +---
> drivers/video/fbdev/vt8500lcdfb.c | 1 -
> 8 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
> index 5ff8e0320d95..4a16354d65c8 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
>
> sinfo->irq_base = platform_get_irq(pdev, 0);
> if (sinfo->irq_base < 0) {
> - dev_err(dev, "unable to get irq\n");
> ret = sinfo->irq_base;
> goto stop_clk;
> }
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> index 17174cd7a5bb..d6124976139b 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -447,7 +447,6 @@ static int mmphw_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "%s: no IRQ defined\n", __func__);
> ret = -ENOENT;
> goto failed;
> }
> diff --git a/drivers/video/fbdev/nuc900fb.c b/drivers/video/fbdev/nuc900fb.c
> index 4fd851598584..c4606c734f44 100644
> --- a/drivers/video/fbdev/nuc900fb.c
> +++ b/drivers/video/fbdev/nuc900fb.c
> @@ -526,10 +526,8 @@ static int nuc900fb_probe(struct platform_device *pdev)
> display = mach_info->displays + mach_info->default_display;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "no irq for device\n");
> + if (irq < 0)
> return -ENOENT;
> - }
>
> fbinfo = framebuffer_alloc(sizeof(struct nuc900fb_info), &pdev->dev);
> if (!fbinfo)
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index 1410f476e135..d9e5258503f0 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -625,10 +625,8 @@ static int pxa168fb_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "no IRQ defined\n");
> + if (irq < 0)
> return -ENOENT;
> - }
>
> info = framebuffer_alloc(sizeof(struct pxa168fb_info), &pdev->dev);
> if (info == NULL) {
> diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
> index 74ffb446e00c..07414d43cb3f 100644
> --- a/drivers/video/fbdev/pxa3xx-gcu.c
> +++ b/drivers/video/fbdev/pxa3xx-gcu.c
> @@ -614,10 +614,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
>
> /* request the IRQ */
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no IRQ defined: %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(dev, irq, pxa3xx_gcu_handle_irq,
> 0, DRV_NAME, priv);
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 4282cb117b92..b44f402ce552 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2353,7 +2353,6 @@ static int pxafb_probe(struct platform_device *dev)
>
> irq = platform_get_irq(dev, 0);
> if (irq < 0) {
> - dev_err(&dev->dev, "no IRQ defined\n");
> ret = -ENODEV;
> goto failed_free_mem;
> }
> diff --git a/drivers/video/fbdev/s3c2410fb.c b/drivers/video/fbdev/s3c2410fb.c
> index a702da89910b..2a846fd5da2a 100644
> --- a/drivers/video/fbdev/s3c2410fb.c
> +++ b/drivers/video/fbdev/s3c2410fb.c
> @@ -849,10 +849,8 @@ static int s3c24xxfb_probe(struct platform_device *pdev,
> display = mach_info->displays + mach_info->default_display;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "no irq for device\n");
> + if (irq < 0)
> return -ENOENT;
> - }
>
> fbinfo = framebuffer_alloc(sizeof(struct s3c2410fb_info), &pdev->dev);
> if (!fbinfo)
> diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> index be8d9702cbb2..a10088e1cdb0 100644
> --- a/drivers/video/fbdev/vt8500lcdfb.c
> +++ b/drivers/video/fbdev/vt8500lcdfb.c
> @@ -372,7 +372,6 @@ static int vt8500lcd_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "no IRQ defined\n");
> ret = -ENODEV;
> goto failed_free_palette;
> }