2021-05-07 15:07:22

by Krzysztof Kozlowski

Subject: [PATCH] reset: a10sr: add missing of_match_table reference

The driver defined of_device_id table but did not use it with
of_match_table. This prevents usual matching via devicetree and causes
a W=1 warning:

drivers/reset/reset-a10sr.c:111:34: warning:
‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]

Reported-by: kernel test robot <[email protected]>
Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/reset/reset-a10sr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
index 7eacc89382f8..99b3bc8382f3 100644
--- a/drivers/reset/reset-a10sr.c
+++ b/drivers/reset/reset-a10sr.c
@@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
.probe = a10sr_reset_probe,
.driver = {
.name = "altr_a10sr_reset",
+ .of_match_table = a10sr_reset_of_match,
},
};
module_platform_driver(a10sr_reset_driver);
--
2.25.1

2021-05-10 07:52:07

by Philipp Zabel

Subject: Re: [PATCH] reset: a10sr: add missing of_match_table reference

On Fri, 2021-05-07 at 07:28 -0400, Krzysztof Kozlowski wrote:
> The driver defined of_device_id table but did not use it with
> of_match_table. This prevents usual matching via devicetree and causes
> a W=1 warning:
>
> drivers/reset/reset-a10sr.c:111:34: warning:
> ‘a10sr_reset_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 627006820268 ("reset: Add Altera Arria10 SR Reset Controller")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/reset/reset-a10sr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-a10sr.c b/drivers/reset/reset-a10sr.c
> index 7eacc89382f8..99b3bc8382f3 100644
> --- a/drivers/reset/reset-a10sr.c
> +++ b/drivers/reset/reset-a10sr.c
> @@ -118,6 +118,7 @@ static struct platform_driver a10sr_reset_driver = {
> .probe = a10sr_reset_probe,
> .driver = {
> .name = "altr_a10sr_reset",
> + .of_match_table = a10sr_reset_of_match,
> },
> };
> module_platform_driver(a10sr_reset_driver);

Thank you, applied to reset/next.

regards
Philipp