2017-11-28 11:18:55

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v3 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

On 27/11/2017 13:57, Fabio Estevam wrote:
> On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
> <[email protected]> wrote:
>
>> +&pcie {
>> + fsl,tx-swing-full = <103>;
>> + fsl,tx-swing-low = <103>;
>> + reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>;
>
> This can only be active high if 'reset-gpio-active-high' property is
> present, so what you
> want here is:
> reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
>
> With this fixed:
>
> Reviewed-by: Fabio Estevam <[email protected]>
>

Ok,

I will post a v4 lately with this fixed.

Thanks,
Neil

From 1585224165669295706@xxx Mon Nov 27 12:59:32 +0000 2017
X-GM-THRID: 1585222352346496502
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread