2022-07-18 02:42:52

by Viresh Kumar

Subject: [PATCH] cpufreq: tegra194: Staticize struct tegra_cpufreq_soc instances

Fix sparse warnings by marking these structures static.

Fixes: 273bc890a2a8 ("cpufreq: tegra194: Add support for Tegra234")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/cpufreq/tegra194-cpufreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
index 2a6a98764a8c..1216046cf4c2 100644
--- a/drivers/cpufreq/tegra194-cpufreq.c
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -162,7 +162,7 @@ static struct tegra_cpufreq_ops tegra234_cpufreq_ops = {
.set_cpu_ndiv = tegra234_set_cpu_ndiv,
};

-const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
+static const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
.ops = &tegra234_cpufreq_ops,
.actmon_cntr_base = 0x9000,
.maxcpus_per_cluster = 4,
@@ -430,7 +430,7 @@ static struct tegra_cpufreq_ops tegra194_cpufreq_ops = {
.set_cpu_ndiv = tegra194_set_cpu_ndiv,
};

-const struct tegra_cpufreq_soc tegra194_cpufreq_soc = {
+static const struct tegra_cpufreq_soc tegra194_cpufreq_soc = {
.ops = &tegra194_cpufreq_ops,
.maxcpus_per_cluster = 2,
};
--
2.31.1.272.g89b43f80a514

2022-07-18 06:08:34

by Sumit Gupta

Subject: Re: [PATCH] cpufreq: tegra194: Staticize struct tegra_cpufreq_soc instances

On 18/07/22 07:35, Viresh Kumar wrote:
> External email: Use caution opening links or attachments
>
>
> Fix sparse warnings by marking these structures static.
>
> Fixes: 273bc890a2a8 ("cpufreq: tegra194: Add support for Tegra234")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Viresh Kumar <[email protected]>

Reviewed-by: Sumit Gupta <[email protected]>

> ---
> drivers/cpufreq/tegra194-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 2a6a98764a8c..1216046cf4c2 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -162,7 +162,7 @@ static struct tegra_cpufreq_ops tegra234_cpufreq_ops = {
> .set_cpu_ndiv = tegra234_set_cpu_ndiv,
> };
>
> -const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
> +static const struct tegra_cpufreq_soc tegra234_cpufreq_soc = {
> .ops = &tegra234_cpufreq_ops,
> .actmon_cntr_base = 0x9000,
> .maxcpus_per_cluster = 4,
> @@ -430,7 +430,7 @@ static struct tegra_cpufreq_ops tegra194_cpufreq_ops = {
> .set_cpu_ndiv = tegra194_set_cpu_ndiv,
> };
>
> -const struct tegra_cpufreq_soc tegra194_cpufreq_soc = {
> +static const struct tegra_cpufreq_soc tegra194_cpufreq_soc = {
> .ops = &tegra194_cpufreq_ops,
> .maxcpus_per_cluster = 2,
> };
> --
> 2.31.1.272.g89b43f80a514
>