2023-06-14 09:15:52

by baomingtong001

Subject: [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

Signed-off-by: Mingtong Bao <[email protected]>
---
tools/lib/bpf/zip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
index 3f26d629b2b4..88c376a8348d 100644
--- a/tools/lib/bpf/zip.c
+++ b/tools/lib/bpf/zip.c
@@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
*path)
if (!archive) {
munmap(data, size);
return ERR_PTR(-ENOMEM);
- };
+ }

archive->data = data;
archive->size = size;

2023-06-16 16:50:59

by Andrii Nakryiko

Subject: Re: [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()

On Wed, Jun 14, 2023 at 1:29 AM <[email protected]> wrote:
>
> ./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

This is not a very human-readable commit message. Something like

Drop unnecessary semicolon, which triggers (presumable coccicheck?) warning:

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon


But also this doesn't apply cleanly to bpf-next tree. Please rebase
and resend. Also make sure to have [PATCH bpf-next] prefix in email
subject. Thanks.

>
> Signed-off-by: Mingtong Bao <[email protected]>
> ---
> tools/lib/bpf/zip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
> index 3f26d629b2b4..88c376a8348d 100644
> --- a/tools/lib/bpf/zip.c
> +++ b/tools/lib/bpf/zip.c
> @@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
> *path)
> if (!archive) {
> munmap(data, size);
> return ERR_PTR(-ENOMEM);
> - };
> + }
>
> archive->data = data;
> archive->size = size;