A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
usage for /dev/kmsg") but should've been deleted before patch submission.
Although it doesn't cause any harm to the code or functionality itself, it's
totally unpleasant to have it displayed on every loop iteration with no real
use case. Thus remove it unconditionally.
Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
Signed-off-by: Bruno Meneguele <[email protected]>
---
net/bpfilter/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
index efea4874743e..05e1cfc1e5cd 100644
--- a/net/bpfilter/main.c
+++ b/net/bpfilter/main.c
@@ -35,7 +35,6 @@ static void loop(void)
struct mbox_reply reply;
int n;
- fprintf(debug_f, "testing the buffer\n");
n = read(0, &req, sizeof(req));
if (n != sizeof(req)) {
fprintf(debug_f, "invalid request %d\n", n);
--
2.25.1
From: Bruno Meneguele <[email protected]>
Date: Tue, 31 Mar 2020 10:06:30 -0300
> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
> usage for /dev/kmsg") but should've been deleted before patch submission.
> Although it doesn't cause any harm to the code or functionality itself, it's
> totally unpleasant to have it displayed on every loop iteration with no real
> use case. Thus remove it unconditionally.
>
> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
> Signed-off-by: Bruno Meneguele <[email protected]>
Applied, thanks.
On 3/31/20 7:08 PM, David Miller wrote:
> From: Bruno Meneguele <[email protected]>
> Date: Tue, 31 Mar 2020 10:06:30 -0300
>
>> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
>> usage for /dev/kmsg") but should've been deleted before patch submission.
>> Although it doesn't cause any harm to the code or functionality itself, it's
>> totally unpleasant to have it displayed on every loop iteration with no real
>> use case. Thus remove it unconditionally.
>>
>> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
>> Signed-off-by: Bruno Meneguele <[email protected]>
>
> Applied, thanks.
>
As the commit this fixes was included in a stable release (at least 5.4.29[0],
I did not checked others - sorry) it could make sense to backport this also
to the 5.4 stable tree?
Per documentation[1], I checked the netdev and Greg's queues, but did not found
it to be included anywhere yet.
I hope I handled this request somewhat correctly, please tell me if I should
propose the backported patch more directly to the respective stable list. As is,
the patch[2] applies fine here on top of 5.4.30.
cheers,
Thomas
[0]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.4.y&id=712c39d9319a864b74b44fd03b0e083afa2d8af2
[1]: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-can-i-tell-what-patches-are-queued-up-for-backporting-to-the-various-stable-releases
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/patch/?id=41c55ea6c2a7ca4c663eeec05bdf54f4e2419699