2022-06-17 11:25:25

by Kalpana Shetty

Subject: [PATCH V3] selftests/vm: Add protection_keys tests to run_vmtests

Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests
from a single shell script.

Signed-off-by: Kalpana Shetty <[email protected]>
---
Changes in V3:
Shuah Khan's review comments incorporated, added protection_keys binary check.

tools/testing/selftests/vm/run_vmtests.sh | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
index 41fce8bea929..b19c6b1b84c4 100755
--- a/tools/testing/selftests/vm/run_vmtests.sh
+++ b/tools/testing/selftests/vm/run_vmtests.sh
@@ -179,4 +179,15 @@ run_test ./ksm_tests -N -m 1
# KSM test with 2 NUMA nodes and merge_across_nodes = 0
run_test ./ksm_tests -N -m 0

+# protection_keys tests
+if ./protection_keys_32 &> /dev/null
+then
+ run_test ./protection_keys_32
+fi
+
+if ./protection_keys_64 &> /dev/null
+then
+ run_test ./protection_keys_64
+fi
+
exit $exitcode
--
2.25.1

2022-06-17 19:49:42

by Shuah Khan

Subject: Re: [PATCH V3] selftests/vm: Add protection_keys tests to run_vmtests

On 6/17/22 5:10 AM, Kalpana Shetty wrote:
> Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests
> from a single shell script.
>
> Signed-off-by: Kalpana Shetty <[email protected]>
> ---
> Changes in V3:
> Shuah Khan's review comments incorporated, added protection_keys binary check.
>
> tools/testing/selftests/vm/run_vmtests.sh | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
> index 41fce8bea929..b19c6b1b84c4 100755
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -179,4 +179,15 @@ run_test ./ksm_tests -N -m 1
> # KSM test with 2 NUMA nodes and merge_across_nodes = 0
> run_test ./ksm_tests -N -m 0
>
> +# protection_keys tests
> +if ./protection_keys_32 &> /dev/null
> +then
> + run_test ./protection_keys_32
> +fi
> +
> +if ./protection_keys_64 &> /dev/null
> +then
> + run_test ./protection_keys_64
> +fi
> +
> exit $exitcode
>

Why not use file test operators. -x works for this case.
There is no need to run attempt to run the test.

thanks,
-- Shuah

2022-06-17 20:35:31

by Kalpana Shetty

Subject: Re: [PATCH V3] selftests/vm: Add protection_keys tests to run_vmtests

On 6/18/2022 1:01 AM, Shuah Khan wrote:
> On 6/17/22 5:10 AM, Kalpana Shetty wrote:
>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to
>> run all VM related tests
>> from a single shell script.
>>
>> Signed-off-by: Kalpana Shetty <[email protected]>
>> ---
>> Changes in V3:
>>   Shuah Khan's review comments incorporated, added protection_keys
>> binary check.
>>
>>   tools/testing/selftests/vm/run_vmtests.sh | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/tools/testing/selftests/vm/run_vmtests.sh
>> b/tools/testing/selftests/vm/run_vmtests.sh
>> index 41fce8bea929..b19c6b1b84c4 100755
>> --- a/tools/testing/selftests/vm/run_vmtests.sh
>> +++ b/tools/testing/selftests/vm/run_vmtests.sh
>> @@ -179,4 +179,15 @@ run_test ./ksm_tests -N -m 1
>>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>>   run_test ./ksm_tests -N -m 0
>>   +# protection_keys tests
>> +if ./protection_keys_32 &> /dev/null
>> +then
>> +    run_test ./protection_keys_32
>> +fi
>> +
>> +if ./protection_keys_64 &> /dev/null
>> +then
>> +    run_test ./protection_keys_64
>> +fi
>> +
>>   exit $exitcode
>>
>
> Why not use file test operators. -x works for this case.
> There is no need to run attempt to run the test.
Sure; thanks for the suggestion. Sent V4 patch.
>
> thanks,
> -- Shuah

Thanks,

Kalpana