Later we're going to try the self-contained image verification.
The current superblock checksum feature has quite limited
functionality, instead, merkle trees can provide better protection
for image integrity.
xxhash is also used in the following xattr name filter feature. It is
redundant for one filesystem to rely on two hashing algorithms at the
same time.
Since the superblock checksum is a compatible feature, just deprecate
it now.
Signed-off-by: Jingbo Xu <[email protected]>
---
changes since v1:
- improve commit message (Gao Xiang)
v1: https://lore.kernel.org/all/[email protected]/
---
fs/erofs/Kconfig | 1 -
fs/erofs/super.c | 44 +++++---------------------------------------
2 files changed, 5 insertions(+), 40 deletions(-)
diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
index f259d92c9720..ebcb1f6a426a 100644
--- a/fs/erofs/Kconfig
+++ b/fs/erofs/Kconfig
@@ -4,7 +4,6 @@ config EROFS_FS
tristate "EROFS filesystem support"
depends on BLOCK
select FS_IOMAP
- select LIBCRC32C
help
EROFS (Enhanced Read-Only File System) is a lightweight read-only
file system with modern designs (e.g. no buffer heads, inline
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 9d6a3c6158bd..bb6a966ac4d4 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -8,7 +8,6 @@
#include <linux/statfs.h>
#include <linux/parser.h>
#include <linux/seq_file.h>
-#include <linux/crc32c.h>
#include <linux/fs_context.h>
#include <linux/fs_parser.h>
#include <linux/dax.h>
@@ -51,33 +50,6 @@ void _erofs_info(struct super_block *sb, const char *function,
va_end(args);
}
-static int erofs_superblock_csum_verify(struct super_block *sb, void *sbdata)
-{
- size_t len = 1 << EROFS_SB(sb)->blkszbits;
- struct erofs_super_block *dsb;
- u32 expected_crc, crc;
-
- if (len > EROFS_SUPER_OFFSET)
- len -= EROFS_SUPER_OFFSET;
-
- dsb = kmemdup(sbdata + EROFS_SUPER_OFFSET, len, GFP_KERNEL);
- if (!dsb)
- return -ENOMEM;
-
- expected_crc = le32_to_cpu(dsb->checksum);
- dsb->checksum = 0;
- /* to allow for x86 boot sectors and other oddities. */
- crc = crc32c(~0, dsb, len);
- kfree(dsb);
-
- if (crc != expected_crc) {
- erofs_err(sb, "invalid checksum 0x%08x, 0x%08x expected",
- crc, expected_crc);
- return -EBADMSG;
- }
- return 0;
-}
-
static void erofs_inode_init_once(void *ptr)
{
struct erofs_inode *vi = ptr;
@@ -113,15 +85,16 @@ static void erofs_free_inode(struct inode *inode)
static bool check_layout_compatibility(struct super_block *sb,
struct erofs_super_block *dsb)
{
- const unsigned int feature = le32_to_cpu(dsb->feature_incompat);
+ struct erofs_sb_info *sbi = EROFS_SB(sb);
- EROFS_SB(sb)->feature_incompat = feature;
+ sbi->feature_compat = le32_to_cpu(dsb->feature_compat);
+ sbi->feature_incompat = le32_to_cpu(dsb->feature_incompat);
/* check if current kernel meets all mandatory requirements */
- if (feature & (~EROFS_ALL_FEATURE_INCOMPAT)) {
+ if (sbi->feature_incompat & (~EROFS_ALL_FEATURE_INCOMPAT)) {
erofs_err(sb,
"unidentified incompatible feature %x, please upgrade kernel version",
- feature & ~EROFS_ALL_FEATURE_INCOMPAT);
+ sbi->feature_incompat & ~EROFS_ALL_FEATURE_INCOMPAT);
return false;
}
return true;
@@ -365,13 +338,6 @@ static int erofs_read_superblock(struct super_block *sb)
goto out;
}
- sbi->feature_compat = le32_to_cpu(dsb->feature_compat);
- if (erofs_sb_has_sb_chksum(sbi)) {
- ret = erofs_superblock_csum_verify(sb, data);
- if (ret)
- goto out;
- }
-
ret = -EINVAL;
if (!check_layout_compatibility(sb, dsb))
goto out;
--
2.19.1.6.gb485710b
On 2023/7/17 19:27, Jingbo Xu wrote:
> Later we're going to try the self-contained image verification.
> The current superblock checksum feature has quite limited
> functionality, instead, merkle trees can provide better protection
> for image integrity.
>
> xxhash is also used in the following xattr name filter feature. It is
> redundant for one filesystem to rely on two hashing algorithms at the
> same time.
>
> Since the superblock checksum is a compatible feature, just deprecate
> it now.
>
> Signed-off-by: Jingbo Xu <[email protected]>
I tend to agree on this since it slightly impacts mount time too:
Reviewed-by: Gao Xiang <[email protected]>
Thanks,
Gao Xiang
On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
> Later we're going to try the self-contained image verification.
> The current superblock checksum feature has quite limited
> functionality, instead, merkle trees can provide better protection
> for image integrity.
The crc32c checksum is also used by libblkid to gain more confidence
in its filesystem detection.
I guess a merkle tree would be much harder to implement.
This is for example used by the mount(8) cli program to allow mounting
of devices without explicitly needing to specify a filesystem.
Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
break when the checksum is removed.
> xxhash is also used in the following xattr name filter feature. It is
> redundant for one filesystem to rely on two hashing algorithms at the
> same time.
>
> Since the superblock checksum is a compatible feature, just deprecate
> it now.
>
> Signed-off-by: Jingbo Xu <[email protected]>
> ---
> changes since v1:
> - improve commit message (Gao Xiang)
>
> v1: https://lore.kernel.org/all/[email protected]/
> ---
> fs/erofs/Kconfig | 1 -
> fs/erofs/super.c | 44 +++++---------------------------------------
> 2 files changed, 5 insertions(+), 40 deletions(-)
> [..]
On 2023/7/17 19:27, Jingbo Xu wrote:
> Later we're going to try the self-contained image verification.
> The current superblock checksum feature has quite limited
> functionality, instead, merkle trees can provide better protection
> for image integrity.
>
> xxhash is also used in the following xattr name filter feature. It is
> redundant for one filesystem to rely on two hashing algorithms at the
> same time.
>
> Since the superblock checksum is a compatible feature, just deprecate
> it now.
>
> Signed-off-by: Jingbo Xu <[email protected]>
Reviewed-by: Chao Yu <[email protected]>
Thanks,
Hi Thomas,
On 2023/7/30 21:31, Thomas Weißschuh wrote:
> On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
>> Later we're going to try the self-contained image verification.
>> The current superblock checksum feature has quite limited
>> functionality, instead, merkle trees can provide better protection
>> for image integrity.
>
> The crc32c checksum is also used by libblkid to gain more confidence
> in its filesystem detection.
> I guess a merkle tree would be much harder to implement.
>
> This is for example used by the mount(8) cli program to allow mounting
> of devices without explicitly needing to specify a filesystem.
>
> Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
> break when the checksum is removed.
I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
checksum instead (e.g. just sum each byte up if both
EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
ignore checksums completely at least in the kernel) if the better
filesystem detection by using sb chksum is needed (not sure if other
filesystems have sb chksum or just do magic comparsion)?
The main problem here is after xattr name filter feature is added
(xxhash is generally faster than crc32c), there could be two
hard-depended hashing algorithms, this increases more dependency
especially for embededed devices.
Thanks,
Gao Xiang
On 2023/7/30 22:49, Thomas Weißschuh wrote:
> On 2023-07-30 22:37:19+0800, Gao Xiang wrote:
>> On 2023/7/30 22:28, Thomas Weißschuh wrote:
>>> On 2023-07-30 22:01:11+0800, Gao Xiang wrote:
>>>> On 2023/7/30 21:31, Thomas Weißschuh wrote:
>>>>> On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
>>>>>> Later we're going to try the self-contained image verification.
>>>>>> The current superblock checksum feature has quite limited
>>>>>> functionality, instead, merkle trees can provide better protection
>>>>>> for image integrity.
>>>>>
>>>>> The crc32c checksum is also used by libblkid to gain more confidence
>>>>> in its filesystem detection.
>>>>> I guess a merkle tree would be much harder to implement.
>>>>>
>>>>> This is for example used by the mount(8) cli program to allow mounting
>>>>> of devices without explicitly needing to specify a filesystem.
>>>>>
>>>>> Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
>>>>> break when the checksum is removed.
>>>
>>>> I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
>>>> checksum instead (e.g. just sum each byte up if both
>>>> EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
>>>> ignore checksums completely at least in the kernel) if the better
>>>> filesystem detection by using sb chksum is needed (not sure if other
>>>> filesystems have sb chksum or just do magic comparsion)?
>>>
>>> Overloading EROFS_FEATURE_SB_CSUM in combination with
>>> COMPAT_XATTR_FILTER would break all existing deployments of libblkid, so
>>> it's not an option.
>>
>> I think for libblkid, you could still use:
>> EROFS_FEATURE_SB_CSUM is not set, don't check anything;
>> EROFS_FEATURE_SB_CSUM only is set, check with crc32c;
>> EROFS_FEATURE_SB_CSUM | COMPAT_XATTR_FILTER (or some other bit) is
>> set, check with a simpler hash?
>
> We could change this in newer versions of libblkid.
> But we can't change the older versions that are already deployed today.
>
> And the current code does
>
> if (EROFS_FEATURE_SB_CSUM)
> validate_crc32c();
>
> So to stay compatible we need to keep the relationship of
> EROFS_FEATURE_SB_CSUM -> crc32c.
Yes, you are right, thanks for reminder. We really need a new bit
for this.
>
>>> All other serious and halfway modern filesystems do have superblock
>>> checksums which are also checked by libblkid.
>>>
>>>> The main problem here is after xattr name filter feature is added
>>>> (xxhash is generally faster than crc32c), there could be two
>>>> hard-depended hashing algorithms, this increases more dependency
>>>> especially for embededed devices.
>>>
>>> From libblkid side nothing really speaks against a simpler checksum.
>>> XOR is easy to implement and xxhash is already part of libblkid for
>>> other filesystems.
>>>
>>> The drawbacks are:
>>> * It would need a completely new feature bit in erofs.
>>> * Old versions of libblkid could not validate checksums on newer
>>> filesystems.
>>
>> just checking magic for Old versions of libblkid will cause false
>> positive in which extent?
>
> Hard to tell for sure. But it would not surprise me if it would indeed
> affect users as experience has shown.
>
> Imagine for example erofs filesystems that have then been overwritten
> with another filesystem but still have a valid erofs magic.
> With the checksum validation the new filesystem is detected correctly,
> without it will find the old erofs.
>
> Sometimes the files inside some filesystem look like the superblock of
> another filesystem and break the detection.
>
> etc.
>
> Having some sort of checksum makes this much easier to handle.
Yes, but just checking magic for old versions of libblkid for new
generated images only.
I'm not sure about this all (I just suggest that we might need a simpler
algorithm like XOR instead for sb_chksum otherwise it seems too heavy),
let me just drop this commit from -next for further discussion.
Thanks,
Gao Xiang
On 2023/7/30 22:28, Thomas Weißschuh wrote:
> Hi Gao!
>
> On 2023-07-30 22:01:11+0800, Gao Xiang wrote:
>> On 2023/7/30 21:31, Thomas Weißschuh wrote:
>>> On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
>>>> Later we're going to try the self-contained image verification.
>>>> The current superblock checksum feature has quite limited
>>>> functionality, instead, merkle trees can provide better protection
>>>> for image integrity.
>>>
>>> The crc32c checksum is also used by libblkid to gain more confidence
>>> in its filesystem detection.
>>> I guess a merkle tree would be much harder to implement.
>>>
>>> This is for example used by the mount(8) cli program to allow mounting
>>> of devices without explicitly needing to specify a filesystem.
>>>
>>> Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
>>> break when the checksum is removed.
>
>> I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
>> checksum instead (e.g. just sum each byte up if both
>> EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
>> ignore checksums completely at least in the kernel) if the better
>> filesystem detection by using sb chksum is needed (not sure if other
>> filesystems have sb chksum or just do magic comparsion)?
>
> Overloading EROFS_FEATURE_SB_CSUM in combination with
> COMPAT_XATTR_FILTER would break all existing deployments of libblkid, so
> it's not an option.
I think for libblkid, you could still use:
EROFS_FEATURE_SB_CSUM is not set, don't check anything;
EROFS_FEATURE_SB_CSUM only is set, check with crc32c;
EROFS_FEATURE_SB_CSUM | COMPAT_XATTR_FILTER (or some other bit) is
set, check with a simpler hash?
>
> All other serious and halfway modern filesystems do have superblock
> checksums which are also checked by libblkid.
>
>> The main problem here is after xattr name filter feature is added
>> (xxhash is generally faster than crc32c), there could be two
>> hard-depended hashing algorithms, this increases more dependency
>> especially for embededed devices.
>
> From libblkid side nothing really speaks against a simpler checksum.
> XOR is easy to implement and xxhash is already part of libblkid for
> other filesystems.
>
> The drawbacks are:
> * It would need a completely new feature bit in erofs.
> * Old versions of libblkid could not validate checksums on newer
> filesystems.
just checking magic for Old versions of libblkid will cause false
positive in which extent?
Thanks,
Gao Xiang
On 2023-07-30 22:37:19+0800, Gao Xiang wrote:
> On 2023/7/30 22:28, Thomas Weißschuh wrote:
> > On 2023-07-30 22:01:11+0800, Gao Xiang wrote:
> > > On 2023/7/30 21:31, Thomas Weißschuh wrote:
> > > > On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
> > > > > Later we're going to try the self-contained image verification.
> > > > > The current superblock checksum feature has quite limited
> > > > > functionality, instead, merkle trees can provide better protection
> > > > > for image integrity.
> > > >
> > > > The crc32c checksum is also used by libblkid to gain more confidence
> > > > in its filesystem detection.
> > > > I guess a merkle tree would be much harder to implement.
> > > >
> > > > This is for example used by the mount(8) cli program to allow mounting
> > > > of devices without explicitly needing to specify a filesystem.
> > > >
> > > > Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
> > > > break when the checksum is removed.
> >
> > > I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
> > > checksum instead (e.g. just sum each byte up if both
> > > EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
> > > ignore checksums completely at least in the kernel) if the better
> > > filesystem detection by using sb chksum is needed (not sure if other
> > > filesystems have sb chksum or just do magic comparsion)?
> >
> > Overloading EROFS_FEATURE_SB_CSUM in combination with
> > COMPAT_XATTR_FILTER would break all existing deployments of libblkid, so
> > it's not an option.
>
> I think for libblkid, you could still use:
> EROFS_FEATURE_SB_CSUM is not set, don't check anything;
> EROFS_FEATURE_SB_CSUM only is set, check with crc32c;
> EROFS_FEATURE_SB_CSUM | COMPAT_XATTR_FILTER (or some other bit) is
> set, check with a simpler hash?
We could change this in newer versions of libblkid.
But we can't change the older versions that are already deployed today.
And the current code does
if (EROFS_FEATURE_SB_CSUM)
validate_crc32c();
So to stay compatible we need to keep the relationship of
EROFS_FEATURE_SB_CSUM -> crc32c.
> > All other serious and halfway modern filesystems do have superblock
> > checksums which are also checked by libblkid.
> >
> > > The main problem here is after xattr name filter feature is added
> > > (xxhash is generally faster than crc32c), there could be two
> > > hard-depended hashing algorithms, this increases more dependency
> > > especially for embededed devices.
> >
> > From libblkid side nothing really speaks against a simpler checksum.
> > XOR is easy to implement and xxhash is already part of libblkid for
> > other filesystems.
> >
> > The drawbacks are:
> > * It would need a completely new feature bit in erofs.
> > * Old versions of libblkid could not validate checksums on newer
> > filesystems.
>
> just checking magic for Old versions of libblkid will cause false
> positive in which extent?
Hard to tell for sure. But it would not surprise me if it would indeed
affect users as experience has shown.
Imagine for example erofs filesystems that have then been overwritten
with another filesystem but still have a valid erofs magic.
With the checksum validation the new filesystem is detected correctly,
without it will find the old erofs.
Sometimes the files inside some filesystem look like the superblock of
another filesystem and break the detection.
etc.
Having some sort of checksum makes this much easier to handle.
Hi Gao!
On 2023-07-30 22:01:11+0800, Gao Xiang wrote:
> On 2023/7/30 21:31, Thomas Weißschuh wrote:
> > On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
> > > Later we're going to try the self-contained image verification.
> > > The current superblock checksum feature has quite limited
> > > functionality, instead, merkle trees can provide better protection
> > > for image integrity.
> >
> > The crc32c checksum is also used by libblkid to gain more confidence
> > in its filesystem detection.
> > I guess a merkle tree would be much harder to implement.
> >
> > This is for example used by the mount(8) cli program to allow mounting
> > of devices without explicitly needing to specify a filesystem.
> >
> > Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
> > break when the checksum is removed.
> I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
> checksum instead (e.g. just sum each byte up if both
> EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
> ignore checksums completely at least in the kernel) if the better
> filesystem detection by using sb chksum is needed (not sure if other
> filesystems have sb chksum or just do magic comparsion)?
Overloading EROFS_FEATURE_SB_CSUM in combination with
COMPAT_XATTR_FILTER would break all existing deployments of libblkid, so
it's not an option.
All other serious and halfway modern filesystems do have superblock
checksums which are also checked by libblkid.
> The main problem here is after xattr name filter feature is added
> (xxhash is generally faster than crc32c), there could be two
> hard-depended hashing algorithms, this increases more dependency
> especially for embededed devices.
From libblkid side nothing really speaks against a simpler checksum.
XOR is easy to implement and xxhash is already part of libblkid for
other filesystems.
The drawbacks are:
* It would need a completely new feature bit in erofs.
* Old versions of libblkid could not validate checksums on newer
filesystems.
Hi, Thomas,
On 7/30/23 10:28 PM, Thomas Weißschuh wrote:
> Hi Gao!
>
> On 2023-07-30 22:01:11+0800, Gao Xiang wrote:
>> On 2023/7/30 21:31, Thomas Weißschuh wrote:
>>> On 2023-07-17 19:27:03+0800, Jingbo Xu wrote:
>>>> Later we're going to try the self-contained image verification.
>>>> The current superblock checksum feature has quite limited
>>>> functionality, instead, merkle trees can provide better protection
>>>> for image integrity.
>>>
>>> The crc32c checksum is also used by libblkid to gain more confidence
>>> in its filesystem detection.
>>> I guess a merkle tree would be much harder to implement.
>>>
>>> This is for example used by the mount(8) cli program to allow mounting
>>> of devices without explicitly needing to specify a filesystem.
>>>
>>> Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't
>>> break when the checksum is removed.
>
>> I'm not sure if we could switch EROFS_FEATURE_SB_CSUM to a simpler
>> checksum instead (e.g. just sum each byte up if both
>> EROFS_FEATURE_SB_CSUM and COMPAT_XATTR_FILTER bits are set, or
>> ignore checksums completely at least in the kernel) if the better
>> filesystem detection by using sb chksum is needed (not sure if other
>> filesystems have sb chksum or just do magic comparsion)?
>
> Overloading EROFS_FEATURE_SB_CSUM in combination with
> COMPAT_XATTR_FILTER would break all existing deployments of libblkid, so
> it's not an option.
>
> All other serious and halfway modern filesystems do have superblock
> checksums which are also checked by libblkid.
>
>> The main problem here is after xattr name filter feature is added
>> (xxhash is generally faster than crc32c), there could be two
>> hard-depended hashing algorithms, this increases more dependency
>> especially for embededed devices.
>
> From libblkid side nothing really speaks against a simpler checksum.
> XOR is easy to implement and xxhash is already part of libblkid for
> other filesystems.
>
> The drawbacks are:
> * It would need a completely new feature bit in erofs.
> * Old versions of libblkid could not validate checksums on newer
> filesystems.
Thanks for pointing this out. we indeed need further discussion for a
better solution.
As mentioned previously, we don't want two hashing algorithms dependency
for erofs. The best idea as far as I can come up with is that,
introduce a new feature bit indicating XOR hashing algorithm for the sb
checksum, while the original EROFS_FEATURE_SB_CSUM is not set. As for
the old version libblkid, only fs magic is available for the fs type
detection, not perfect but in a best-effort way.
--
Thanks,
Jingbo