The following patches enable configs in the arm64 defconfig to support
GPIO and I2C support on TI's J721e platform.
Faiz Abbas (2):
arm64: defconfig: Enable OMAP I2C driver
arm64: defconfig: Enable DAVINCI_GPIO driver
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
--
2.17.1
Enable support for devices compatible with TI's OMAP I2C controllers.
Signed-off-by: Faiz Abbas <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 55f9c35568bf..0d5b81264fa1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -437,6 +437,7 @@ CONFIG_I2C_IMX=y
CONFIG_I2C_IMX_LPI2C=y
CONFIG_I2C_MESON=y
CONFIG_I2C_MV64XXX=y
+CONFIG_I2C_OMAP=y
CONFIG_I2C_OWL=y
CONFIG_I2C_PXA=y
CONFIG_I2C_QCOM_CCI=m
--
2.17.1
Enable support for devices compatible with TI's davinci gpio controllers.
Signed-off-by: Faiz Abbas <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 0d5b81264fa1..c4b657644e33 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -497,6 +497,7 @@ CONFIG_PINCTRL_SDM845=y
CONFIG_PINCTRL_SM8150=y
CONFIG_PINCTRL_SM8250=y
CONFIG_GPIO_ALTERA=m
+CONFIG_GPIO_DAVINCI=y
CONFIG_GPIO_DWAPB=y
CONFIG_GPIO_MB86S7X=y
CONFIG_GPIO_MPC8XXX=y
--
2.17.1
On 22:15-20201002, Faiz Abbas wrote:
> The following patches enable configs in the arm64 defconfig to support
> GPIO and I2C support on TI's J721e platform.
>
> Faiz Abbas (2):
> arm64: defconfig: Enable OMAP I2C driver
> arm64: defconfig: Enable DAVINCI_GPIO driver
>
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
Could we do an audit and make sure nothing else is missing - Say ALSA /
DRM or something else?
And I don't really see the need to split these into individual patches,
maybe, take a hint from [1]
[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Nishanth,
On 02/10/20 10:32 pm, Nishanth Menon wrote:
> On 22:15-20201002, Faiz Abbas wrote:
>> The following patches enable configs in the arm64 defconfig to support
>> GPIO and I2C support on TI's J721e platform.
>>
>> Faiz Abbas (2):
>> arm64: defconfig: Enable OMAP I2C driver
>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>
>> arch/arm64/configs/defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>
>
> Could we do an audit and make sure nothing else is missing - Say ALSA /
> DRM or something else?
I'm not aware of anything that might be missing. That said, I am not
aware of every single config in every subsystem. IMO the various driver
owners should be responsible for adding their configs to defconfig.
>
> And I don't really see the need to split these into individual patches,
> maybe, take a hint from [1]
>
>
> [1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
Sounds good. I'll squash into a single patch and repost.
Thanks,
Faiz
On 02/10/2020 19:45, Faiz Abbas wrote:
> The following patches enable configs in the arm64 defconfig to support
> GPIO and I2C support on TI's J721e platform.
>
> Faiz Abbas (2):
> arm64: defconfig: Enable OMAP I2C driver
> arm64: defconfig: Enable DAVINCI_GPIO driver
>
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
Why are you enabling these?
Are they required for booting the board?
If not, they shall not be enabled, as it just clutters the arm64
defconfig unnecessarily.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Tero,
On 06/10/20 5:21 pm, Tero Kristo wrote:
> On 02/10/2020 19:45, Faiz Abbas wrote:
>> The following patches enable configs in the arm64 defconfig to support
>> GPIO and I2C support on TI's J721e platform.
>>
>> Faiz Abbas (2):
>> arm64: defconfig: Enable OMAP I2C driver
>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>
>> arch/arm64/configs/defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> Why are you enabling these?
>
> Are they required for booting the board?
>
> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>
They are required because the SD card regulators need gpio over i2c expander and also
soc gpio support to come up in UHS modes.
But in general isn't any feature we add supposed to be enabled in the arm64 defconfig?
Thanks,
Faiz
On 06/10/2020 16:03, Faiz Abbas wrote:
> Hi Tero,
>
> On 06/10/20 5:21 pm, Tero Kristo wrote:
>> On 02/10/2020 19:45, Faiz Abbas wrote:
>>> The following patches enable configs in the arm64 defconfig to support
>>> GPIO and I2C support on TI's J721e platform.
>>>
>>> Faiz Abbas (2):
>>> arm64: defconfig: Enable OMAP I2C driver
>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>
>>> arch/arm64/configs/defconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>
>> Why are you enabling these?
>>
>> Are they required for booting the board?
>>
>> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>>
>
> They are required because the SD card regulators need gpio over i2c expander and also
> soc gpio support to come up in UHS modes.
Is that needed for boot support? If it is only needed with UHS cards,
that does not seem important enough for me. We can already boot the
board via other means.
>
> But in general isn't any feature we add supposed to be enabled in the arm64 defconfig?
That is debatable, as it just increases the kernel size / build time for
everybody. Personally I would merge only things that are absolutely
necessary, for everything else we can just do local config modifications.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Tero,
On 06/10/20 6:40 pm, Tero Kristo wrote:
> On 06/10/2020 16:03, Faiz Abbas wrote:
>> Hi Tero,
>>
>> On 06/10/20 5:21 pm, Tero Kristo wrote:
>>> On 02/10/2020 19:45, Faiz Abbas wrote:
>>>> The following patches enable configs in the arm64 defconfig to support
>>>> GPIO and I2C support on TI's J721e platform.
>>>>
>>>> Faiz Abbas (2):
>>>> arm64: defconfig: Enable OMAP I2C driver
>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>
>>>> arch/arm64/configs/defconfig | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>
>>> Why are you enabling these?
>>>
>>> Are they required for booting the board?
>>>
>>> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>>>
>>
>> They are required because the SD card regulators need gpio over i2c expander and also
>> soc gpio support to come up in UHS modes.
>
> Is that needed for boot support? If it is only needed with UHS cards, that does not seem important enough for me. We can already boot the board via other means.
Without these configs, the regulator drivers keep EPROBE_DEFERing waiting for their gpio drivers
to probe and SD card never comes up. This configuration happens before any UHS capabilities are detected.
[ 1.326654] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
[ 1.333651] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
[ 1.340693] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
[ 1.489088] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
[ 1.496067] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
[ 1.510392] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
[ 1.543210] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
[ 1.550186] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
[ 1.568134] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
Thanks,
Faiz
On 08/10/2020 11:59, Faiz Abbas wrote:
> Tero,
>
> On 06/10/20 6:40 pm, Tero Kristo wrote:
>> On 06/10/2020 16:03, Faiz Abbas wrote:
>>> Hi Tero,
>>>
>>> On 06/10/20 5:21 pm, Tero Kristo wrote:
>>>> On 02/10/2020 19:45, Faiz Abbas wrote:
>>>>> The following patches enable configs in the arm64 defconfig to support
>>>>> GPIO and I2C support on TI's J721e platform.
>>>>>
>>>>> Faiz Abbas (2):
>>>>> arm64: defconfig: Enable OMAP I2C driver
>>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>>
>>>>> arch/arm64/configs/defconfig | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>
>>>> Why are you enabling these?
>>>>
>>>> Are they required for booting the board?
>>>>
>>>> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>>>>
>>>
>>> They are required because the SD card regulators need gpio over i2c expander and also
>>> soc gpio support to come up in UHS modes.
>>
>> Is that needed for boot support? If it is only needed with UHS cards, that does not seem important enough for me. We can already boot the board via other means.
>
> Without these configs, the regulator drivers keep EPROBE_DEFERing waiting for their gpio drivers
> to probe and SD card never comes up. This configuration happens before any UHS capabilities are detected.
>
> [ 1.326654] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
> [ 1.333651] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
> [ 1.340693] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
> [ 1.489088] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
> [ 1.496067] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
> [ 1.510392] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
> [ 1.543210] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
> [ 1.550186] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
> [ 1.568134] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
This happens because you have merged/enabled UHS support or? This sounds
like a regression as I haven't seen this happen before.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Tero,
On 08/10/20 2:49 pm, Tero Kristo wrote:
> On 08/10/2020 11:59, Faiz Abbas wrote:
>> Tero,
>>
>> On 06/10/20 6:40 pm, Tero Kristo wrote:
>>> On 06/10/2020 16:03, Faiz Abbas wrote:
>>>> Hi Tero,
>>>>
>>>> On 06/10/20 5:21 pm, Tero Kristo wrote:
>>>>> On 02/10/2020 19:45, Faiz Abbas wrote:
>>>>>> The following patches enable configs in the arm64 defconfig to support
>>>>>> GPIO and I2C support on TI's J721e platform.
>>>>>>
>>>>>> Faiz Abbas (2):
>>>>>> arm64: defconfig: Enable OMAP I2C driver
>>>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>>>
>>>>>> arch/arm64/configs/defconfig | 2 ++
>>>>>> 1 file changed, 2 insertions(+)
>>>>>>
>>>>>
>>>>> Why are you enabling these?
>>>>>
>>>>> Are they required for booting the board?
>>>>>
>>>>> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>>>>>
>>>>
>>>> They are required because the SD card regulators need gpio over i2c expander and also
>>>> soc gpio support to come up in UHS modes.
>>>
>>> Is that needed for boot support? If it is only needed with UHS cards, that does not seem important enough for me. We can already boot the board via other means.
>>
>> Without these configs, the regulator drivers keep EPROBE_DEFERing waiting for their gpio drivers
>> to probe and SD card never comes up. This configuration happens before any UHS capabilities are detected.
>>
>> [ 1.326654] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>> [ 1.333651] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>> [ 1.340693] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>> [ 1.489088] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>> [ 1.496067] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>> [ 1.510392] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>> [ 1.543210] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>> [ 1.550186] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>> [ 1.568134] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>
> This happens because you have merged/enabled UHS support or? This sounds like a regression as I haven't seen this happen before.
>
Thats right. The EPROBE_DEFERs will happen if my patches enabling UHS modes here are merged. I need to repost them for v5.11-rc1:
https://lore.kernel.org/linux-arm-kernel/[email protected]/
Thanks,
Faiz
On 08/10/2020 12:40, Faiz Abbas wrote:
> Tero,
>
> On 08/10/20 2:49 pm, Tero Kristo wrote:
>> On 08/10/2020 11:59, Faiz Abbas wrote:
>>> Tero,
>>>
>>> On 06/10/20 6:40 pm, Tero Kristo wrote:
>>>> On 06/10/2020 16:03, Faiz Abbas wrote:
>>>>> Hi Tero,
>>>>>
>>>>> On 06/10/20 5:21 pm, Tero Kristo wrote:
>>>>>> On 02/10/2020 19:45, Faiz Abbas wrote:
>>>>>>> The following patches enable configs in the arm64 defconfig to support
>>>>>>> GPIO and I2C support on TI's J721e platform.
>>>>>>>
>>>>>>> Faiz Abbas (2):
>>>>>>> arm64: defconfig: Enable OMAP I2C driver
>>>>>>> arm64: defconfig: Enable DAVINCI_GPIO driver
>>>>>>>
>>>>>>> arch/arm64/configs/defconfig | 2 ++
>>>>>>> 1 file changed, 2 insertions(+)
>>>>>>>
>>>>>>
>>>>>> Why are you enabling these?
>>>>>>
>>>>>> Are they required for booting the board?
>>>>>>
>>>>>> If not, they shall not be enabled, as it just clutters the arm64 defconfig unnecessarily.
>>>>>>
>>>>>
>>>>> They are required because the SD card regulators need gpio over i2c expander and also
>>>>> soc gpio support to come up in UHS modes.
>>>>
>>>> Is that needed for boot support? If it is only needed with UHS cards, that does not seem important enough for me. We can already boot the board via other means.
>>>
>>> Without these configs, the regulator drivers keep EPROBE_DEFERing waiting for their gpio drivers
>>> to probe and SD card never comes up. This configuration happens before any UHS capabilities are detected.
>>>
>>> [ 1.326654] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>>> [ 1.333651] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>>> [ 1.340693] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>>> [ 1.489088] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>>> [ 1.496067] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>>> [ 1.510392] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>>> [ 1.543210] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vmmc ret:-517
>>> [ 1.550186] sdhci-am654 4fb0000.sdhci: _devm_regulator_get id:vqmmc ret:-517
>>> [ 1.568134] sdhci-am654 4fb0000.sdhci: sdhci_am654_probe ret:-517
>>
>> This happens because you have merged/enabled UHS support or? This sounds like a regression as I haven't seen this happen before.
>>
>
> Thats right. The EPROBE_DEFERs will happen if my patches enabling UHS modes here are merged. I need to repost them for v5.11-rc1:
> https://lore.kernel.org/linux-arm-kernel/[email protected]/
Ok I think that would be good enough reason to enable these by default
as the MMC as boot media won't work anymore without them, and carrying
the DTS patches would be just silly.
Acked-by: Tero Kristo <[email protected]>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 14:06-20201008, Tero Kristo wrote:
> On 08/10/2020 12:40, Faiz Abbas wrote:
[...]
> > Thats right. The EPROBE_DEFERs will happen if my patches enabling UHS modes here are merged. I need to repost them for v5.11-rc1:
> > https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> Ok I think that would be good enough reason to enable these by default as
> the MMC as boot media won't work anymore without them, and carrying the DTS
> patches would be just silly.
>
> Acked-by: Tero Kristo <[email protected]>
I still think we could squash the patches and explain in the commit message the
rationale for adding these in.
"Enable support for devices compatible with TI's davinci gpio
controllers." Does'nt quite explain the severity of the patches.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D