2020-11-06 14:41:54

by Alex Shi

[permalink] [raw]
Subject: [PATCH] certs/blacklist: fix kernel doc interface issue

certs/blacklist.c:84: warning: Function parameter or member 'hash' not
described in 'mark_hash_blacklisted'

Signed-off-by: Alex Shi <[email protected]>
Cc: David Howells <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
certs/blacklist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/certs/blacklist.c b/certs/blacklist.c
index 6514f9ebc943..02f1016ce6e8 100644
--- a/certs/blacklist.c
+++ b/certs/blacklist.c
@@ -78,7 +78,7 @@ static void blacklist_describe(const struct key *key, struct seq_file *m)

/**
* mark_hash_blacklisted - Add a hash to the system blacklist
- * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
+ * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
*/
int mark_hash_blacklisted(const char *hash)
{
--
1.8.3.1


2020-11-30 10:09:44

by David Howells

[permalink] [raw]
Subject: Re: [PATCH] certs/blacklist: fix kernel doc interface issue

Alex Shi <[email protected]> wrote:

> /**
> * mark_hash_blacklisted - Add a hash to the system blacklist
> - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
> + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")

You should remove the dash when making this change. I'll do that for you.

David

2020-11-30 11:19:56

by Alex Shi

[permalink] [raw]
Subject: Re: [PATCH] certs/blacklist: fix kernel doc interface issue



?? 2020/11/30 ????6:04, David Howells ะด??:
> Alex Shi <[email protected]> wrote:
>
>> /**
>> * mark_hash_blacklisted - Add a hash to the system blacklist
>> - * @hash - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
>> + * @hash: - The hash as a hex string with a type prefix (eg. "tbs:23aa429783")
>
> You should remove the dash when making this change. I'll do that for you.


Hi David,

Very appreciate for the fixing and reminder!

Regards
Alex