2021-07-31 00:02:55

by Randy Dunlap

Subject: [PATCH] trace: eradicate noisy warning in trace_osnoise.c

OK, I'm officially tired of this noise warning coming from
trace_osnoise.c, so shut it up. Also, adding new warnings is not OK.

../kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain]
void *main = osnoise_main;
^~~~

Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
Signed-off-by: Randy Dunlap <[email protected]>
Suggested-by: Matthew Wilcox <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Daniel Bristot de Oliveira <[email protected]>
---
kernel/trace/Makefile | 2 ++
1 file changed, 2 insertions(+)

--- mmotm-2021-0728-1824.orig/kernel/trace/Makefile
+++ mmotm-2021-0728-1824/kernel/trace/Makefile
@@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src)
CFLAGS_trace_benchmark.o := -I$(src)
CFLAGS_trace_events_filter.o := -I$(src)

+CFLAGS_trace_osnoise.o := -Wno-main
+
obj-$(CONFIG_TRACE_CLOCK) += trace_clock.o

obj-$(CONFIG_FUNCTION_TRACER) += libftrace.o

2021-07-31 00:43:41

by Steven Rostedt

Subject: Re: [PATCH] trace: eradicate noisy warning in trace_osnoise.c

On Fri, 30 Jul 2021 17:00:55 -0700
Randy Dunlap <[email protected]> wrote:

> OK, I'm officially tired of this noise warning coming from
> trace_osnoise.c, so shut it up. Also, adding new warnings is not OK.

I agree adding "new warnings" is not OK, but this is a stupid warning.

>
> ../kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
> ../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain]
> void *main = osnoise_main;
> ^~~~
>
> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
> Signed-off-by: Randy Dunlap <[email protected]>
> Suggested-by: Matthew Wilcox <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Daniel Bristot de Oliveira <[email protected]>
> ---
> kernel/trace/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- mmotm-2021-0728-1824.orig/kernel/trace/Makefile
> +++ mmotm-2021-0728-1824/kernel/trace/Makefile
> @@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src)
> CFLAGS_trace_benchmark.o := -I$(src)
> CFLAGS_trace_events_filter.o := -I$(src)
>
> +CFLAGS_trace_osnoise.o := -Wno-main

Why just add it here. It's a silly warning to have for the kernel at
all. Should this not be added in a more global place?

-- Steve


> +
> obj-$(CONFIG_TRACE_CLOCK) += trace_clock.o
>
> obj-$(CONFIG_FUNCTION_TRACER) += libftrace.o

2021-07-31 01:13:56

by Randy Dunlap

Subject: Re: [PATCH] trace: eradicate noisy warning in trace_osnoise.c

On 7/30/21 5:40 PM, Steven Rostedt wrote:
> On Fri, 30 Jul 2021 17:00:55 -0700
> Randy Dunlap <[email protected]> wrote:
>
>> OK, I'm officially tired of this noise warning coming from
>> trace_osnoise.c, so shut it up. Also, adding new warnings is not OK.
>
> I agree adding "new warnings" is not OK, but this is a stupid warning.
>
>>
>> ../kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
>> ../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain]
>> void *main = osnoise_main;
>> ^~~~
>>
>> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Suggested-by: Matthew Wilcox <[email protected]>
>> Cc: Steven Rostedt <[email protected]>
>> Cc: Ingo Molnar <[email protected]>
>> Cc: Daniel Bristot de Oliveira <[email protected]>
>> ---
>> kernel/trace/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> --- mmotm-2021-0728-1824.orig/kernel/trace/Makefile
>> +++ mmotm-2021-0728-1824/kernel/trace/Makefile
>> @@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src)
>> CFLAGS_trace_benchmark.o := -I$(src)
>> CFLAGS_trace_events_filter.o := -I$(src)
>>
>> +CFLAGS_trace_osnoise.o := -Wno-main
>
> Why just add it here. It's a silly warning to have for the kernel at
> all. Should this not be added in a more global place?

I don't know of any other places that name something 'main' when it is
not a main() function.

> -- Steve
>
>
>> +
>> obj-$(CONFIG_TRACE_CLOCK) += trace_clock.o
>>
>> obj-$(CONFIG_FUNCTION_TRACER) += libftrace.o
>


--
~Randy

2021-08-02 07:59:34

by Daniel Bristot de Oliveira

Subject: Re: [PATCH] trace: eradicate noisy warning in trace_osnoise.c

On 7/31/21 3:11 AM, Randy Dunlap wrote:
> On 7/30/21 5:40 PM, Steven Rostedt wrote:
>> On Fri, 30 Jul 2021 17:00:55 -0700
>> Randy Dunlap <[email protected]> wrote:
>>
>>> OK, I'm officially tired of this noise warning coming from
>>> trace_osnoise.c, so shut it up. Also, adding new warnings is not OK.
>> I agree adding "new warnings" is not OK, but this is a stupid warning.
>>
>>> ../kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
>>> ../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain]
>>> void *main = osnoise_main;
>>> ^~~~
>>>
>>> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
>>> Signed-off-by: Randy Dunlap <[email protected]>
>>> Suggested-by: Matthew Wilcox <[email protected]>
>>> Cc: Steven Rostedt <[email protected]>
>>> Cc: Ingo Molnar <[email protected]>
>>> Cc: Daniel Bristot de Oliveira <[email protected]>
>>> ---
>>> kernel/trace/Makefile | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> --- mmotm-2021-0728-1824.orig/kernel/trace/Makefile
>>> +++ mmotm-2021-0728-1824/kernel/trace/Makefile
>>> @@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src)
>>> CFLAGS_trace_benchmark.o := -I$(src)
>>> CFLAGS_trace_events_filter.o := -I$(src)
>>>
>>> +CFLAGS_trace_osnoise.o := -Wno-main
>> Why just add it here. It's a silly warning to have for the kernel at
>> all. Should this not be added in a more global place?
> I don't know of any other places that name something 'main' when it is
> not a main() function.
>

I would say that we either use -Wno-main for the entire kernel or rename the
main variable to tracer_main....

-- Daniel

2021-08-03 04:18:36

by Randy Dunlap

Subject: Re: [PATCH] trace: eradicate noisy warning in trace_osnoise.c

On 8/2/21 12:58 AM, Daniel Bristot de Oliveira wrote:
> On 7/31/21 3:11 AM, Randy Dunlap wrote:
>> On 7/30/21 5:40 PM, Steven Rostedt wrote:
>>> On Fri, 30 Jul 2021 17:00:55 -0700
>>> Randy Dunlap <[email protected]> wrote:
>>>
>>>> OK, I'm officially tired of this noise warning coming from
>>>> trace_osnoise.c, so shut it up. Also, adding new warnings is not OK.
>>> I agree adding "new warnings" is not OK, but this is a stupid warning.
>>>
>>>> ../kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
>>>> ../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain]
>>>> void *main = osnoise_main;
>>>> ^~~~
>>>>
>>>> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
>>>> Signed-off-by: Randy Dunlap <[email protected]>
>>>> Suggested-by: Matthew Wilcox <[email protected]>
>>>> Cc: Steven Rostedt <[email protected]>
>>>> Cc: Ingo Molnar <[email protected]>
>>>> Cc: Daniel Bristot de Oliveira <[email protected]>
>>>> ---
>>>> kernel/trace/Makefile | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> --- mmotm-2021-0728-1824.orig/kernel/trace/Makefile
>>>> +++ mmotm-2021-0728-1824/kernel/trace/Makefile
>>>> @@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src)
>>>> CFLAGS_trace_benchmark.o := -I$(src)
>>>> CFLAGS_trace_events_filter.o := -I$(src)
>>>>
>>>> +CFLAGS_trace_osnoise.o := -Wno-main
>>> Why just add it here. It's a silly warning to have for the kernel at
>>> all. Should this not be added in a more global place?
>> I don't know of any other places that name something 'main' when it is
>> not a main() function.
>>
>
> I would say that we either use -Wno-main for the entire kernel or rename the
> main variable to tracer_main....

I'm OK with the latter...

thanks.