2016-11-03 09:39:10

by Johannes Thumshirn

Subject: [PATCH] block: drop q argument from bsg_validate_sgv4_hdr

bsg_validate_sgv4_hdr() doesn't care about the request_queue, so drop it
from it's arguments.

Signed-off-by: Johannes Thumshirn <[email protected]>
---
block/bsg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/bsg.c b/block/bsg.c
index d214e92..8a05a40 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -176,7 +176,7 @@ static int blk_fill_sgv4_hdr_rq(struct request_queue *q, struct request *rq,
* Check if sg_io_v4 from user is allowed and valid
*/
static int
-bsg_validate_sgv4_hdr(struct request_queue *q, struct sg_io_v4 *hdr, int *rw)
+bsg_validate_sgv4_hdr(struct sg_io_v4 *hdr, int *rw)
{
int ret = 0;

@@ -226,7 +226,7 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm,
hdr->dout_xfer_len, (unsigned long long) hdr->din_xferp,
hdr->din_xfer_len);

- ret = bsg_validate_sgv4_hdr(q, hdr, &rw);
+ ret = bsg_validate_sgv4_hdr(hdr, &rw);
if (ret)
return ERR_PTR(ret);

--
2.10.0

2016-11-03 13:57:39

by Jens Axboe

Subject: Re: [PATCH] block: drop q argument from bsg_validate_sgv4_hdr

On 11/03/2016 03:38 AM, Johannes Thumshirn wrote:
> bsg_validate_sgv4_hdr() doesn't care about the request_queue, so drop it
> from it's arguments.

Thanks, applied.

--
Jens Axboe