2023-10-10 22:26:41

by Jessica Zhang

[permalink] [raw]
Subject: [PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner

Recently, we've registered a Gitlab runner for a Qualcomm RB5 device that will be
hosted and maintained in Qualcomm labs.

This series will add a corresponding CI job for testing SM8250 devices and add the
skip/fails/flakes list. We were able to complete a successful run [1] with these
changes.

For now, we will keep the job as manual trigger only and drop that rule later
after we stabilize the tests.

[1] https://gitlab.freedesktop.org/drm/msm/-/jobs/50092719

---
Jessica Zhang (3):
drm/ci: Add SM8250 job to CI
drm/ci: enable CONFIG_INTERCONNECT_QCOM_SM8250 for arm64 config
drm/ci: Add skips, fails and flakes for SM8250

drivers/gpu/drm/ci/arm64.config | 1 +
drivers/gpu/drm/ci/build.sh | 1 +
drivers/gpu/drm/ci/test.yml | 15 +++++++++++++
drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt | 29 +++++++++++++++++++++++++
drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt | 3 +++
drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt | 8 +++++++
6 files changed, 57 insertions(+)
---
base-commit: dcd88f8c63341ed11a8c5019408f62202cd9d1f2
change-id: 20230919-rb5-runner-77ec32bd61e7

Best regards,
--
Jessica Zhang <[email protected]>


2023-10-10 22:26:44

by Jessica Zhang

[permalink] [raw]
Subject: [PATCH 2/3] drm/ci: enable CONFIG_INTERCONNECT_QCOM_SM8250 for arm64 config

Set CONFIG_INTERCONNECT_QCOM_SM8250 needs to =y so that the ASIX AX88179
USB Ethernet driver can be probed in time to set up nfsroot.

Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Jessica Zhang <[email protected]>
---
drivers/gpu/drm/ci/arm64.config | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
index 817e18ddfd4f..7273a37cbc4f 100644
--- a/drivers/gpu/drm/ci/arm64.config
+++ b/drivers/gpu/drm/ci/arm64.config
@@ -75,6 +75,7 @@ CONFIG_INTERCONNECT_QCOM_MSM8916=y
CONFIG_INTERCONNECT_QCOM_MSM8996=y
CONFIG_INTERCONNECT_QCOM_OSM_L3=y
CONFIG_INTERCONNECT_QCOM_SC7180=y
+CONFIG_INTERCONNECT_QCOM_SM8250=y
CONFIG_INTERCONNECT_QCOM_SM8350=y
CONFIG_CRYPTO_DEV_QCOM_RNG=y
CONFIG_SC_DISPCC_7180=y

--
2.42.0

2023-10-10 22:27:10

by Jessica Zhang

[permalink] [raw]
Subject: [PATCH 3/3] drm/ci: Add skips, fails and flakes for SM8250

Add skips, fails and flakes for the SM8250 test.

Generated using update-xfails.py [1]

[1] https://patchwork.freedesktop.org/patch/561453/?series=124793&rev=1

Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Jessica Zhang <[email protected]>
---
drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt | 29 +++++++++++++++++++++++++
drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt | 3 +++
drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt | 8 +++++++
3 files changed, 40 insertions(+)

diff --git a/drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt b/drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt
new file mode 100644
index 000000000000..cc8ae32e90e7
--- /dev/null
+++ b/drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt
@@ -0,0 +1,29 @@
+kms_3d,Fail
+kms_atomic_transition@plane-all-modeset-transition,Timeout
+kms_color@ctm-0-25,Fail
+kms_color@ctm-0-50,Fail
+kms_color@ctm-0-75,Fail
+kms_color@ctm-blue-to-red,Fail
+kms_color@ctm-negative,Fail
+kms_color@ctm-red-to-blue,Fail
+kms_color@ctm-signed,Fail
+kms_cursor_legacy@basic-flip-after-cursor-varying-size,Fail
+kms_cursor_legacy@basic-flip-before-cursor-varying-size,Fail
+kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size,Fail
+kms_cursor_legacy@cursor-vs-flip-toggle,Fail
+kms_cursor_legacy@cursor-vs-flip-varying-size,Fail
+kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size,Fail
+kms_cursor_legacy@short-flip-before-cursor-atomic-transitions-varying-size,Fail
+kms_cursor_legacy@short-flip-before-cursor-toggle,Fail
+kms_hdmi_inject@inject-4k,Fail
+kms_pipe_crc_basic@compare-crc-sanitycheck-nv12,Fail
+kms_plane@pixel-format,Fail
+kms_plane@pixel-format-source-clamping,Fail
+kms_plane@plane-position-covered,Fail
+kms_plane@plane-position-hole,Fail
+kms_plane@plane-position-hole-dpms,Fail
+kms_plane_alpha_blend@alpha-7efc,Fail
+kms_plane_alpha_blend@coverage-7efc,Fail
+kms_plane_alpha_blend@coverage-vs-premult-vs-constant,Fail
+kms_plane_cursor@overlay,Fail
+kms_rmfb@close-fd,Fail
diff --git a/drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt b/drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt
new file mode 100644
index 000000000000..0b55665184c1
--- /dev/null
+++ b/drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt
@@ -0,0 +1,3 @@
+kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size
+kms_cursor_legacy@flip-vs-cursor-varying-size
+kms_plane_cursor@viewport
diff --git a/drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt b/drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt
new file mode 100644
index 000000000000..c20422c58e4d
--- /dev/null
+++ b/drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt
@@ -0,0 +1,8 @@
+# Suspend to RAM seems to be broken on this machine
+.*suspend.*
+
+# reboots device
+kms_plane_scaling.*
+
+# long execution time
+kms_flip.*

--
2.42.0

2023-11-04 13:03:09

by Helen Koike

[permalink] [raw]
Subject: Re: [PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner

Hi Jessica,

On 10/10/2023 19:25, Jessica Zhang wrote:
> Recently, we've registered a Gitlab runner for a Qualcomm RB5 device that will be
> hosted and maintained in Qualcomm labs.
>
> This series will add a corresponding CI job for testing SM8250 devices and add the
> skip/fails/flakes list. We were able to complete a successful run [1] with these
> changes.
>
> For now, we will keep the job as manual trigger only and drop that rule later
> after we stabilize the tests.
>
> [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/50092719
>
> ---

Thank you for you patchset.

I'm getting the following error:

"serial.serialutil.SerialException: [Errno 2] could not open port
/dev/ttyUSB0: [Errno 2] No such file or directory: '/dev/ttyUSB0'"

https://gitlab.freedesktop.org/helen.fornazier/linux/-/jobs/51193215#L146

I'm wondering if I'm missing some configuration.

I tested on top of drm-misc-next.

Also, I'd like to add in the docs an entry about the devices we have,
which tag they need, which dts they correspond to, which farm they are
located, who to contact if there is any problem and maybe some comment
about the device (how it is hooked up, the logs comes from uart or ssh,
does it use fastboot, etc) if you find it useful.
Would you mind adding an entry in the docs with this information for the
sm8250? (Than I'll add the info of the other devices after yours).


> Jessica Zhang (3):
> drm/ci: Add SM8250 job to CI

I would also move this patch to last, so we don't have a commit where
things shouldn't work properly.
Or maybe squash them all.

Regards,
Helen

> drm/ci: enable CONFIG_INTERCONNECT_QCOM_SM8250 for arm64 config
> drm/ci: Add skips, fails and flakes for SM8250
>
> drivers/gpu/drm/ci/arm64.config | 1 +
> drivers/gpu/drm/ci/build.sh | 1 +
> drivers/gpu/drm/ci/test.yml | 15 +++++++++++++
> drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt | 29 +++++++++++++++++++++++++
> drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt | 3 +++
> drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt | 8 +++++++
> 6 files changed, 57 insertions(+)
> ---
> base-commit: dcd88f8c63341ed11a8c5019408f62202cd9d1f2
> change-id: 20230919-rb5-runner-77ec32bd61e7
>
> Best regards,

2023-11-04 13:19:43

by Helen Koike

[permalink] [raw]
Subject: Re: [PATCH 3/3] drm/ci: Add skips, fails and flakes for SM8250



On 10/10/2023 19:25, Jessica Zhang wrote:
> Add skips, fails and flakes for the SM8250 test.
>
> Generated using update-xfails.py [1]
>
> [1] https://patchwork.freedesktop.org/patch/561453/?series=124793&rev=1
>
> Signed-off-by: Abhinav Kumar <[email protected]>
> Signed-off-by: Jessica Zhang <[email protected]>
> ---
> drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt | 29 +++++++++++++++++++++++++
> drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt | 3 +++
> drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt | 8 +++++++
> 3 files changed, 40 insertions(+)
>
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt b/drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt
> new file mode 100644
> index 000000000000..cc8ae32e90e7
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt
> @@ -0,0 +1,29 @@
> +kms_3d,Fail
> +kms_atomic_transition@plane-all-modeset-transition,Timeout
> +kms_color@ctm-0-25,Fail
> +kms_color@ctm-0-50,Fail
> +kms_color@ctm-0-75,Fail
> +kms_color@ctm-blue-to-red,Fail
> +kms_color@ctm-negative,Fail
> +kms_color@ctm-red-to-blue,Fail
> +kms_color@ctm-signed,Fail
> +kms_cursor_legacy@basic-flip-after-cursor-varying-size,Fail
> +kms_cursor_legacy@basic-flip-before-cursor-varying-size,Fail
> +kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size,Fail
> +kms_cursor_legacy@cursor-vs-flip-toggle,Fail
> +kms_cursor_legacy@cursor-vs-flip-varying-size,Fail
> +kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size,Fail
> +kms_cursor_legacy@short-flip-before-cursor-atomic-transitions-varying-size,Fail
> +kms_cursor_legacy@short-flip-before-cursor-toggle,Fail
> +kms_hdmi_inject@inject-4k,Fail
> +kms_pipe_crc_basic@compare-crc-sanitycheck-nv12,Fail
> +kms_plane@pixel-format,Fail
> +kms_plane@pixel-format-source-clamping,Fail
> +kms_plane@plane-position-covered,Fail
> +kms_plane@plane-position-hole,Fail
> +kms_plane@plane-position-hole-dpms,Fail
> +kms_plane_alpha_blend@alpha-7efc,Fail
> +kms_plane_alpha_blend@coverage-7efc,Fail
> +kms_plane_alpha_blend@coverage-vs-premult-vs-constant,Fail
> +kms_plane_cursor@overlay,Fail
> +kms_rmfb@close-fd,Fail
> diff --git a/drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt b/drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt
> new file mode 100644
> index 000000000000..0b55665184c1
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt
> @@ -0,0 +1,3 @@
> +kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size
> +kms_cursor_legacy@flip-vs-cursor-varying-size
> +kms_plane_cursor@viewport

We are trying to add some docs, specially to the flakes, please check:
https://lists.freedesktop.org/archives/dri-devel/2023-October/427982.html

Could you add it for those? (I'm glad to see there are just a few flakes).

Thanks
Helen

> diff --git a/drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt b/drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt
> new file mode 100644
> index 000000000000..c20422c58e4d
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt
> @@ -0,0 +1,8 @@
> +# Suspend to RAM seems to be broken on this machine
> +.*suspend.*
> +
> +# reboots device
> +kms_plane_scaling.*
> +
> +# long execution time
> +kms_flip.*
>

2023-11-06 17:36:20

by Jessica Zhang

[permalink] [raw]
Subject: Re: [PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner



On 11/4/2023 6:02 AM, Helen Koike wrote:
> Hi Jessica,
>
> On 10/10/2023 19:25, Jessica Zhang wrote:
>> Recently, we've registered a Gitlab runner for a Qualcomm RB5 device
>> that will be
>> hosted and maintained in Qualcomm labs.
>>
>> This series will add a corresponding CI job for testing SM8250 devices
>> and add the
>> skip/fails/flakes list. We were able to complete a successful run [1]
>> with these
>> changes.
>>
>> For now, we will keep the job as manual trigger only and drop that
>> rule later
>> after we stabilize the tests.
>>
>> [1] https://gitlab.freedesktop.org/drm/msm/-/jobs/50092719
>>
>> ---
>
> Thank you for you patchset.
>
> I'm getting the following error:
>
> "serial.serialutil.SerialException: [Errno 2] could not open port
> /dev/ttyUSB0: [Errno 2] No such file or directory: '/dev/ttyUSB0'"
>
> https://gitlab.freedesktop.org/helen.fornazier/linux/-/jobs/51193215#L146
>
> I'm wondering if I'm missing some configuration.
>
> I tested on top of drm-misc-next.

Hi Helen,

Sorry for the inconvenience, but I had to temporarily take down the
runner last Friday to physically move the setup (as part of a
reorganization of our lab here).

I'll update this thread as soon as the runner is back up -- the move
will be complete by the end of this week.

>
> Also, I'd like to add in the docs an entry about the devices we have,
> which tag they need, which dts they correspond to, which farm they are
> located, who to contact if there is any problem and maybe some comment
> about the device (how it is hooked up, the logs comes from uart or ssh,
> does it use fastboot, etc) if you find it useful.
> Would you mind adding an entry in the docs with this information for the
> sm8250? (Than I'll add the info of the other devices after yours).

Sure, sounds good.

>
>
>> Jessica Zhang (3):
>>        drm/ci: Add SM8250 job to CI
>
> I would also move this patch to last, so we don't have a commit where
> things shouldn't work properly.
> Or maybe squash them all.

Acked -- I'll move this patch to the end.

Thanks,

Jessica Zhang

>
> Regards,
> Helen
>
>>        drm/ci: enable CONFIG_INTERCONNECT_QCOM_SM8250 for arm64 config
>>        drm/ci: Add skips, fails and flakes for SM8250
>>
>>   drivers/gpu/drm/ci/arm64.config                 |  1 +
>>   drivers/gpu/drm/ci/build.sh                     |  1 +
>>   drivers/gpu/drm/ci/test.yml                     | 15 +++++++++++++
>>   drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt  | 29
>> +++++++++++++++++++++++++
>>   drivers/gpu/drm/ci/xfails/msm-sm8250-flakes.txt |  3 +++
>>   drivers/gpu/drm/ci/xfails/msm-sm8250-skips.txt  |  8 +++++++
>>   6 files changed, 57 insertions(+)
>> ---
>> base-commit: dcd88f8c63341ed11a8c5019408f62202cd9d1f2
>> change-id: 20230919-rb5-runner-77ec32bd61e7
>>
>> Best regards,