2017-04-01 14:14:21

by Simran Singhal

Subject: [PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)

Signed-off-by: simran singhal <[email protected]>
---
drivers/iio/humidity/hts221_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c
index 72ddcda..7d19a3d 100644
--- a/drivers/iio/humidity/hts221_buffer.c
+++ b/drivers/iio/humidity/hts221_buffer.c
@@ -41,7 +41,7 @@ static const struct iio_trigger_ops hts221_trigger_ops = {

static irqreturn_t hts221_trigger_handler_thread(int irq, void *private)
{
- struct hts221_hw *hw = (struct hts221_hw *)private;
+ struct hts221_hw *hw = private;
u8 status;
int err;

--
2.7.4

2017-04-02 08:51:25

by Jonathan Cameron

Subject: Re: [PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on void pointer

On 01/04/17 15:14, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
> - (T*)
> e
> )
>
> Signed-off-by: simran singhal <[email protected]>
I made a miinor change to the title to drop the _buffer.
That's naming the exact file, whereas keeping it to the driver
is fine (so just hts221).

Applied.

Thanks,

Jonathan
> ---
> drivers/iio/humidity/hts221_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c
> index 72ddcda..7d19a3d 100644
> --- a/drivers/iio/humidity/hts221_buffer.c
> +++ b/drivers/iio/humidity/hts221_buffer.c
> @@ -41,7 +41,7 @@ static const struct iio_trigger_ops hts221_trigger_ops = {
>
> static irqreturn_t hts221_trigger_handler_thread(int irq, void *private)
> {
> - struct hts221_hw *hw = (struct hts221_hw *)private;
> + struct hts221_hw *hw = private;
> u8 status;
> int err;
>
>