2020-10-29 01:01:10

by Cixi Geng

Subject: [PATCH V8] GCOV: Add config to check the preqequisites situation

From: Cixi Geng <[email protected]>

Introduce new configuration option GCOV_PROFILE_PREREQS that can be
used to check whether the prerequisites for enabling gcov profiling
for specific files and directories are met.

Only add SERIAL_GCOV for an example.

Signed-off-by: Cixi Geng <[email protected]>
---
drivers/tty/serial/Kconfig | 7 +++++++
drivers/tty/serial/Makefile | 1 +
kernel/gcov/Kconfig | 9 +++++++++
3 files changed, 17 insertions(+)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1044fc387691..fa33710c8435 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1586,3 +1586,10 @@ endmenu

config SERIAL_MCTRL_GPIO
tristate
+
+config SERIAL_GCOV
+ bool "Enable profile gcov for serial directory"
+ depends on GCOV_PROFILE_PREREQS
+ help
+ The SERIAL_GCOV will add Gcov profiling flags when kernel compiles.
+ Say 'Y' here if you want the gcov data for the serial directory,
diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
index caf167f0c10a..4a4934622c3f 100644
--- a/drivers/tty/serial/Makefile
+++ b/drivers/tty/serial/Makefile
@@ -3,6 +3,7 @@
# Makefile for the kernel serial device drivers.
#

+GCOV_PROFILE := $(CONFIG_SERIAL_GCOV)
obj-$(CONFIG_SERIAL_CORE) += serial_core.o

obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index 3110c77230c7..ce9b8ce4e63b 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov/Kconfig
@@ -51,4 +51,13 @@ config GCOV_PROFILE_ALL
larger and run slower. Also be sure to exclude files from profiling
which are not linked to the kernel image to prevent linker errors.

+config GCOV_PROFILE_PREREQS
+ bool "Profile Kernel for prereqs"
+ def_bool y if GCOV_KERNEL && !COMPILE_TEST
+ help
+ This options activates profiling for the specified kernel modules.
+ When some modules need Gcov data, enable this config, then configure
+ with gcov on the corresponding modules,The directories or files of
+ these modules will be added profiling flags after kernel compile.
+
endmenu
--
2.25.1

2020-10-30 10:27:52

by Peter Oberparleiter

Subject: Re: [PATCH V8] GCOV: Add config to check the preqequisites situation

On 28.10.2020 14:15, [email protected] wrote:
> From: Cixi Geng <[email protected]>
>
> Introduce new configuration option GCOV_PROFILE_PREREQS that can be
> used to check whether the prerequisites for enabling gcov profiling
> for specific files and directories are met.
>
> Only add SERIAL_GCOV for an example.

[...]

> +config GCOV_PROFILE_PREREQS
> + bool "Profile Kernel for prereqs"
> + def_bool y if GCOV_KERNEL && !COMPILE_TEST
> + help
> + This options activates profiling for the specified kernel modules.
> + When some modules need Gcov data, enable this config, then configure
> + with gcov on the corresponding modules,The directories or files of
> + these modules will be added profiling flags after kernel compile.
> +
> endmenu

This version still produces a prompt during make oldconfig. You need to
remove the "bool" line and the "help" lines.

Before sending another version please test it to make sure that it does
not produce a prompt.


--
Peter Oberparleiter
Linux on Z Development - IBM Germany