Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
Bit) element for TPDM. The associated aggregator will read this
size before it is enabled. DSB element size currently only
supports 32-bit and 64-bit.
Signed-off-by: Tao Zhang <[email protected]>
---
.../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
index 5c08342..d9b6b613 100644
--- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
@@ -44,6 +44,15 @@ properties:
minItems: 1
maxItems: 2
+ qcom,dsb-element-size:
+ description:
+ Specifies the DSB(Discrete Single Bit) element size supported by
+ the monitor. The associated aggregator will read this size before it
+ is enabled. DSB element size currently only supports 32-bit and 64-bit.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 32
+ maximum: 64
+
clocks:
maxItems: 1
@@ -77,6 +86,8 @@ examples:
compatible = "qcom,coresight-tpdm", "arm,primecell";
reg = <0x0684c000 0x1000>;
+ qcom,dsb-element-size = <32>;
+
clocks = <&aoss_qmp>;
clock-names = "apb_pclk";
--
2.7.4
On 23/03/2023 06:03, Tao Zhang wrote:
> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
> Bit) element for TPDM. The associated aggregator will read this
> size before it is enabled. DSB element size currently only
> supports 32-bit and 64-bit.
>
> Signed-off-by: Tao Zhang <[email protected]>
> ---
> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
> index 5c08342..d9b6b613 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
> @@ -44,6 +44,15 @@ properties:
> minItems: 1
> maxItems: 2
>
> + qcom,dsb-element-size:
> + description:
> + Specifies the DSB(Discrete Single Bit) element size supported by
> + the monitor. The associated aggregator will read this size before it
> + is enabled. DSB element size currently only supports 32-bit and 64-bit.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 32
> + maximum: 64
Shouldn't this be something like oneOf ? It is not a range, but one of
those two specific values ?
Suzuki
Hi Suzuki,
在 3/23/2023 7:18 PM, Suzuki K Poulose 写道:
> On 23/03/2023 06:03, Tao Zhang wrote:
>> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
>> Bit) element for TPDM. The associated aggregator will read this
>> size before it is enabled. DSB element size currently only
>> supports 32-bit and 64-bit.
>>
>> Signed-off-by: Tao Zhang <[email protected]>
>> ---
>> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> index 5c08342..d9b6b613 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> @@ -44,6 +44,15 @@ properties:
>> minItems: 1
>> maxItems: 2
>
>
>> + qcom,dsb-element-size:
>> + description:
>> + Specifies the DSB(Discrete Single Bit) element size supported by
>> + the monitor. The associated aggregator will read this size
>> before it
>> + is enabled. DSB element size currently only supports 32-bit
>> and 64-bit.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 32
>> + maximum: 64
>
> Shouldn't this be something like oneOf ? It is not a range, but one of
> those two specific values ?
Yes, "qcom,dsb-element-size" should be an optional option required in TPDM
devicetree. Other properties like "qcom,cmb-element-size",
"qcom,tc-element-size"
and etc. will be added in a later patch series.
I will update this doc according to your advice in the next version of
the patch.
Tao
>
> Suzuki
>
>
Hi Suzuki,
在 3/24/2023 4:25 PM, Tao Zhang 写道:
> Hi Suzuki,
>
> 在 3/23/2023 7:18 PM, Suzuki K Poulose 写道:
>> On 23/03/2023 06:03, Tao Zhang wrote:
>>> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
>>> Bit) element for TPDM. The associated aggregator will read this
>>> size before it is enabled. DSB element size currently only
>>> supports 32-bit and 64-bit.
>>>
>>> Signed-off-by: Tao Zhang <[email protected]>
>>> ---
>>> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>>> b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>>> index 5c08342..d9b6b613 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>>> @@ -44,6 +44,15 @@ properties:
>>> minItems: 1
>>> maxItems: 2
>>
>>
>>> + qcom,dsb-element-size:
>>> + description:
>>> + Specifies the DSB(Discrete Single Bit) element size supported by
>>> + the monitor. The associated aggregator will read this size
>>> before it
>>> + is enabled. DSB element size currently only supports 32-bit
>>> and 64-bit.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + minimum: 32
>>> + maximum: 64
>>
>> Shouldn't this be something like oneOf ? It is not a range, but one of
>> those two specific values ?
>
> Yes, "qcom,dsb-element-size" should be an optional option required in
> TPDM
>
> devicetree. Other properties like "qcom,cmb-element-size",
> "qcom,tc-element-size"
>
> and etc. will be added in a later patch series.
>
> I will update this doc according to your advice in the next version of
> the patch.
>
> Tao
>
Correct my misunderstanding in the mail above.
You are right, DSB element size should be 32-bit or 64-bit. I will
update this in the next
patch series.
Tao
>>
>> Suzuki
>>
>>
> _______________________________________________
> CoreSight mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
On 24/03/2023 10:15, Tao Zhang wrote:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>> + minimum: 32
>>>> + maximum: 64
>>>
>>> Shouldn't this be something like oneOf ? It is not a range, but one of
>>> those two specific values ?
>>
>> Yes, "qcom,dsb-element-size" should be an optional option required in
>> TPDM
>>
>> devicetree. Other properties like "qcom,cmb-element-size",
>> "qcom,tc-element-size"
>>
>> and etc. will be added in a later patch series.
>>
>> I will update this doc according to your advice in the next version of
>> the patch.
>>
>> Tao
>>
> Correct my misunderstanding in the mail above.
>
> You are right, DSB element size should be 32-bit or 64-bit. I will
> update this in the next
Then 'enum', not 'oneOf'.
Best regards,
Krzysztof
Hi Krzysztof,
On 3/25/2023 7:35 PM, Krzysztof Kozlowski wrote:
> On 24/03/2023 10:15, Tao Zhang wrote:
>>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>>> + minimum: 32
>>>>> + maximum: 64
>>>> Shouldn't this be something like oneOf ? It is not a range, but one of
>>>> those two specific values ?
>>> Yes, "qcom,dsb-element-size" should be an optional option required in
>>> TPDM
>>>
>>> devicetree. Other properties like "qcom,cmb-element-size",
>>> "qcom,tc-element-size"
>>>
>>> and etc. will be added in a later patch series.
>>>
>>> I will update this doc according to your advice in the next version of
>>> the patch.
>>>
>>> Tao
>>>
>> Correct my misunderstanding in the mail above.
>>
>> You are right, DSB element size should be 32-bit or 64-bit. I will
>> update this in the next
> Then 'enum', not 'oneOf'.
Got it.
Tao
>
> Best regards,
> Krzysztof
>