2024-04-24 07:00:15

by Ma Ke

Subject: [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()

To avoid the failure of usbnet_get_endpoints(), we should check the
return value of the usbnet_get_endpoints().

Signed-off-by: Ma Ke <[email protected]>
---
drivers/net/usb/ax88179_178a.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 752f821a1990..388ea178c91d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1287,8 +1287,11 @@ static void ax88179_get_mac_addr(struct usbnet *dev)
static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
{
struct ax88179_data *ax179_data;
+ int ret;

- usbnet_get_endpoints(dev, intf);
+ ret = usbnet_get_endpoints(dev, intf);
+ if (ret < 0)
+ return ret;

ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL);
if (!ax179_data)
--
2.37.2

2024-04-24 08:50:08

by Hariprasad Kelam

Subject: [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()

> To avoid the failure of usbnet_get_endpoints(), we should check the return
> value of the usbnet_get_endpoints().
>
> Signed-off-by: Ma Ke <[email protected]>
> ---
> drivers/net/usb/ax88179_178a.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/ax88179_178a.c
> b/drivers/net/usb/ax88179_178a.c index 752f821a1990..388ea178c91d
> 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1287,8 +1287,11 @@ static void ax88179_get_mac_addr(struct usbnet
> *dev) static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) {
> struct ax88179_data *ax179_data;
> + int ret;
>
> - usbnet_get_endpoints(dev, intf);
> + ret = usbnet_get_endpoints(dev, intf);
> + if (ret < 0)
> + return ret;
>
> ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL);
> if (!ax179_data)
> --
> 2.37.2
>
Nit: please include patch change log, below link required info
https://docs.kernel.org/process/submitting-patches.html


Reviewed-by: Hariprasad Kelam <[email protected]>

2024-04-24 19:17:53

by Andrew Lunn

Subject: Re: [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()

> Nit: please include patch change log, below link required info
> https://docs.kernel.org/process/submitting-patches.html

Also, please wait at least 24 hours before submitting new versions,
even when the previous version is completely broken and does not
compile:

https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Andrew

2024-04-26 02:00:52

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 24 Apr 2024 14:56:34 +0800 you wrote:
> To avoid the failure of usbnet_get_endpoints(), we should check the
> return value of the usbnet_get_endpoints().
>
> Signed-off-by: Ma Ke <[email protected]>
> ---
> drivers/net/usb/ax88179_178a.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

Here is the summary with links:
- [v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
https://git.kernel.org/netdev/net-next/c/3837639ebfdd

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html