From: Frank Wunderlich <[email protected]>
The description for property 'label' describes it as deprected, so
add a option to mark it like that. Future devicetrees should use
function and color properties.
Suggested-by: AngeloGioacchino Del Regno <[email protected]>
Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
Signed-off-by: Frank Wunderlich <[email protected]>
---
Documentation/devicetree/bindings/leds/common.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 8a3c2398b10c..2d7331bba1fc 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -58,6 +58,7 @@ properties:
no other LED class device can be assigned the same label. This property is
deprecated - use 'function' and 'color' properties instead.
function-enumerator has no effect when this property is present.
+ deprecated: true
default-state:
description:
--
2.34.1
On 09/05/2024 13:05, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> The description for property 'label' describes it as deprected, so
Typos here and in subject.
> add a option to mark it like that. Future devicetrees should use
> function and color properties.
>
> Suggested-by: AngeloGioacchino Del Regno <[email protected]>
> Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
Nooo, that's not a fix.
I don't think there was conclusion to make it deprecated on last attempt:
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
> On 09/05/2024 13:05, Frank Wunderlich wrote:
>> From: Frank Wunderlich <[email protected]>
>>
>> The description for property 'label' describes it as deprected, so
>
> Typos here and in subject.
>
>
>> add a option to mark it like that. Future devicetrees should use
>> function and color properties.
>>
>> Suggested-by: AngeloGioacchino Del Regno <[email protected]>
>> Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
>
> Nooo, that's not a fix.
>
> I don't think there was conclusion to make it deprecated on last attempt:
>
> https://lore.kernel.org/all/[email protected]/
>
It's not a fix, agreed.
But that property being deprecated deserves to be marked as deprecated, anyway.
Otherwise the documentation shouldn't say in words that it is such.
Cheers,
Angelo
On Thu 2024-05-09 14:39:36, AngeloGioacchino Del Regno wrote:
> Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
> > On 09/05/2024 13:05, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <[email protected]>
> > >
> > > The description for property 'label' describes it as deprected, so
> >
> > Typos here and in subject.
> >
> >
> > > add a option to mark it like that. Future devicetrees should use
> > > function and color properties.
> > >
> > > Suggested-by: AngeloGioacchino Del Regno <[email protected]>
> > > Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
> >
> > Nooo, that's not a fix.
> >
> > I don't think there was conclusion to make it deprecated on last attempt:
> >
> > https://lore.kernel.org/all/[email protected]/
> >
>
> It's not a fix, agreed.
>
> But that property being deprecated deserves to be marked as deprecated, anyway.
> Otherwise the documentation shouldn't say in words that it is such.
Fix the docs. We are not ready to deprecate that.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.