2024-06-06 07:07:38

by Primoz Fiser

[permalink] [raw]
Subject: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Set driver name to DRV_NAME. This simplifies the code and gets rid of
the following error messages:

ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'

Signed-off-by: Primoz Fiser <[email protected]>
---
sound/soc/ti/omap-hdmi.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
index 639bc83f4263..3f35eedeea41 100644
--- a/sound/soc/ti/omap-hdmi.c
+++ b/sound/soc/ti/omap-hdmi.c
@@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
if (!card)
return -ENOMEM;

- card->name = devm_kasprintf(dev, GFP_KERNEL,
- "HDMI %s", dev_name(ad->dssdev));
- if (!card->name)
- return -ENOMEM;
-
+ card->name = DRV_NAME;
card->owner = THIS_MODULE;
card->dai_link =
devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
--
2.25.1



2024-06-06 18:03:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

On Thu, Jun 06, 2024 at 09:00:47PM +0300, P?ter Ujfalusi wrote:
> On 6/6/24 10:06 AM, Primoz Fiser wrote:

> > - card->name = devm_kasprintf(dev, GFP_KERNEL,
> > - "HDMI %s", dev_name(ad->dssdev));
> > - if (!card->name)
> > - return -ENOMEM;
> > -
> > + card->name = DRV_NAME;

> I think it would be better to name is simply "HDMI" instead

That does seem a bit more user friendly.

Attachments:
(No filename) (404.00 B)
 signature.asc (499.00 B)
 Download all attachments

2024-06-06 18:31:23

by Péter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name



On 6/6/24 10:06 AM, Primoz Fiser wrote:
> Set driver name to DRV_NAME. This simplifies the code and gets rid of
> the following error messages:
>
> ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'
>
> Signed-off-by: Primoz Fiser <[email protected]>
> ---
> sound/soc/ti/omap-hdmi.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
> index 639bc83f4263..3f35eedeea41 100644
> --- a/sound/soc/ti/omap-hdmi.c
> +++ b/sound/soc/ti/omap-hdmi.c
> @@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
> if (!card)
> return -ENOMEM;
>
> - card->name = devm_kasprintf(dev, GFP_KERNEL,
> - "HDMI %s", dev_name(ad->dssdev));
> - if (!card->name)
> - return -ENOMEM;
> -
> + card->name = DRV_NAME;

I think it would be better to name is simply "HDMI" instead

> card->owner = THIS_MODULE;
> card->dai_link =
> devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);

--
Péter

2024-06-07 06:16:55

by Primoz Fiser

[permalink] [raw]
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Hi,

On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
>
>>> - card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> - "HDMI %s", dev_name(ad->dssdev));
>>> - if (!card->name)
>>> - return -ENOMEM;
>>> -
>>> + card->name = DRV_NAME;
>
>> I think it would be better to name is simply "HDMI" instead
>
> That does seem a bit more user friendly.

So card->name = "HDMI" for v2?

Thanks,
BR,
Primoz

--
Primoz Fiser | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o. | https://www.norik.com
<https://www.norik.com> |
Your embedded software partner | email: [email protected]
<mailto:[email protected]> |
Slovenia, EU | phone: +386-41-540-545
<tel:+386-41-540-545> |


2024-06-07 15:44:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

On Fri, Jun 07, 2024 at 08:14:40AM +0200, Primoz Fiser wrote:

> So card->name = "HDMI" for v2?

Yes, please.

Attachments:
(No filename) (115.00 B)
 signature.asc (499.00 B)
 Download all attachments