2020-07-06 08:38:15

by Hsin-Yi Wang

Subject: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz

Re measure capacity-dmips-mhz on elm and hana:

cpu 1: 9502 DMIPS @ 1703 Mhz
cpu 3: 16250 DMIPS @ 2106 Mhz

==> 740 : 1024

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 70b1ffcab7f0..5e046f9d48ce 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -167,7 +167,7 @@ cpu0: cpu@0 {
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cluster0_opp>;
- capacity-dmips-mhz = <526>;
+ capacity-dmips-mhz = <740>;
};

cpu1: cpu@1 {
@@ -182,7 +182,7 @@ cpu1: cpu@1 {
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cluster0_opp>;
- capacity-dmips-mhz = <526>;
+ capacity-dmips-mhz = <740>;
};

cpu2: cpu@100 {
--
2.27.0.212.ge8ba1cc988-goog

2020-07-08 17:39:49

by Matthias Brugger

Subject: Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz

On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> Re measure capacity-dmips-mhz on elm and hana:
>
> cpu 1: 9502 DMIPS @ 1703 Mhz
> cpu 3: 16250 DMIPS @ 2106 Mhz
>
> ==> 740 : 1024

I have some trouble to match the commit message to the actual patch. Commit
message talks about cpu 1 but patch changes cpu0. Where are the values of the
other CPUs?

Regards,
Matthias

>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 70b1ffcab7f0..5e046f9d48ce 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> operating-points-v2 = <&cluster0_opp>;
> - capacity-dmips-mhz = <526>;
> + capacity-dmips-mhz = <740>;
> };
>
> cpu1: cpu@1 {
> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> operating-points-v2 = <&cluster0_opp>;
> - capacity-dmips-mhz = <526>;
> + capacity-dmips-mhz = <740>;
> };
>
> cpu2: cpu@100 {
>

2020-07-08 18:57:39

by Hsin-Yi Wang

Subject: Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz

On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <[email protected]> wrote:
>
>
>
> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> > Re measure capacity-dmips-mhz on elm and hana:
> >
> > cpu 1: 9502 DMIPS @ 1703 Mhz
> > cpu 3: 16250 DMIPS @ 2106 Mhz
> >
> > ==> 740 : 1024
>
> I have some trouble to match the commit message to the actual patch. Commit
> message talks about cpu 1 but patch changes cpu0. Where are the values of the
> other CPUs?

Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
Small cpu: 9502 DMIPS @ 1703 Mhz
Big cpu: 16250 DMIPS @ 2106 Mhz

9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
changes the small cpu value to 740.



>
> Regards,
> Matthias
>
> >
> > Signed-off-by: Hsin-Yi Wang <[email protected]>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 70b1ffcab7f0..5e046f9d48ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -167,7 +167,7 @@ cpu0: cpu@0 {
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cluster0_opp>;
> > - capacity-dmips-mhz = <526>;
> > + capacity-dmips-mhz = <740>;
> > };
> >
> > cpu1: cpu@1 {
> > @@ -182,7 +182,7 @@ cpu1: cpu@1 {
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cluster0_opp>;
> > - capacity-dmips-mhz = <526>;
> > + capacity-dmips-mhz = <740>;
> > };
> >
> > cpu2: cpu@100 {
> >

2020-07-10 13:37:27

by Matthias Brugger

Subject: Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz

On 08/07/2020 20:55, Hsin-Yi Wang wrote:
> On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <[email protected]> wrote:
>>
>>
>>
>> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
>>> Re measure capacity-dmips-mhz on elm and hana:
>>>
>>> cpu 1: 9502 DMIPS @ 1703 Mhz
>>> cpu 3: 16250 DMIPS @ 2106 Mhz
>>>
>>> ==> 740 : 1024
>>
>> I have some trouble to match the commit message to the actual patch. Commit
>> message talks about cpu 1 but patch changes cpu0. Where are the values of the
>> other CPUs?
>
> Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
> Small cpu: 9502 DMIPS @ 1703 Mhz
> Big cpu: 16250 DMIPS @ 2106 Mhz
>
> 9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
> changes the small cpu value to 740.
>
>

applied to v5.8-next/dts64

Thanks!



>
>>
>> Regards,
>> Matthias
>>
>>>
>>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 70b1ffcab7f0..5e046f9d48ce 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> operating-points-v2 = <&cluster0_opp>;
>>> - capacity-dmips-mhz = <526>;
>>> + capacity-dmips-mhz = <740>;
>>> };
>>>
>>> cpu1: cpu@1 {
>>> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> operating-points-v2 = <&cluster0_opp>;
>>> - capacity-dmips-mhz = <526>;
>>> + capacity-dmips-mhz = <740>;
>>> };
>>>
>>> cpu2: cpu@100 {
>>>