2024-02-23 13:48:36

by Colin Ian King

Subject: [PATCH] clk: clocking-wizard: Remove redundant initialization of pointer div_addr

The pointer div_addr is being assigned a value that is never used, it is
being re-assigned a different value near the end of the function where
it is being read in the next statement. The initialization is redundant
and can be removed.

Cleans up clang scan build warning:
drivers/clk/xilinx/clk-xlnx-clock-wizard.c:501:16: warning: Value stored
to 'div_addr' during its initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
index 6a6e5d9292e8..19eb3fb7ae31 100644
--- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
+++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
@@ -498,7 +498,7 @@ static int clk_wzrd_dynamic_all_nolock(struct clk_hw *hw, unsigned long rate,
{
struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
unsigned long vco_freq, rate_div, clockout0_div;
- void __iomem *div_addr = divider->base;
+ void __iomem *div_addr;
u32 reg, pre, f;
int err;

--
2.39.2

2024-02-26 09:26:09

by Michal Simek

Subject: Re: [PATCH] clk: clocking-wizard: Remove redundant initialization of pointer div_addr

On 2/23/24 14:43, Colin Ian King wrote:
> The pointer div_addr is being assigned a value that is never used, it is
> being re-assigned a different value near the end of the function where
> it is being read in the next statement. The initialization is redundant
> and can be removed.
>
> Cleans up clang scan build warning:
> drivers/clk/xilinx/clk-xlnx-clock-wizard.c:501:16: warning: Value stored
> to 'div_addr' during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> index 6a6e5d9292e8..19eb3fb7ae31 100644
> --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> @@ -498,7 +498,7 @@ static int clk_wzrd_dynamic_all_nolock(struct clk_hw *hw, unsigned long rate,
> {
> struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
> unsigned long vco_freq, rate_div, clockout0_div;
> - void __iomem *div_addr = divider->base;
> + void __iomem *div_addr;
> u32 reg, pre, f;
> int err;
>

Reviewed-by: Michal Simek <[email protected]>

Thanks,
Michal

2024-02-28 22:52:58

by Stephen Boyd

Subject: Re: [PATCH] clk: clocking-wizard: Remove redundant initialization of pointer div_addr

Quoting Colin Ian King (2024-02-23 05:43:47)
> The pointer div_addr is being assigned a value that is never used, it is
> being re-assigned a different value near the end of the function where
> it is being read in the next statement. The initialization is redundant
> and can be removed.
>
> Cleans up clang scan build warning:
> drivers/clk/xilinx/clk-xlnx-clock-wizard.c:501:16: warning: Value stored
> to 'div_addr' during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Applied to clk-next