Fix a regression introduced by commit 9946e39fe8d0 ("ACPI: resource: skip
IRQ override on AMD Zen platforms") on MECHREV Jiaolong17KS, which
causes the built-in keyboard to not work. This restores the functionality
by adding an IRQ override.
I have personally tested this on the 17" model but I'm not sure if this
issue is present on the 16 model.
Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
Signed-off-by: Li Chen <[email protected]>
---
drivers/acpi/resource.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 0800a9d77558..5b00ee90388a 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -527,6 +527,17 @@ static const struct dmi_system_id lg_laptop[] = {
{ }
};
+static const struct dmi_system_id mechrev_laptop[] = {
+ {
+ .ident = "Jiaolong17KS Series GM7XG0M",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Jiaolong17KS Series GM7XG0M"),
+ },
+ },
+ { }
+};
+
struct irq_override_cmp {
const struct dmi_system_id *system;
unsigned char irq;
@@ -544,6 +555,7 @@ static const struct irq_override_cmp override_table[] = {
{ tongfang_gm_rg, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
{ maingear_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
{ lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
+ { mechrev_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true },
};
static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
--
2.41.0
[CCing mario and the regressions list]
On 30.06.23 14:20, Li Chen wrote:
> Fix a regression introduced by commit 9946e39fe8d0 ("ACPI: resource: skip
> IRQ override on AMD Zen platforms") on MECHREV Jiaolong17KS, which
> causes the built-in keyboard to not work. This restores the functionality
> by adding an IRQ override.
>
> I have personally tested this on the 17" model but I'm not sure if this
> issue is present on the 16 model.
>
> Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
> Signed-off-by: Li Chen <[email protected]>
Not my area of expertise (so take this with a gain of salt), but I'm
aware of something that afaics concerns this:
A few days ago a patch was merged to mainline that afaics hopefully
might make a change like your unnecessary. See a9c4a912b7d ("ACPI:
resource: Remove "Zen" specific match and quirks") in mainline or here:
https://lore.kernel.org/all/[email protected]/
Might be worth giving a try.
There is a rough plan to backport this to stable kernels, unless
problems show up.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
[Public]
> -----Original Message-----
> From: Linux regression tracking (Thorsten Leemhuis)
> <[email protected]>
> Sent: Friday, June 30, 2023 8:06 AM
> To: Li Chen <[email protected]>; linux-kernel <[email protected]>;
> linux-acpi <[email protected]>; Len Brown <[email protected]>; Rafael
> J. Wysocki <[email protected]>; Limonciello, Mario
> <[email protected]>
> Cc: Linux kernel regressions list <[email protected]>
> Subject: Re: [PATCH] ACPI: resource: Add IRQ override for MECHREV
> Jiaolong17KS
>
> [CCing mario and the regressions list]
>
> On 30.06.23 14:20, Li Chen wrote:
> > Fix a regression introduced by commit 9946e39fe8d0 ("ACPI: resource: skip
> > IRQ override on AMD Zen platforms") on MECHREV Jiaolong17KS, which
> > causes the built-in keyboard to not work. This restores the functionality
> > by adding an IRQ override.
> >
> > I have personally tested this on the 17" model but I'm not sure if this
> > issue is present on the 16 model.
> >
> > Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen
> platforms")
> > Signed-off-by: Li Chen <[email protected]>
>
> Not my area of expertise (so take this with a gain of salt), but I'm
> aware of something that afaics concerns this:
>
> A few days ago a patch was merged to mainline that afaics hopefully
> might make a change like your unnecessary. See a9c4a912b7d ("ACPI:
> resource: Remove "Zen" specific match and quirks") in mainline or here:
> https://lore.kernel.org/all/20230601221151.670-1-
> [email protected]/
>
> Might be worth giving a try.
>
> There is a rough plan to backport this to stable kernels, unless
> problems show up.
Correct.