'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/ieee802154/ca8210.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 3a2824f24caa..ece6ff6049f6 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv)
*/
static void ca8210_dev_com_clear(struct ca8210_priv *priv)
{
- flush_workqueue(priv->mlme_workqueue);
destroy_workqueue(priv->mlme_workqueue);
- flush_workqueue(priv->irq_workqueue);
destroy_workqueue(priv->irq_workqueue);
}
--
2.30.2
Hello Dave, Jakub.
I have nothing else in my ieee802154 tree for net right now so it would
be great if you could take it directly. If that poses a problem, let me
know and I will get it in through my tree.
On 14.10.21 20:26, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/net/ieee802154/ca8210.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 3a2824f24caa..ece6ff6049f6 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv)
> */
> static void ca8210_dev_com_clear(struct ca8210_priv *priv)
> {
> - flush_workqueue(priv->mlme_workqueue);
> destroy_workqueue(priv->mlme_workqueue);
> - flush_workqueue(priv->irq_workqueue);
> destroy_workqueue(priv->irq_workqueue);
> }
>
>
Thanks Christophe for spotting and fixing this.
Signed-off-by: Stefan Schmidt <[email protected]>
regards
Stefan Schmidt
On Sat, 16 Oct 2021 22:54:52 +0200 Stefan Schmidt wrote:
> I have nothing else in my ieee802154 tree for net right now so it would
> be great if you could take it directly.
Do you mean net or net-next? This looks like net-next material.
Just to be sure, applying directly is not a problem.
Hello Jakub.
On 18.10.21 23:14, Jakub Kicinski wrote:
> On Sat, 16 Oct 2021 22:54:52 +0200 Stefan Schmidt wrote:
>> I have nothing else in my ieee802154 tree for net right now so it would
>> be great if you could take it directly.
>
> Do you mean net or net-next? This looks like net-next material.
Yes, net-next, please.
> Just to be sure, applying directly is not a problem.
>
Thanks.
regards
Stefan Schmidt
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:
On Thu, 14 Oct 2021 20:26:14 +0200 you wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> [...]
Here is the summary with links:
- ieee802154: Remove redundant 'flush_workqueue()' calls
https://git.kernel.org/netdev/net-next/c/07fab5a469a5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html