2023-07-19 02:33:16

by hanyu001

Subject: [PATCH] ata: pata_serverworks: "foo * bar" should be "foo *bar"

This patch fixes the checkpatch.pl error:

./drivers/ata/pata_serverworks.c:305: ERROR: "foo * bar" should be "foo
*bar"

Signed-off-by: Yu Han <[email protected]>
---
drivers/ata/pata_serverworks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_serverworks.c
b/drivers/ata/pata_serverworks.c
index b348784..549ff24 100644
--- a/drivers/ata/pata_serverworks.c
+++ b/drivers/ata/pata_serverworks.c
@@ -302,7 +302,7 @@ static int serverworks_fixup_csb(struct pci_dev
*pdev)

/* Third Channel Test */
if (!(PCI_FUNC(pdev->devfn) & 1)) {
- struct pci_dev *findev = NULL;
+ struct pci_dev * findev = NULL;
u32 reg4c = 0;
findev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
PCI_DEVICE_ID_SERVERWORKS_CSB5, NULL);

2023-07-19 09:57:01

by Damien Le Moal

Subject: Re: [PATCH] ata: pata_serverworks: "foo * bar" should be "foo *bar"

On 7/19/23 10:54, [email protected] wrote:
> This patch fixes the checkpatch.pl error:
>
> ./drivers/ata/pata_serverworks.c:305: ERROR: "foo * bar" should be "foo
> *bar"
>
> Signed-off-by:     Yu Han <[email protected]>

Please stop sending patches like this. I will not apply such patch
unless you actually fix a bug or a compilation warning.

> ---
>  drivers/ata/pata_serverworks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_serverworks.c
> b/drivers/ata/pata_serverworks.c
> index b348784..549ff24 100644
> --- a/drivers/ata/pata_serverworks.c
> +++ b/drivers/ata/pata_serverworks.c
> @@ -302,7 +302,7 @@ static int serverworks_fixup_csb(struct pci_dev *pdev)
>
>      /* Third Channel Test */
>      if (!(PCI_FUNC(pdev->devfn) & 1)) {
> -        struct pci_dev *findev = NULL;
> +        struct pci_dev * findev = NULL;
>          u32 reg4c = 0;
>          findev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
>              PCI_DEVICE_ID_SERVERWORKS_CSB5, NULL);

--
Damien Le Moal
Western Digital Research