Few Tegra header file are missing license text.
Some Tegra dt-bindings header do not have Copyright.
Add license and Copyright for such Tegra header files.
Bitan Biswas (3):
dt-bindings: tegra: memory,bpmp-thermal: add SPDX license
trace: events: tegra_apb_dma: add SPDX license identifier
dt-bindings: tegra: clock,memory,thermal: add header Copyright
include/dt-bindings/clock/tegra114-car.h | 4 ++++
include/dt-bindings/clock/tegra124-car-common.h | 4 ++++
include/dt-bindings/clock/tegra124-car.h | 4 ++++
include/dt-bindings/clock/tegra186-clock.h | 6 ++++++
include/dt-bindings/clock/tegra20-car.h | 4 ++++
include/dt-bindings/clock/tegra210-car.h | 4 ++++
include/dt-bindings/clock/tegra30-car.h | 4 ++++
include/dt-bindings/gpio/tegra-gpio.h | 4 ++++
include/dt-bindings/gpio/tegra186-gpio.h | 4 ++++
include/dt-bindings/mailbox/tegra186-hsp.h | 4 ++++
include/dt-bindings/memory/tegra114-mc.h | 6 ++++++
include/dt-bindings/memory/tegra124-mc.h | 6 ++++++
include/dt-bindings/memory/tegra186-mc.h | 7 +++++++
include/dt-bindings/memory/tegra194-mc.h | 7 +++++++
include/dt-bindings/memory/tegra210-mc.h | 6 ++++++
include/dt-bindings/memory/tegra30-mc.h | 6 ++++++
include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h | 6 ++++++
include/dt-bindings/reset/tegra124-car.h | 4 ++++
include/dt-bindings/reset/tegra210-car.h | 4 ++++
include/dt-bindings/thermal/tegra124-soctherm.h | 4 ++++
include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 5 +++++
include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 5 +++++
include/trace/events/tegra_apb_dma.h | 1 +
23 files changed, 109 insertions(+)
--
2.17.1
Add Dual licensing SPDX license identifier for tegra186,tegra194
memory and bpmp-thermal headers.
Signed-off-by: Bitan Biswas <[email protected]>
---
include/dt-bindings/memory/tegra186-mc.h | 1 +
include/dt-bindings/memory/tegra194-mc.h | 1 +
include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 1 +
include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 1 +
4 files changed, 4 insertions(+)
diff --git a/include/dt-bindings/memory/tegra186-mc.h b/include/dt-bindings/memory/tegra186-mc.h
index 82a1e27f7357..be313d3790ae 100644
--- a/include/dt-bindings/memory/tegra186-mc.h
+++ b/include/dt-bindings/memory/tegra186-mc.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
#ifndef DT_BINDINGS_MEMORY_TEGRA186_MC_H
#define DT_BINDINGS_MEMORY_TEGRA186_MC_H
diff --git a/include/dt-bindings/memory/tegra194-mc.h b/include/dt-bindings/memory/tegra194-mc.h
index eed48b746bc9..16bb62bf8166 100644
--- a/include/dt-bindings/memory/tegra194-mc.h
+++ b/include/dt-bindings/memory/tegra194-mc.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
#ifndef DT_BINDINGS_MEMORY_TEGRA194_MC_H
#define DT_BINDINGS_MEMORY_TEGRA194_MC_H
diff --git a/include/dt-bindings/thermal/tegra186-bpmp-thermal.h b/include/dt-bindings/thermal/tegra186-bpmp-thermal.h
index a96b8fa31aab..fe9f5043c7b9 100644
--- a/include/dt-bindings/thermal/tegra186-bpmp-thermal.h
+++ b/include/dt-bindings/thermal/tegra186-bpmp-thermal.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
/*
* This header provides constants for binding nvidia,tegra186-bpmp-thermal.
*/
diff --git a/include/dt-bindings/thermal/tegra194-bpmp-thermal.h b/include/dt-bindings/thermal/tegra194-bpmp-thermal.h
index aa7fb08135ca..debea44bf115 100644
--- a/include/dt-bindings/thermal/tegra194-bpmp-thermal.h
+++ b/include/dt-bindings/thermal/tegra194-bpmp-thermal.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
/*
* This header provides constants for binding nvidia,tegra194-bpmp-thermal.
*/
--
2.17.1
Add Copyright for below Tegra dt-bindings headers:
1. clock
2. gpio
3. mailbox
4. memory
5. thermal
6. reset
7. pinctrl
Signed-off-by: Bitan Biswas <[email protected]>
---
include/dt-bindings/clock/tegra114-car.h | 4 ++++
include/dt-bindings/clock/tegra124-car-common.h | 4 ++++
include/dt-bindings/clock/tegra124-car.h | 4 ++++
include/dt-bindings/clock/tegra186-clock.h | 6 ++++++
include/dt-bindings/clock/tegra20-car.h | 4 ++++
include/dt-bindings/clock/tegra210-car.h | 4 ++++
include/dt-bindings/clock/tegra30-car.h | 4 ++++
include/dt-bindings/gpio/tegra-gpio.h | 4 ++++
include/dt-bindings/gpio/tegra186-gpio.h | 4 ++++
include/dt-bindings/mailbox/tegra186-hsp.h | 4 ++++
include/dt-bindings/memory/tegra114-mc.h | 6 ++++++
include/dt-bindings/memory/tegra124-mc.h | 6 ++++++
include/dt-bindings/memory/tegra186-mc.h | 6 ++++++
include/dt-bindings/memory/tegra194-mc.h | 6 ++++++
include/dt-bindings/memory/tegra210-mc.h | 6 ++++++
include/dt-bindings/memory/tegra30-mc.h | 6 ++++++
include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h | 6 ++++++
include/dt-bindings/reset/tegra124-car.h | 4 ++++
include/dt-bindings/reset/tegra210-car.h | 4 ++++
include/dt-bindings/thermal/tegra124-soctherm.h | 4 ++++
include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 4 ++++
include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 4 ++++
22 files changed, 104 insertions(+)
diff --git a/include/dt-bindings/clock/tegra114-car.h b/include/dt-bindings/clock/tegra114-car.h
index a93426f008ac..baff21e53a7d 100644
--- a/include/dt-bindings/clock/tegra114-car.h
+++ b/include/dt-bindings/clock/tegra114-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2013-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Hiroshi Doyu <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra114-car.
*
* The first 160 clocks are numbered to match the bits in the CAR's CLK_OUT_ENB
diff --git a/include/dt-bindings/clock/tegra124-car-common.h b/include/dt-bindings/clock/tegra124-car-common.h
index c59f9de01b4d..67fd0310284a 100644
--- a/include/dt-bindings/clock/tegra124-car-common.h
+++ b/include/dt-bindings/clock/tegra124-car-common.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2015-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Paul Walmsley <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra124-car or
* nvidia,tegra132-car.
*
diff --git a/include/dt-bindings/clock/tegra124-car.h b/include/dt-bindings/clock/tegra124-car.h
index c520ee231950..65cbc62ae1bb 100644
--- a/include/dt-bindings/clock/tegra124-car.h
+++ b/include/dt-bindings/clock/tegra124-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2013-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Peter De Schrijver <[email protected]>
+ *
* This header provides Tegra124-specific constants for binding
* nvidia,tegra124-car.
*/
diff --git a/include/dt-bindings/clock/tegra186-clock.h b/include/dt-bindings/clock/tegra186-clock.h
index d6b525f4566f..10ef3eda17f6 100644
--- a/include/dt-bindings/clock/tegra186-clock.h
+++ b/include/dt-bindings/clock/tegra186-clock.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2016-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Joseph Lo <[email protected]>
+ *
+ */
/** @file */
#ifndef _MACH_T186_CLK_T186_H
diff --git a/include/dt-bindings/clock/tegra20-car.h b/include/dt-bindings/clock/tegra20-car.h
index fe541f627965..85b3930bcae7 100644
--- a/include/dt-bindings/clock/tegra20-car.h
+++ b/include/dt-bindings/clock/tegra20-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2013-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Hiroshi Doyu <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra20-car.
*
* The first 96 clocks are numbered to match the bits in the CAR's CLK_OUT_ENB
diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindings/clock/tegra210-car.h
index 9cfcc3baa52c..34cd79c35b36 100644
--- a/include/dt-bindings/clock/tegra210-car.h
+++ b/include/dt-bindings/clock/tegra210-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2015-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra210-car.
*
* The first 224 clocks are numbered to match the bits in the CAR's CLK_OUT_ENB
diff --git a/include/dt-bindings/clock/tegra30-car.h b/include/dt-bindings/clock/tegra30-car.h
index f193663e6f28..707f2de4f0b1 100644
--- a/include/dt-bindings/clock/tegra30-car.h
+++ b/include/dt-bindings/clock/tegra30-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2013-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Hiroshi Doyu <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra30-car.
*
* The first 130 clocks are numbered to match the bits in the CAR's CLK_OUT_ENB
diff --git a/include/dt-bindings/gpio/tegra-gpio.h b/include/dt-bindings/gpio/tegra-gpio.h
index 7625dbc577c2..bf62c1194ae2 100644
--- a/include/dt-bindings/gpio/tegra-gpio.h
+++ b/include/dt-bindings/gpio/tegra-gpio.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2013-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Stephen Warren <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra*-gpio.
*
* The first cell in Tegra's GPIO specifier is the GPIO ID. The macros below
diff --git a/include/dt-bindings/gpio/tegra186-gpio.h b/include/dt-bindings/gpio/tegra186-gpio.h
index af0d9583be70..5e08cb581a00 100644
--- a/include/dt-bindings/gpio/tegra186-gpio.h
+++ b/include/dt-bindings/gpio/tegra186-gpio.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2016-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Stephen Warren <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra186-gpio*.
*
* The first cell in Tegra's GPIO specifier is the GPIO ID. The macros below
diff --git a/include/dt-bindings/mailbox/tegra186-hsp.h b/include/dt-bindings/mailbox/tegra186-hsp.h
index 3bdec7a84d35..dbfeab92068b 100644
--- a/include/dt-bindings/mailbox/tegra186-hsp.h
+++ b/include/dt-bindings/mailbox/tegra186-hsp.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2016-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Joseph Lo <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra186-hsp.
*/
diff --git a/include/dt-bindings/memory/tegra114-mc.h b/include/dt-bindings/memory/tegra114-mc.h
index dfe99c8a5ba5..1a2d16853847 100644
--- a/include/dt-bindings/memory/tegra114-mc.h
+++ b/include/dt-bindings/memory/tegra114-mc.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef DT_BINDINGS_MEMORY_TEGRA114_MC_H
#define DT_BINDINGS_MEMORY_TEGRA114_MC_H
diff --git a/include/dt-bindings/memory/tegra124-mc.h b/include/dt-bindings/memory/tegra124-mc.h
index 7e73bb400eca..8a7abf2325b6 100644
--- a/include/dt-bindings/memory/tegra124-mc.h
+++ b/include/dt-bindings/memory/tegra124-mc.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef DT_BINDINGS_MEMORY_TEGRA124_MC_H
#define DT_BINDINGS_MEMORY_TEGRA124_MC_H
diff --git a/include/dt-bindings/memory/tegra186-mc.h b/include/dt-bindings/memory/tegra186-mc.h
index be313d3790ae..283ea29bf426 100644
--- a/include/dt-bindings/memory/tegra186-mc.h
+++ b/include/dt-bindings/memory/tegra186-mc.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2017-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef DT_BINDINGS_MEMORY_TEGRA186_MC_H
#define DT_BINDINGS_MEMORY_TEGRA186_MC_H
diff --git a/include/dt-bindings/memory/tegra194-mc.h b/include/dt-bindings/memory/tegra194-mc.h
index 16bb62bf8166..30182fd94f0f 100644
--- a/include/dt-bindings/memory/tegra194-mc.h
+++ b/include/dt-bindings/memory/tegra194-mc.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2020-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef DT_BINDINGS_MEMORY_TEGRA194_MC_H
#define DT_BINDINGS_MEMORY_TEGRA194_MC_H
diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h
index 5e082547f179..c4e3ba88f77b 100644
--- a/include/dt-bindings/memory/tegra210-mc.h
+++ b/include/dt-bindings/memory/tegra210-mc.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2015-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef DT_BINDINGS_MEMORY_TEGRA210_MC_H
#define DT_BINDINGS_MEMORY_TEGRA210_MC_H
diff --git a/include/dt-bindings/memory/tegra30-mc.h b/include/dt-bindings/memory/tegra30-mc.h
index 930f708aca17..4972cf7e3cf2 100644
--- a/include/dt-bindings/memory/tegra30-mc.h
+++ b/include/dt-bindings/memory/tegra30-mc.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef DT_BINDINGS_MEMORY_TEGRA30_MC_H
#define DT_BINDINGS_MEMORY_TEGRA30_MC_H
diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h b/include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h
index ac63c399b4b6..a3ee0772fa36 100644
--- a/include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h
+++ b/include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h
@@ -1,4 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
+ */
#ifndef _DT_BINDINGS_PINCTRL_TEGRA_XUSB_H
#define _DT_BINDINGS_PINCTRL_TEGRA_XUSB_H 1
diff --git a/include/dt-bindings/reset/tegra124-car.h b/include/dt-bindings/reset/tegra124-car.h
index 97d2f3db82bf..7e050ccad994 100644
--- a/include/dt-bindings/reset/tegra124-car.h
+++ b/include/dt-bindings/reset/tegra124-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2015-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Paul Walmsley <[email protected]>
+ *
* This header provides Tegra124-specific constants for binding
* nvidia,tegra124-car.
*/
diff --git a/include/dt-bindings/reset/tegra210-car.h b/include/dt-bindings/reset/tegra210-car.h
index 9dc84ec76301..70388558fb6c 100644
--- a/include/dt-bindings/reset/tegra210-car.h
+++ b/include/dt-bindings/reset/tegra210-car.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2017-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Peter De Schrijver <[email protected]>
+ *
* This header provides Tegra210-specific constants for binding
* nvidia,tegra210-car.
*/
diff --git a/include/dt-bindings/thermal/tegra124-soctherm.h b/include/dt-bindings/thermal/tegra124-soctherm.h
index 444c7bdde146..9eae79d61b6d 100644
--- a/include/dt-bindings/thermal/tegra124-soctherm.h
+++ b/include/dt-bindings/thermal/tegra124-soctherm.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
+ * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Mikko Perttunen <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra124-soctherm.
*/
diff --git a/include/dt-bindings/thermal/tegra186-bpmp-thermal.h b/include/dt-bindings/thermal/tegra186-bpmp-thermal.h
index fe9f5043c7b9..77e98b083424 100644
--- a/include/dt-bindings/thermal/tegra186-bpmp-thermal.h
+++ b/include/dt-bindings/thermal/tegra186-bpmp-thermal.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
/*
+ * Copyright (c) 2017-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Mikko Perttunen <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra186-bpmp-thermal.
*/
diff --git a/include/dt-bindings/thermal/tegra194-bpmp-thermal.h b/include/dt-bindings/thermal/tegra194-bpmp-thermal.h
index debea44bf115..fdaf5f3af2b2 100644
--- a/include/dt-bindings/thermal/tegra194-bpmp-thermal.h
+++ b/include/dt-bindings/thermal/tegra194-bpmp-thermal.h
@@ -1,5 +1,9 @@
/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
/*
+ * Copyright (c) 2018-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+ *
+ * Author: Thierry Reding <[email protected]>
+ *
* This header provides constants for binding nvidia,tegra194-bpmp-thermal.
*/
--
2.17.1
Add GPL license in Tegra apb dma trace header file.
Signed-off-by: Bitan Biswas <[email protected]>
---
include/trace/events/tegra_apb_dma.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace/events/tegra_apb_dma.h b/include/trace/events/tegra_apb_dma.h
index 971cd02d2daf..fe10897b00b8 100644
--- a/include/trace/events/tegra_apb_dma.h
+++ b/include/trace/events/tegra_apb_dma.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
#if !defined(_TRACE_TEGRA_APB_DMA_H) || defined(TRACE_HEADER_MULTI_READ)
#define _TRACE_TEGRA_APB_DMA_H
--
2.17.1
On 21/09/2021 11:42, Bitan Biswas wrote:
> Add Dual licensing SPDX license identifier for tegra186,tegra194
> memory and bpmp-thermal headers.
>
> Signed-off-by: Bitan Biswas <[email protected]>
> ---
> include/dt-bindings/memory/tegra186-mc.h | 1 +
> include/dt-bindings/memory/tegra194-mc.h | 1 +
> include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 1 +
> include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/include/dt-bindings/memory/tegra186-mc.h b/include/dt-bindings/memory/tegra186-mc.h
> index 82a1e27f7357..be313d3790ae 100644
> --- a/include/dt-bindings/memory/tegra186-mc.h
> +++ b/include/dt-bindings/memory/tegra186-mc.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> #ifndef DT_BINDINGS_MEMORY_TEGRA186_MC_H
> #define DT_BINDINGS_MEMORY_TEGRA186_MC_H
>
The files were licensed as GPL-2.0 only, so you are effectively
re-licensing them. I guess this is ok, as you act on behalf of copyright
holders, but please state it in the commit message.
Best regards,
Krzysztof
On 21/09/2021 11:42, Bitan Biswas wrote:
> Add Copyright for below Tegra dt-bindings headers:
> 1. clock
> 2. gpio
> 3. mailbox
> 4. memory
> 5. thermal
> 6. reset
> 7. pinctrl
Why? Please explain.
These are trivial constants, so I doubt there is here any copyright value.
>
> Signed-off-by: Bitan Biswas <[email protected]>
> ---
> include/dt-bindings/clock/tegra114-car.h | 4 ++++
> include/dt-bindings/clock/tegra124-car-common.h | 4 ++++
> include/dt-bindings/clock/tegra124-car.h | 4 ++++
> include/dt-bindings/clock/tegra186-clock.h | 6 ++++++
> include/dt-bindings/clock/tegra20-car.h | 4 ++++
> include/dt-bindings/clock/tegra210-car.h | 4 ++++
> include/dt-bindings/clock/tegra30-car.h | 4 ++++
> include/dt-bindings/gpio/tegra-gpio.h | 4 ++++
> include/dt-bindings/gpio/tegra186-gpio.h | 4 ++++
> include/dt-bindings/mailbox/tegra186-hsp.h | 4 ++++
> include/dt-bindings/memory/tegra114-mc.h | 6 ++++++
> include/dt-bindings/memory/tegra124-mc.h | 6 ++++++
> include/dt-bindings/memory/tegra186-mc.h | 6 ++++++
> include/dt-bindings/memory/tegra194-mc.h | 6 ++++++
> include/dt-bindings/memory/tegra210-mc.h | 6 ++++++
> include/dt-bindings/memory/tegra30-mc.h | 6 ++++++
> include/dt-bindings/pinctrl/pinctrl-tegra-xusb.h | 6 ++++++
> include/dt-bindings/reset/tegra124-car.h | 4 ++++
> include/dt-bindings/reset/tegra210-car.h | 4 ++++
> include/dt-bindings/thermal/tegra124-soctherm.h | 4 ++++
> include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 4 ++++
> include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 4 ++++
> 22 files changed, 104 insertions(+)
>
(...)
> @@ -1,5 +1,9 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> + * Copyright (c) 2016-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Joseph Lo <[email protected]>
> + *
> * This header provides constants for binding nvidia,tegra186-hsp.
> */
>
> diff --git a/include/dt-bindings/memory/tegra114-mc.h b/include/dt-bindings/memory/tegra114-mc.h
> index dfe99c8a5ba5..1a2d16853847 100644
> --- a/include/dt-bindings/memory/tegra114-mc.h
> +++ b/include/dt-bindings/memory/tegra114-mc.h
> @@ -1,4 +1,10 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <[email protected]>
> + *
> + */
> #ifndef DT_BINDINGS_MEMORY_TEGRA114_MC_H
> #define DT_BINDINGS_MEMORY_TEGRA114_MC_H
>
> diff --git a/include/dt-bindings/memory/tegra124-mc.h b/include/dt-bindings/memory/tegra124-mc.h
> index 7e73bb400eca..8a7abf2325b6 100644
> --- a/include/dt-bindings/memory/tegra124-mc.h
> +++ b/include/dt-bindings/memory/tegra124-mc.h
> @@ -1,4 +1,10 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <[email protected]>
> + *
> + */
> #ifndef DT_BINDINGS_MEMORY_TEGRA124_MC_H
> #define DT_BINDINGS_MEMORY_TEGRA124_MC_H
>
> diff --git a/include/dt-bindings/memory/tegra186-mc.h b/include/dt-bindings/memory/tegra186-mc.h
> index be313d3790ae..283ea29bf426 100644
> --- a/include/dt-bindings/memory/tegra186-mc.h
> +++ b/include/dt-bindings/memory/tegra186-mc.h
> @@ -1,4 +1,10 @@
> /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2017-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <[email protected]>
> + *
> + */
> #ifndef DT_BINDINGS_MEMORY_TEGRA186_MC_H
> #define DT_BINDINGS_MEMORY_TEGRA186_MC_H
>
> diff --git a/include/dt-bindings/memory/tegra194-mc.h b/include/dt-bindings/memory/tegra194-mc.h
> index 16bb62bf8166..30182fd94f0f 100644
> --- a/include/dt-bindings/memory/tegra194-mc.h
> +++ b/include/dt-bindings/memory/tegra194-mc.h
> @@ -1,4 +1,10 @@
> /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2020-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <[email protected]>
> + *
> + */
> #ifndef DT_BINDINGS_MEMORY_TEGRA194_MC_H
> #define DT_BINDINGS_MEMORY_TEGRA194_MC_H
>
> diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h
> index 5e082547f179..c4e3ba88f77b 100644
> --- a/include/dt-bindings/memory/tegra210-mc.h
> +++ b/include/dt-bindings/memory/tegra210-mc.h
> @@ -1,4 +1,10 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2015-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <[email protected]>
> + *
> + */
> #ifndef DT_BINDINGS_MEMORY_TEGRA210_MC_H
> #define DT_BINDINGS_MEMORY_TEGRA210_MC_H
>
> diff --git a/include/dt-bindings/memory/tegra30-mc.h b/include/dt-bindings/memory/tegra30-mc.h
> index 930f708aca17..4972cf7e3cf2 100644
> --- a/include/dt-bindings/memory/tegra30-mc.h
> +++ b/include/dt-bindings/memory/tegra30-mc.h
> @@ -1,4 +1,10 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> + *
> + * Author: Thierry Reding <[email protected]>
> + *
I am sorry, but that's not entirely how it works. You cannot add only
selected (stripped) copyrights backwards. If adding, please include all
copyright holders.
Best regards,
Krzysztof
On 21/09/2021 11:42, Bitan Biswas wrote:
> Add GPL license in Tegra apb dma trace header file.
>
> Signed-off-by: Bitan Biswas <[email protected]>
> ---
> include/trace/events/tegra_apb_dma.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/tegra_apb_dma.h b/include/trace/events/tegra_apb_dma.h
> index 971cd02d2daf..fe10897b00b8 100644
> --- a/include/trace/events/tegra_apb_dma.h
> +++ b/include/trace/events/tegra_apb_dma.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
Looks good, but you should Cc the copyrights holder (Ben) to be nice and
friendly.
Best regards,
Krzysztof
Hi Krzysztof,
On 9/21/21 2:49 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 21/09/2021 11:42, Bitan Biswas wrote:
>> Add Dual licensing SPDX license identifier for tegra186,tegra194
>> memory and bpmp-thermal headers.
>>
>> Signed-off-by: Bitan Biswas <[email protected]>
>> ---
>> include/dt-bindings/memory/tegra186-mc.h | 1 +
>>
>> diff --git a/include/dt-bindings/memory/tegra186-mc.h b/include/dt-bindings/memory/tegra186-mc.h
>> index 82a1e27f7357..be313d3790ae 100644
>> --- a/include/dt-bindings/memory/tegra186-mc.h
>> +++ b/include/dt-bindings/memory/tegra186-mc.h
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> #ifndef DT_BINDINGS_MEMORY_TEGRA186_MC_H
>> #define DT_BINDINGS_MEMORY_TEGRA186_MC_H
>>
>
> The files were licensed as GPL-2.0 only, so you are effectively
> re-licensing them. I guess this is ok, as you act on behalf of copyright
> holders, but please state it in the commit message.
>
I shall update the commit message next stating that files are being
re-licensed acting on behalf of Copyright holders.
Thanks for the review.
-regards,
Bitan
Hi Krzysztof,
On 9/21/21 2:51 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 21/09/2021 11:42, Bitan Biswas wrote:
>> Add GPL license in Tegra apb dma trace header file.
>>
>> Signed-off-by: Bitan Biswas <[email protected]>
>> ---
>> include/trace/events/tegra_apb_dma.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/trace/events/tegra_apb_dma.h b/include/trace/events/tegra_apb_dma.h
>> index 971cd02d2daf..fe10897b00b8 100644
>> --- a/include/trace/events/tegra_apb_dma.h
>> +++ b/include/trace/events/tegra_apb_dma.h
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>
> Looks good, but you should Cc the copyrights holder (Ben) to be nice and
> friendly.
>
Thanks for the comment and help adding Ben in CC. I shall follow your
guidance in future.
-regards,
Bitan
Hi Krzysztof,
On 9/21/21 2:47 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 21/09/2021 11:42, Bitan Biswas wrote:
>> Add Copyright for below Tegra dt-bindings headers:
>> 1. clock
>> 2. gpio
>> 3. mailbox
>> 4. memory
>> 5. thermal
>> 6. reset
>> 7. pinctrl
>
> Why? Please explain.
>
> These are trivial constants, so I doubt there is here any copyright value.
>
You may see I was adding the missing Copyright of files created by
Nvidia developers in past. I have not evaluated the copyright value of
the contents added in the initial check-in. As suggested, I plan to drop
this patch in any further revisions of patches from this list.
>> include/dt-bindings/reset/tegra210-car.h | 4 ++++
>> include/dt-bindings/thermal/tegra124-soctherm.h | 4 ++++
>> include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 4 ++++
>> include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 4 ++++
>> 22 files changed, 104 insertions(+)
>>
>
> (...)
>
>> diff --git a/include/dt-bindings/memory/tegra30-mc.h b/include/dt-bindings/memory/tegra30-mc.h
>> index 930f708aca17..4972cf7e3cf2 100644
>> --- a/include/dt-bindings/memory/tegra30-mc.h
>> +++ b/include/dt-bindings/memory/tegra30-mc.h
>> @@ -1,4 +1,10 @@
>> /* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>> + *
>> + * Author: Thierry Reding <[email protected]>
>> + *
>
> I am sorry, but that's not entirely how it works. You cannot add only
> selected (stripped) copyrights backwards. If adding, please include all
> copyright holders.
>
I had emailed the authors(outside Nvidia) asking about additional
Copyright to add, but did not get response from all. One author was fine
with adding the Nvidia Copyright. I see now Copyright backwards needs us
to follow above approach. As mentioned above in my reply to your
comments I am planning to drop this patch if sending subsequent
revisions in this patch list.
Thanks for the inputs.
-regards,
Bitan