2023-04-21 21:57:33

by Luca Weiss

Subject: [PATCH 0/3] Add GPIO support to PM8953 PMIC

Add support for the 8 GPIOs found on the PM8953 PMIC used with msm8953
SoC.

Signed-off-by: Luca Weiss <[email protected]>
---
Luca Weiss (3):
dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953
pinctrl: qcom: spmi-gpio: Add PM8953 support
arm64: dts: qcom: pm8953: add GPIOs

Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
arch/arm64/boot/dts/qcom/pm8953.dtsi | 10 ++++++++++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
3 files changed, 15 insertions(+)
---
base-commit: 347e9b4e41bfff51993807962eb1082f6d8ab439
change-id: 20230421-pm8953-gpio-3f9017edc711

Best regards,
--
Luca Weiss <[email protected]>

2023-04-21 21:57:35

by Luca Weiss

Subject: [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs

Add a node for the GPIOs found on the pm8953.

Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm64/boot/dts/qcom/pm8953.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi b/arch/arm64/boot/dts/qcom/pm8953.dtsi
index a1d36f9ebbd2..2268daf27fa7 100644
--- a/arch/arm64/boot/dts/qcom/pm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi
@@ -79,6 +79,16 @@ rtc@6000 {
reg-names = "rtc", "alarm";
interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
};
+
+ pm8953_gpios: gpio@c000 {
+ compatible = "qcom,pm8953-gpio", "qcom,spmi-gpio";
+ reg = <0xc000>;
+ gpio-controller;
+ gpio-ranges = <&pm8953_gpios 0 0 8>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
};

pmic@1 {

--
2.40.0

2023-04-21 22:15:14

by Luca Weiss

Subject: [PATCH 2/3] pinctrl: qcom: spmi-gpio: Add PM8953 support

Add support for the 8 GPIOs found on PM8953.

Signed-off-by: Luca Weiss <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 43c7857c06a5..b4cd66886f29 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1229,6 +1229,8 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
/* pm8950 has 8 GPIOs with holes on 3 */
{ .compatible = "qcom,pm8950-gpio", .data = (void *) 8 },
+ /* pm8953 has 8 GPIOs with holes on 3 and 6 */
+ { .compatible = "qcom,pm8953-gpio", .data = (void *) 8 },
{ .compatible = "qcom,pm8994-gpio", .data = (void *) 22 },
{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
{ .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },

--
2.40.0

2023-04-22 10:00:16

by Konrad Dybcio

Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8953: add GPIOs

On 21.04.2023 23:56, Luca Weiss wrote:
> Add a node for the GPIOs found on the pm8953.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/pm8953.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8953.dtsi b/arch/arm64/boot/dts/qcom/pm8953.dtsi
> index a1d36f9ebbd2..2268daf27fa7 100644
> --- a/arch/arm64/boot/dts/qcom/pm8953.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8953.dtsi
> @@ -79,6 +79,16 @@ rtc@6000 {
> reg-names = "rtc", "alarm";
> interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> };
> +
> + pm8953_gpios: gpio@c000 {
> + compatible = "qcom,pm8953-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + gpio-ranges = <&pm8953_gpios 0 0 8>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> };
>
> pmic@1 {
>

2023-05-05 11:57:20

by Linus Walleij

Subject: Re: [PATCH 0/3] Add GPIO support to PM8953 PMIC

On Fri, Apr 21, 2023 at 11:56 PM Luca Weiss <[email protected]> wrote:

> Add support for the 8 GPIOs found on the PM8953 PMIC used with msm8953
> SoC.
>
> Signed-off-by: Luca Weiss <[email protected]>
(...)
> Luca Weiss (3):
> dt-bindings: pinctrl: qcom,pmic-gpio: add PM8953
> pinctrl: qcom: spmi-gpio: Add PM8953 support

I applied these two to the pinctrl tree for the v6.5 kernel cycle.

> arm64: dts: qcom: pm8953: add GPIOs

Please funnel this one through the qcom SoC tree (I think Bjorn
will pick it up else poke him).

Yours,
Linus Walleij

2023-05-25 05:35:44

by Bjorn Andersson

Subject: Re: (subset) [PATCH 0/3] Add GPIO support to PM8953 PMIC

On Fri, 21 Apr 2023 23:56:19 +0200, Luca Weiss wrote:
> Add support for the 8 GPIOs found on the PM8953 PMIC used with msm8953
> SoC.
>
>

Applied, thanks!

[3/3] arm64: dts: qcom: pm8953: add GPIOs
commit: 5a60e72c3eff0747cc779b8067cd795acf6beecd

Best regards,
--
Bjorn Andersson <[email protected]>