On 2023/8/25 23:09, Dave Jiang wrote:
>
>
> On 8/24/23 20:59, Yu Liao wrote:
>> Hi,
>>
>> A kindly ping, any comment on this?
>
> You can add my review tag to both of your patches in the series. Please cc
> [email protected] next time as well for nfit. Thanks!
Thank you for the review. I'll make the suggested changes and send you
the V2.
Best regards,
Yu
>
> Reviewed-by: Dave Jiang <[email protected]>
>
>>
>> Best regards,
>> Yu
>>
>>
>> On 2023/8/17 17:11, Yu Liao wrote:
>>> acpi_nfit_interleave's field 'line_offset' is switched to flexible array [1],
>>> but sizeof_idt() still calculates the size in the form of 1-element array.
>>>
>>> Therefore, fix incorrect calculation in sizeof_idt().
>>>
>>> [1] https://lore.kernel.org/lkml/2652195.BddDVKsqQX@kreacher/
>>>
>>> Fixes: 2a5ab99847bd ("ACPICA: struct acpi_nfit_interleave: Replace
>>> 1-element array with flexible array")
>>> Cc: [email protected] # v6.4+
>>> Signed-off-by: Yu Liao <[email protected]>
>>> ---
>>> drivers/acpi/nfit/core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>>> index 07204d482968..305f590c54a8 100644
>>> --- a/drivers/acpi/nfit/core.c
>>> +++ b/drivers/acpi/nfit/core.c
>>> @@ -855,7 +855,7 @@ static size_t sizeof_idt(struct acpi_nfit_interleave *idt)
>>> {
>>> if (idt->header.length < sizeof(*idt))
>>> return 0;
>>> - return sizeof(*idt) + sizeof(u32) * (idt->line_count - 1);
>>> + return sizeof(*idt) + sizeof(u32) * idt->line_count;
>>> }
>>> static bool add_idt(struct acpi_nfit_desc *acpi_desc,
>>