2018-08-10 01:04:02

by Zong Li

[permalink] [raw]
Subject: Re: FW: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value

> Subject: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value
>
> The stvec's value must be 4 byte alignment by specification definition.
> These directives avoid to stvec be set the non-alignment value.
>
> Signed-off-by: Zong Li <[email protected]>
> ---
> arch/riscv/kernel/head.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S index 3b6293f..11066d5 100644
> --- a/arch/riscv/kernel/head.S
> +++ b/arch/riscv/kernel/head.S
> @@ -94,6 +94,7 @@ relocate:
> or a0, a0, a1
> sfence.vma
> csrw sptbr, a0
> +.align 2
> 1:
> /* Set trap vector to spin forever to help debug */
> la a0, .Lsecondary_park
> @@ -143,6 +144,7 @@ relocate:
> tail smp_callin
> #endif
>
> +.align 2
> .Lsecondary_park:
> /* We lack SMP support or have too many harts, so park this hart */
> wfi


ping


2018-08-10 02:13:54

by Palmer Dabbelt

[permalink] [raw]
Subject: Re: FW: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value

On Thu, 09 Aug 2018 17:37:39 PDT (-0700), [email protected] wrote:
>> Subject: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value
>>
>> The stvec's value must be 4 byte alignment by specification definition.
>> These directives avoid to stvec be set the non-alignment value.
>>
>> Signed-off-by: Zong Li <[email protected]>
>> ---
>> arch/riscv/kernel/head.S | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S index 3b6293f..11066d5 100644
>> --- a/arch/riscv/kernel/head.S
>> +++ b/arch/riscv/kernel/head.S
>> @@ -94,6 +94,7 @@ relocate:
>> or a0, a0, a1
>> sfence.vma
>> csrw sptbr, a0
>> +.align 2
>> 1:
>> /* Set trap vector to spin forever to help debug */
>> la a0, .Lsecondary_park
>> @@ -143,6 +144,7 @@ relocate:
>> tail smp_callin
>> #endif
>>
>> +.align 2
>> .Lsecondary_park:
>> /* We lack SMP support or have too many harts, so park this hart */
>> wfi

Thanks, this got lost in the shuffle somewhere. It's in for-next now.