2017-11-30 18:27:07

by Palmer Dabbelt

[permalink] [raw]
Subject: Re: [patches] [PATCH 06/10] RISC-V: Provide stub of setup_profiling_timer()

On Wed, 29 Nov 2017 17:55:17 PST (-0800), Olof Johansson wrote:
> Fixes the following on allmodconfig build:
>
> profile.c:(.text+0x3e4): undefined reference to `setup_profiling_timer'
>
> Signed-off-by: Olof Johansson <[email protected]>
> ---
> arch/riscv/kernel/smp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
> index b4a71ec..4498f0c 100644
> --- a/arch/riscv/kernel/smp.c
> +++ b/arch/riscv/kernel/smp.c
> @@ -38,6 +38,13 @@ enum ipi_message_type {
> IPI_MAX
> };
>
> +
> +/* Unsupported */
> +int setup_profiling_timer(unsigned int multiplier)
> +{
> + return -EINVAL;
> +}
> +
> irqreturn_t handle_ipi(void)
> {
> unsigned long *pending_ipis = &ipi_data[smp_processor_id()].bits;
> @@ -108,3 +115,4 @@ void smp_send_reschedule(int cpu)
> {
> send_ipi_message(cpumask_of(cpu), IPI_RESCHEDULE);
> }
> +

This adds a trailing newline, I'm going to drop it in my tree

commit 5c0a7217f172899ddacc32bac16549a274a5ae05
Author: Olof Johansson <[email protected]>
Date: Wed Nov 29 17:55:20 2017 -0800

RISC-V: Add missing include

Fixes:

include/asm-generic/mm_hooks.h:20:11: warning: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration
include/asm-generic/mm_hooks.h:19:38: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration

Signed-off-by: Olof Johansson <[email protected]>
Signed-off-by: Palmer Dabbelt <[email protected]>

diff --git a/arch/riscv/include/asm/mmu_context.h b/arch/riscv/include/asm/mmu_context.h
index de1fc1631fc4..1cd5172882c2 100644
--- a/arch/riscv/include/asm/mmu_context.h
+++ b/arch/riscv/include/asm/mmu_context.h
@@ -14,6 +14,7 @@
#ifndef _ASM_RISCV_MMU_CONTEXT_H
#define _ASM_RISCV_MMU_CONTEXT_H

+#include <linux/mm_types.h>
#include <asm-generic/mm_hooks.h>

#include <linux/mm.h>


From 1585454401841502441@xxx Thu Nov 30 01:59:02 +0000 2017
X-GM-THRID: 1585454401841502441
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread