2019-09-20 17:06:21

by Kefeng Wang

Subject: [PATCH 04/32] riscv: Use pr_warn instead of pr_warning

As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
pr_warning"), removing pr_warning so all logging messages use a
consistent <prefix>_warn style. Let's do it.

Cc: Paul Walmsley <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: Albert Ou <[email protected]>
Signed-off-by: Kefeng Wang <[email protected]>
---
arch/riscv/kernel/module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
index 70bb94ae61c5..b7401858d872 100644
--- a/arch/riscv/kernel/module.c
+++ b/arch/riscv/kernel/module.c
@@ -315,8 +315,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
/* Ignore unresolved weak symbol */
if (ELF_ST_BIND(sym->st_info) == STB_WEAK)
continue;
- pr_warning("%s: Unknown symbol %s\n",
- me->name, strtab + sym->st_name);
+ pr_warn("%s: Unknown symbol %s\n",
+ me->name, strtab + sym->st_name);
return -ENOENT;
}

--
2.20.1

2019-09-26 10:02:12

by Palmer Dabbelt

Subject: Re: [PATCH 04/32] riscv: Use pr_warn instead of pr_warning

On Thu, 19 Sep 2019 23:25:16 PDT (-0700), [email protected] wrote:
> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
> pr_warning"), removing pr_warning so all logging messages use a
> consistent <prefix>_warn style. Let's do it.
>
> Cc: Paul Walmsley <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>
> Cc: Albert Ou <[email protected]>
> Signed-off-by: Kefeng Wang <[email protected]>
> ---
> arch/riscv/kernel/module.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
> index 70bb94ae61c5..b7401858d872 100644
> --- a/arch/riscv/kernel/module.c
> +++ b/arch/riscv/kernel/module.c
> @@ -315,8 +315,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
> /* Ignore unresolved weak symbol */
> if (ELF_ST_BIND(sym->st_info) == STB_WEAK)
> continue;
> - pr_warning("%s: Unknown symbol %s\n",
> - me->name, strtab + sym->st_name);
> + pr_warn("%s: Unknown symbol %s\n",
> + me->name, strtab + sym->st_name);
> return -ENOENT;
> }

Acked-by: Palmer Dabbelt <[email protected]>

I'm assuming this is going in through some other tree, LMK if that's not the
case.