2020-10-29 07:59:48

by Atish Patra

Subject: [RFC PATCH 1/3] RISC-V: Add Microchip PolarFire SoC kconfig option

Add Microchip PolarFire kconfig option which selects SoC specific
and common drivers that is required for this SoC.

Signed-off-by: Atish Patra <[email protected]>
---
arch/riscv/Kconfig.socs | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 8a55f6156661..74d07250ecc5 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -22,6 +22,13 @@ config SOC_VIRT
help
This enables support for QEMU Virt Machine.

+config SOC_MICROCHIP_POLARFIRE
+ bool "Microchip PolarFire SoCs"
+ select MCHP_CLK_PFSOC
+ select SIFIVE_PLIC
+ help
+ This enables support for Microchip PolarFire SoC platforms.
+
config SOC_KENDRYTE
bool "Kendryte K210 SoC"
depends on !MMU
--
2.25.1

2020-10-30 09:10:22

by Anup Patel

Subject: Re: [RFC PATCH 1/3] RISC-V: Add Microchip PolarFire SoC kconfig option

On Thu, Oct 29, 2020 at 4:58 AM Atish Patra <[email protected]> wrote:
>
> Add Microchip PolarFire kconfig option which selects SoC specific
> and common drivers that is required for this SoC.
>
> Signed-off-by: Atish Patra <[email protected]>
> ---
> arch/riscv/Kconfig.socs | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 8a55f6156661..74d07250ecc5 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -22,6 +22,13 @@ config SOC_VIRT
> help
> This enables support for QEMU Virt Machine.
>
> +config SOC_MICROCHIP_POLARFIRE
> + bool "Microchip PolarFire SoCs"
> + select MCHP_CLK_PFSOC
> + select SIFIVE_PLIC
> + help
> + This enables support for Microchip PolarFire SoC platforms.
> +
> config SOC_KENDRYTE
> bool "Kendryte K210 SoC"
> depends on !MMU
> --
> 2.25.1
>

Looks good to me.

Reviewed-by: Anup Patel <[email protected]>

Regards,
Anup

2020-11-03 09:57:28

by Bin Meng

Subject: Re: [RFC PATCH 1/3] RISC-V: Add Microchip PolarFire SoC kconfig option

On Thu, Oct 29, 2020 at 6:00 PM Atish Patra <[email protected]> wrote:
>
> Add Microchip PolarFire kconfig option which selects SoC specific
> and common drivers that is required for this SoC.
>
> Signed-off-by: Atish Patra <[email protected]>
> ---
> arch/riscv/Kconfig.socs | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 8a55f6156661..74d07250ecc5 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -22,6 +22,13 @@ config SOC_VIRT
> help
> This enables support for QEMU Virt Machine.
>
> +config SOC_MICROCHIP_POLARFIRE

Please put this in the alphabetical order

> + bool "Microchip PolarFire SoCs"
> + select MCHP_CLK_PFSOC
> + select SIFIVE_PLIC
> + help
> + This enables support for Microchip PolarFire SoC platforms.
> +
> config SOC_KENDRYTE
> bool "Kendryte K210 SoC"
> depends on !MMU
> --

Otherwise LGTM
Reviewed-by: Bin Meng <[email protected]>

2020-11-06 07:16:16

by Palmer Dabbelt

Subject: Re: [RFC PATCH 1/3] RISC-V: Add Microchip PolarFire SoC kconfig option

On Wed, 28 Oct 2020 16:27:57 PDT (-0700), Atish Patra wrote:
> Add Microchip PolarFire kconfig option which selects SoC specific
> and common drivers that is required for this SoC.
>
> Signed-off-by: Atish Patra <[email protected]>
> ---
> arch/riscv/Kconfig.socs | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 8a55f6156661..74d07250ecc5 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -22,6 +22,13 @@ config SOC_VIRT
> help
> This enables support for QEMU Virt Machine.
>
> +config SOC_MICROCHIP_POLARFIRE
> + bool "Microchip PolarFire SoCs"
> + select MCHP_CLK_PFSOC
> + select SIFIVE_PLIC
> + help
> + This enables support for Microchip PolarFire SoC platforms.
> +
> config SOC_KENDRYTE
> bool "Kendryte K210 SoC"
> depends on !MMU

Reviewed-by: Palmer Dabbelt <[email protected]>