2021-12-29 19:25:18

by Lukas Bulwahn

Subject: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON

The config SYSCON never existed in the kernel repository; so, the select of
that config in ./drivers/soc/canaan/Kconfig has no effect.

Presumably, this was just some mistake, assuming some symmetry in handling
and naming of configs that simply does not exist.

Remove this useless select of a non-existing config.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/soc/canaan/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
index 853096b7e84c..2527cf5757ec 100644
--- a/drivers/soc/canaan/Kconfig
+++ b/drivers/soc/canaan/Kconfig
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
depends on RISCV && SOC_CANAAN && OF
default SOC_CANAAN
select PM
- select SYSCON
select MFD_SYSCON
help
Canaan Kendryte K210 SoC system controller driver.
--
2.17.1

2021-12-30 05:23:20

by Damien Le Moal

Subject: Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON

On Wed, 2021-12-29 at 20:24 +0100, Lukas Bulwahn wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.

My bad :)

Reviewed-by: Damien Le Moal <[email protected]>

--
Damien Le Moal
Western Digital Research

2022-01-21 22:30:15

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON

On Wed, 29 Dec 2021 11:24:58 PST (-0800), [email protected] wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
>
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
>
> Remove this useless select of a non-existing config.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/soc/canaan/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
> depends on RISCV && SOC_CANAAN && OF
> default SOC_CANAAN
> select PM
> - select SYSCON
> select MFD_SYSCON
> help
> Canaan Kendryte K210 SoC system controller driver.

Thanks, this is on for-next.