2019-11-15 05:38:43

by You-Sheng Yang

Subject: [PATCH] HID: i2c-hid: remove orphaned member sleep_delay

This was introduced in commit 00b790ea545b ("HID: i2c-hid: Add a small
delay after sleep command for Raydium touchpanel") which has been
effectively reverted by commit 67b18dfb8cfc ("HID: i2c-hid: Remove
runtime power management").

Signed-off-by: You-Sheng Yang <[email protected]>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 04c088131e04..adfe344bc786 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -157,8 +157,6 @@ struct i2c_hid {

bool irq_wake_enabled;
struct mutex reset_lock;
-
- unsigned long sleep_delay;
};

static const struct i2c_hid_quirks {
--
2.24.0

2019-11-15 12:24:14

by Jiri Kosina

Subject: Re: [PATCH] HID: i2c-hid: remove orphaned member sleep_delay

On Fri, 15 Nov 2019, You-Sheng Yang wrote:

> This was introduced in commit 00b790ea545b ("HID: i2c-hid: Add a small
> delay after sleep command for Raydium touchpanel") which has been
> effectively reverted by commit 67b18dfb8cfc ("HID: i2c-hid: Remove
> runtime power management").
>
> Signed-off-by: You-Sheng Yang <[email protected]>
> ---
> drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 04c088131e04..adfe344bc786 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -157,8 +157,6 @@ struct i2c_hid {
>
> bool irq_wake_enabled;
> struct mutex reset_lock;
> -
> - unsigned long sleep_delay;
> };

Applied, thanks.

--
Jiri Kosina
SUSE Labs